Commit cab9c4e
committed
PY-180 Change type inference in neptune-query for better UX (#406)
* PY-180 Change type inference in neptune-query for better UX
1. If the type cannot be inferred because the attribute doesn't exist in the project -> show a warning and infer as string
2. If the type cannot be inferred because the attribute has multiple types across the runs and experiments of the project -> raise an exception prompting the user to specify the type explicitly
* don't try to be smart and limit the attribute search to only runs/experiments matching some filters, etc
* Emit inference warnings for list_containers and list_attributes.
* Test warning is emmitted for missing attributes1 parent 0263a8f commit cab9c4e
File tree
8 files changed
+237
-243
lines changed- src/neptune_query/internal/composition
- tests
- e2e_query/internal/composition
- unit/internal/composition
8 files changed
+237
-243
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
88 | 87 | | |
89 | | - | |
90 | 88 | | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | 89 | | |
| 90 | + | |
101 | 91 | | |
102 | 92 | | |
103 | 93 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
85 | 84 | | |
86 | | - | |
87 | 85 | | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | 86 | | |
| 87 | + | |
97 | 88 | | |
98 | 89 | | |
99 | 90 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | | - | |
83 | 82 | | |
84 | | - | |
85 | 83 | | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | 84 | | |
| 85 | + | |
95 | 86 | | |
96 | 87 | | |
97 | 88 | | |
98 | 89 | | |
99 | | - | |
100 | 90 | | |
101 | | - | |
102 | 91 | | |
103 | | - | |
104 | 92 | | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
| 93 | + | |
| 94 | + | |
114 | 95 | | |
115 | 96 | | |
116 | 97 | | |
| |||
184 | 165 | | |
185 | 166 | | |
186 | 167 | | |
| 168 | + | |
187 | 169 | | |
188 | 170 | | |
189 | 171 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
66 | 65 | | |
67 | | - | |
68 | 66 | | |
69 | | - | |
70 | | - | |
71 | 67 | | |
| 68 | + | |
72 | 69 | | |
73 | 70 | | |
74 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
| 40 | + | |
44 | 41 | | |
45 | 42 | | |
46 | 43 | | |
47 | 44 | | |
48 | | - | |
49 | 45 | | |
50 | 46 | | |
51 | | - | |
52 | | - | |
53 | 47 | | |
| 48 | + | |
54 | 49 | | |
55 | 50 | | |
56 | 51 | | |
0 commit comments