Skip to content

Commit 86b1d3d

Browse files
Updated docstrings for experiment and run properties. Made log_configs() more performant
1 parent b4a8c7a commit 86b1d3d

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

src/lightning/pytorch/loggers/neptune.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -886,6 +886,12 @@ def __setstate__(self, state: dict[str, Any]) -> None:
886886
@property
887887
@rank_zero_experiment
888888
def experiment(self) -> "Run":
889+
r"""Alias for :meth:`run`."""
890+
return self.run
891+
892+
@property
893+
@rank_zero_experiment
894+
def run(self) -> "Run":
889895
r"""Actual Neptune run object. Allows you to use neptune logging features in your
890896
:class:`~lightning.pytorch.core.LightningModule`.
891897
@@ -905,11 +911,6 @@ def training_step(self, batch, batch_idx):
905911
with NeptuneScaleLogger.
906912
907913
"""
908-
return self.run
909-
910-
@property
911-
@rank_zero_experiment
912-
def run(self) -> "Run":
913914
from neptune_scale import Run
914915

915916
if not self._run_instance:
@@ -987,8 +988,8 @@ def flatten(d: dict, prefix: str = "") -> dict[str, Any]:
987988

988989
flattened = flatten(params)
989990

990-
for key, value in flattened.items():
991-
self.run.log_configs({f"{parameters_key}/{key}": value})
991+
batched_configs = {f"{parameters_key}/{key}": value for key, value in flattened.items()}
992+
self.run.log_configs(batched_configs)
992993

993994
@override
994995
@rank_zero_only

0 commit comments

Comments
 (0)