Skip to content

Commit af773d6

Browse files
Apply suggestions from code review
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
1 parent b018431 commit af773d6

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

src/lightning/pytorch/loggers/neptune.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1124,7 +1124,7 @@ def _get_full_model_name(model_path: str, checkpoint_callback: Checkpoint) -> No
11241124
return model_path.replace(os.sep, "/")
11251125

11261126
@classmethod
1127-
def _get_full_model_names_from_exp_structure(cls, exp_structure: dict[str, Any], namespace: str) -> set[None]:
1127+
def _get_full_model_names_from_exp_structure(cls, exp_structure: dict[str, Any], namespace: str) -> set[str]:
11281128
"""Returns all paths to properties which were already logged in `namespace`"""
11291129
structure_keys: list[str] = namespace.split(cls.LOGGER_JOIN_CHAR)
11301130
for key in structure_keys:

tests/tests_pytorch/loggers/test_neptune.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -531,9 +531,6 @@ def test_neptune_scale_logger_after_save_checkpoint(neptune_scale_logger):
531531
best_model_score=None,
532532
)
533533

534-
mock_file = neptune_scale_logger.types.File
535-
mock_file.reset_mock()
536-
mock_file.side_effect = mock.Mock()
537534
logger.after_save_checkpoint(cb_mock)
538535

539536
run_instance_mock.__getitem__.assert_any_call(f"{model_key_prefix}/checkpoints/model1")

0 commit comments

Comments
 (0)