Merge pull request #268 from naved001/further-lower-minimum

knikolla · web-flow · commit 95fc76bd3fdd · 2025-12-02T11:38:12.000-05:00
Further lower the minimum required CPU and memory
diff --git a/src/coldfront_plugin_cloud/openshift.py b/src/coldfront_plugin_cloud/openshift.py
@@ -40,7 +40,7 @@
         "type": "Container",
         "default": {"cpu": "1", "memory": "4096Mi", "nvidia.com/gpu": "0"},
         "defaultRequest": {"cpu": "500m", "memory": "2048Mi", "nvidia.com/gpu": "0"},
-        "min": {"cpu": "25m", "memory": "32Mi"},
+        "min": {"cpu": "1m", "memory": "1Ki"},
     }
 ]
 
diff --git a/src/coldfront_plugin_cloud/tests/unit/test_openshift_utils.py b/src/coldfront_plugin_cloud/tests/unit/test_openshift_utils.py
@@ -61,5 +61,5 @@ def test_limit_ranges_diff(self):
         self.assertTrue(openshift.LimitRangeDifference("foo", None, "bar") in diffs)
         self.assertTrue(openshift.LimitRangeDifference("default,cpu", 1, 2) in diffs)
         self.assertTrue(
-            openshift.LimitRangeDifference("min,memory", 32 * 2**20, None) in diffs
+            openshift.LimitRangeDifference("min,memory", 1 * 2**10, None) in diffs
         )

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@`
`40`	`40`	`"type": "Container",`
`41`	`41`	`"default": {"cpu": "1", "memory": "4096Mi", "nvidia.com/gpu": "0"},`
`42`	`42`	`"defaultRequest": {"cpu": "500m", "memory": "2048Mi", "nvidia.com/gpu": "0"},`
`43`		`- "min": {"cpu": "25m", "memory": "32Mi"},`
	`43`	`+ "min": {"cpu": "1m", "memory": "1Ki"},`
`44`	`44`	`}`
`45`	`45`	`]`
`46`	`46`
Original file line number	Diff line number	Diff line change
`@@ -61,5 +61,5 @@ def test_limit_ranges_diff(self):`
`61`	`61`	`self.assertTrue(openshift.LimitRangeDifference("foo", None, "bar") in diffs)`
`62`	`62`	`self.assertTrue(openshift.LimitRangeDifference("default,cpu", 1, 2) in diffs)`
`63`	`63`	`self.assertTrue(`
`64`		`- openshift.LimitRangeDifference("min,memory", 32 * 2**20, None) in diffs`
	`64`	`+ openshift.LimitRangeDifference("min,memory", 1 * 2**10, None) in diffs`
`65`	`65`	`)`