refactor: remove removePointFromNote feature and associated logic

- Deleted the removePointFromNote endpoint and its implementation in AiController.
- Removed related methods and classes, including NoteDetailsRephrase and associated AI tools.
- Updated OpenAPI documentation to reflect the removal of the feature.
- Cleaned up generated TypeScript types and SDK to eliminate references to the removed feature.

Co-authored-by: terry <terry@odd-e.com>

Author: terryyin

backend/src/main/java/com/odde/doughnut/controllers/AiController.java

@@ -4,11 +4,9 @@
 import com.odde.doughnut.controllers.dto.*;
 import com.odde.doughnut.entities.Note;
 import com.odde.doughnut.exceptions.UnexpectedNoAccessRightException;
-import com.odde.doughnut.factoryServices.EntityPersister;
 import com.odde.doughnut.services.AuthorizationService;
 import com.odde.doughnut.services.NotebookAssistantForNoteServiceFactory;
 import com.odde.doughnut.services.ai.OtherAiServices;
-import com.odde.doughnut.testability.TestabilitySettings;
 import io.swagger.v3.oas.annotations.media.Schema;
 import java.util.List;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -25,21 +23,15 @@ public class AiController {
   private final OtherAiServices otherAiServices;
   private final NotebookAssistantForNoteServiceFactory notebookAssistantForNoteServiceFactory;
   private final AuthorizationService authorizationService;
-  private final EntityPersister entityPersister;
-  private final TestabilitySettings testabilitySettings;
 
   @Autowired
   public AiController(
       NotebookAssistantForNoteServiceFactory notebookAssistantForNoteServiceFactory,
       OtherAiServices otherAiServices,
-      AuthorizationService authorizationService,
-      EntityPersister entityPersister,
-      TestabilitySettings testabilitySettings) {
+      AuthorizationService authorizationService) {
     this.notebookAssistantForNoteServiceFactory = notebookAssistantForNoteServiceFactory;
     this.otherAiServices = otherAiServices;
     this.authorizationService = authorizationService;
-    this.entityPersister = entityPersister;
-    this.testabilitySettings = testabilitySettings;
   }
 
   @GetMapping("/dummy")
@@ -87,24 +79,4 @@ public UnderstandingChecklistDTO generateUnderstandingChecklist(
             .generateUnderstandingChecklist();
     return new UnderstandingChecklistDTO(points);
   }
-
-  @PostMapping("/remove-point-from-note/{note}")
-  @Transactional
-  public NoteRealm removePointFromNote(
-      @PathVariable(value = "note") @Schema(type = "integer") Note note,
-      @RequestBody String pointToRemove)
-      throws UnexpectedNoAccessRightException, JsonProcessingException {
-    authorizationService.assertAuthorization(note);
-
-    String rephrasedDetails =
-        notebookAssistantForNoteServiceFactory
-            .createNoteAutomationService(note)
-            .removePointFromNote(pointToRemove);
-
-    note.setDetails(rephrasedDetails);
-    note.setUpdatedAt(testabilitySettings.getCurrentUTCTimestamp());
-    entityPersister.save(note);
-
-    return note.toNoteRealm(authorizationService.getCurrentUser());
-  }
 }

backend/src/main/java/com/odde/doughnut/services/NoteAutomationService.java

@@ -18,8 +18,4 @@ public String suggestTitle() throws JsonProcessingException {
   public java.util.List<String> generateUnderstandingChecklist() throws JsonProcessingException {
     return chatCompletionNoteAutomationService.generateUnderstandingChecklist();
   }
-
-  public String removePointFromNote(String pointToRemove) throws JsonProcessingException {
-    return chatCompletionNoteAutomationService.removePointFromNote(pointToRemove);
-  }
 }

backend/src/main/java/com/odde/doughnut/services/ai/ChatCompletionNoteAutomationService.java

@@ -39,14 +39,6 @@ public List<String> generateUnderstandingChecklist() throws JsonProcessingExcept
         List.of());
   }
 
-  public String removePointFromNote(String pointToRemove) throws JsonProcessingException {
-    return executeWithTool(
-        AiToolFactory.removePointFromNoteAiTool(pointToRemove),
-        NoteDetailsRephrase.class,
-        NoteDetailsRephrase::getDetails,
-        "");
-  }
-
   private <T, R> R executeWithTool(
       InstructionAndSchema tool, Class<T> resultClass, Function<T, R> extractor, R defaultValue)
       throws JsonProcessingException {

backend/src/main/java/com/odde/doughnut/services/ai/NoteDetailsRephrase.java

@@ -160,18 +160,6 @@ public static InstructionAndSchema generateUnderstandingChecklistAiTool() {
         generateUnderstandingChecklist());
   }
 
-  public static InstructionAndSchema removePointFromNoteAiTool(String pointToRemove) {
-    return new InstructionAndSchema(
-        "Please rephrase the note details to remove the following point that the user considers unrelated to the note. Preserve the overall meaning and flow of the remaining content. The point to remove is: \""
-            + pointToRemove
-            + "\"",
-        removePointFromNote());
-  }
-
-  public static Class<?> removePointFromNote() {
-    return NoteDetailsRephrase.class;
-  }
-
   public static List<Class<?>> getAllAssistantTools() {
     return List.of(
         completeNoteDetails(),

backend/src/main/java/com/odde/doughnut/services/ai/tools/AiToolFactory.java

@@ -7,7 +7,6 @@
 import static org.mockito.Mockito.*;
 
 import com.fasterxml.jackson.core.JsonProcessingException;
-import com.odde.doughnut.controllers.dto.NoteRealm;
 import com.odde.doughnut.controllers.dto.SuggestedTitleDTO;
 import com.odde.doughnut.controllers.dto.UnderstandingChecklistDTO;
 import com.odde.doughnut.entities.*;
@@ -283,92 +282,4 @@ void shouldRequireUserToBeLoggedIn() {
           ResponseStatusException.class, () -> controller.generateUnderstandingChecklist(testNote));
     }
   }
-
-  @Nested
-  class RemovePointFromNote {
-    Note testNote;
-    OpenAIChatCompletionMock openAIChatCompletionMock;
-
-    @BeforeEach
-    void setup() {
-      testNote = makeMe.aNote().creatorAndOwner(currentUser.getUser()).please();
-      openAIChatCompletionMock = new OpenAIChatCompletionMock(officialClient);
-    }
-
-    @Test
-    void shouldReturnRephrasedNoteDetails()
-        throws UnexpectedNoAccessRightException, JsonProcessingException {
-      testNote.setDetails(
-          "English serves as the world's most widespread lingua franca, vital for global communication.");
-      String pointToRemove = "English is the world's most widespread lingua franca";
-      String expectedRephrasedDetails =
-          "English plays a crucial role in global communication, enabling people from different cultures to understand one another.";
-
-      // Mock AI response with rephrased content
-      com.odde.doughnut.services.ai.NoteDetailsRephrase rephrasedNote =
-          new com.odde.doughnut.services.ai.NoteDetailsRephrase();
-      rephrasedNote.setDetails(expectedRephrasedDetails);
-      openAIChatCompletionMock.mockChatCompletionAndReturnJsonSchema(rephrasedNote);
-
-      NoteRealm result = controller.removePointFromNote(testNote, pointToRemove);
-
-      assertThat(result.getNote().getDetails()).isEqualTo(expectedRephrasedDetails);
-    }
-
-    @Test
-    void shouldCallChatCompletionWithRightMessage()
-        throws UnexpectedNoAccessRightException, JsonProcessingException {
-      testNote.setDetails("Some note details about English language.");
-      String pointToRemove = "English is the world's most widespread lingua franca";
-
-      com.odde.doughnut.services.ai.NoteDetailsRephrase rephrasedNote =
-          new com.odde.doughnut.services.ai.NoteDetailsRephrase();
-      rephrasedNote.setDetails("Rephrased details without the point.");
-      openAIChatCompletionMock.mockChatCompletionAndReturnJsonSchema(rephrasedNote);
-
-      controller.removePointFromNote(testNote, pointToRemove);
-
-      ArgumentCaptor<com.openai.models.chat.completions.ChatCompletionCreateParams> paramsCaptor =
-          ArgumentCaptor.forClass(
-              com.openai.models.chat.completions.ChatCompletionCreateParams.class);
-      verify(openAIChatCompletionMock.completionService()).create(paramsCaptor.capture());
-      com.openai.models.chat.completions.ChatCompletionCreateParams params =
-          paramsCaptor.getValue();
-
-      boolean hasPointToRemove =
-          params.messages().stream()
-              .map(Object::toString)
-              .anyMatch(msg -> msg.contains(pointToRemove));
-      MatcherAssert.assertThat(
-          "A message should contain the point to remove", hasPointToRemove, is(true));
-
-      boolean hasNoteDetails =
-          params.messages().stream()
-              .map(Object::toString)
-              .anyMatch(msg -> msg.contains("Some note details about English language"));
-      MatcherAssert.assertThat(
-          "A message should contain the original note details", hasNoteDetails, is(true));
-
-      MatcherAssert.assertThat(
-          "Should use responseFormat instead of tools",
-          params.responseFormat().isPresent(),
-          is(true));
-    }
-
-    @Test
-    void shouldRequireUserToBeLoggedIn() {
-      currentUser.setUser(null);
-      assertThrows(
-          ResponseStatusException.class,
-          () -> controller.removePointFromNote(testNote, "some point"));
-    }
-
-    @Test
-    void shouldRequireAccessToNote() {
-      Note otherUserNote = makeMe.aNote().please();
-      assertThrows(
-          UnexpectedNoAccessRightException.class,
-          () -> controller.removePointFromNote(otherUserNote, "some point"));
-    }
-  }
 }

backend/src/test/java/com/odde/doughnut/controllers/AiControllerTest.java

@@ -2917,33 +2917,6 @@ export type SuggestTitleResponses = {
 
 export type SuggestTitleResponse = SuggestTitleResponses[keyof SuggestTitleResponses];
 
-export type RemovePointFromNoteData = {
-    body: string;
-    path: {
-        note: number;
-    };
-    query?: never;
-    url: '/api/ai/remove-point-from-note/{note}';
-};
-
-export type RemovePointFromNoteErrors = {
-    /**
-     * Internal Server Error
-     */
-    500: string;
-};
-
-export type RemovePointFromNoteError = RemovePointFromNoteErrors[keyof RemovePointFromNoteErrors];
-
-export type RemovePointFromNoteResponses = {
-    /**
-     * OK
-     */
-    200: NoteRealm;
-};
-
-export type RemovePointFromNoteResponse = RemovePointFromNoteResponses[keyof RemovePointFromNoteResponses];
-
 export type GenerateUnderstandingChecklistData = {
     body?: never;
     path: {

generated/backend/index.ts

@@ -0,0 +1,9 @@
+Remove the "remove point from note" AI feature from backend.
+
+Scope:
+- Delete the `/api/ai/remove-point-from-note/{note}` endpoint and its service/tool chain.
+- Remove the backend unit tests that exercised this endpoint.
+- Regenerate OpenAPI and TypeScript client code after the removal.
+
+Out of scope:
+- `ignoredChecklistTopics` in the note assimilation payload stays for now.