refactor: update note assimilation process in recall tests

terryyin · terryyin · commit ca0d4a0e1649 · 2026-01-25T18:11:08.000+08:00
- Changed the assimilation process in feature files to use a consistent format for note assimilation.
- Updated step definitions to reflect the new method for opening the assimilation page.
- Adjusted scenarios to ensure clarity and consistency in note handling.

Co-authored-by: terry &lt;terry@odd-e.com&gt;
diff --git a/e2e_test/features/recall/browse_answer_and_notes_while_recalling.feature b/e2e_test/features/recall/browse_answer_and_notes_while_recalling.feature
@@ -9,15 +9,15 @@ Feature: Browse answers and notes while recalling
     Given I am logged in as an existing user
     And I have a notebook with the head note "English" which skips review
     And there are some notes:
-      | Title    | Details                        | Skip Memory Tracking | Parent Title |
-      | sedition | Sedition means incite violence | false                | English      |
-      | sedation | Put to sleep is sedation       | false                | English      |
-      | medical  |                                | true                 | English      |
-    And I am assimilating new note on day 1
+      | Title    | Details                        | Parent Title |
+      | sedition | Sedition means incite violence | English      |
+      | sedation | Put to sleep is sedation       | English      |
+      | medical  |                                | English      |
+    And I am assimilating the note "sedition"
     And I assimilate with the option of remembering spelling
 
   Scenario: View last answered question when the quiz answer was correct
-    Given I assimilated one note "sedation" on day 1
+    Given I assimilate the note "sedation"
     When I am recalling my note on day 2
     And I skip one question
     And I type my answer "sedition"
@@ -42,4 +42,4 @@ Feature: Browse answers and notes while recalling
     And I skip one question
     And I type my answer "sedition"
     When choose to remove the last memory tracker from recalls
-    Then On day 100 I should have "0/1/1" note for assimilation and "1/2/2" for recall
+    Then On day 100 I should have "0/2/2" note for assimilation and "1/2/2" for recall
diff --git a/e2e_test/features/recall/recall_quiz_ai_question.feature b/e2e_test/features/recall/recall_quiz_ai_question.feature
@@ -5,28 +5,30 @@ Feature: Repetition Quiz
     Given I am logged in as an existing user
     And I have a notebook with the head note "English" which skips review
     And there are some notes:
-      | Title    | Details                        | Skip Memory Tracking | Parent Title |
-      | sedition | Sedition means incite violence | false                | English      |
-      | sedation | Put to sleep is sedation       | false                | English      |
-      | medical  |                                | true                 | English      |
+      | Title    | Details                        | Parent Title |
+      | sedition | Sedition means incite violence | English      |
+      | sedation | Put to sleep is sedation       | English      |
+      | medical  |                                | English      |
 
   @usingMockedOpenAiService
   Scenario: AI generated question - incorrect answer
+    Given It's day 1, 8 hour
     Given OpenAI generates this question:
       | Question Stem                    | Correct Choice     | Incorrect Choice 1 | Incorrect Choice 2 |
       | What is the meaning of sedition? | to incite violence | to sleep           | Open Water Diver   |
-    And I assimilated one note "sedition" on day 1
+    And I assimilate the note "sedition"
     When I am recalling my note on day 2
     Then I should be asked "What is the meaning of sedition?"
     When I choose answer "to sleep"
     Then I should see that my MCQ answer "to sleep" is incorrect
 
   @usingMockedOpenAiService
   Scenario: AI generated question - correct answer
+    Given It's day 1, 8 hour
     Given OpenAI generates this question:
       | Question Stem                    | Correct Choice     | Incorrect Choice 1 | Incorrect Choice 2 |
       | What is the meaning of sedition? | to incite violence | to sleep           | Open Water Diver   |
-    And I assimilated one note "sedition" on day 1
+    And I assimilate the note "sedition"
     When I am recalling my note on day 2
     Then I should be asked "What is the meaning of sedition?"
     When I choose answer "to incite violence"
diff --git a/e2e_test/features/recall/recall_quiz_spelling_question.feature b/e2e_test/features/recall/recall_quiz_spelling_question.feature
@@ -11,7 +11,7 @@ Feature: Repetition Quiz
       | sedation         | Put to sleep is sedation       | English     |
 
   Scenario: Spelling quiz - incorrect answer
-    Given I am assimilating new note on day 1
+    Given I am assimilating the note "sedition"
     And I assimilate with the option of remembering spelling
     When I am recalling my note on day 2
     And I skip one question
@@ -20,7 +20,7 @@ Feature: Repetition Quiz
     Then I should see that my spelling answer "asdf" is incorrect
 
   Scenario: Spelling quiz - correct answer
-    Given I am assimilating new note on day 1
+    Given I am assimilating the note "sedition"
     And I assimilate with the option of remembering spelling
     When I am recalling my note on day 2
     And I skip one question
diff --git a/e2e_test/start/pageObjects/noteMoreOptionsDialog.ts b/e2e_test/start/pageObjects/noteMoreOptionsDialog.ts
@@ -85,16 +85,22 @@ const noteMoreOptionsDialog = () => {
       toolbarButton('Questions for the note').click()
       return questionListPage()
     },
-    assimilateNote() {
+    openAssimilationPage() {
       toolbarButton('Assimilate this note').click()
       cy.url().should('include', '/d/assimilate/')
       cy.pageIsNotLoading()
       // Wait for the assimilation page to load by checking for the "Keep for repetition" button
-      cy.findByRole(
-        'button',
-        { name: 'Keep for repetition' },
-        { timeout: 10000 }
-      ).should('be.visible')
+      cy.findByRole('button', {
+        name: 'Keep for repetition',
+        timeout: 10000,
+      })
+        .scrollIntoView()
+        .should('be.visible')
+    },
+    assimilateNote() {
+      this.openAssimilationPage()
+      cy.findByRole('button', { name: 'Keep for repetition' }).click()
+      cy.pageIsNotLoading()
     },
   }
 }
diff --git a/e2e_test/step_definitions/recall.ts b/e2e_test/step_definitions/recall.ts
@@ -107,7 +107,7 @@ Then('I am assimilating new note on day {int}', (day: number) => {
 When('I am assimilating the note {string}', (noteTitle: string) => {
   start.testability().backendTimeTravelTo(1, 8)
   cy.reload()
-  start.jumpToNotePage(noteTitle).moreOptions().assimilateNote()
+  start.jumpToNotePage(noteTitle).moreOptions().openAssimilationPage()
 })
 
 When(
@@ -120,6 +120,10 @@ When(
   }
 )
 
+Then('I assimilate the note {string}', (noteTitle: string) => {
+  start.jumpToNotePage(noteTitle).moreOptions().assimilateNote()
+})
+
 Then(
   'I set the level of {string} to be {int}',
   (noteTopology: string, level: number) => {
