refactor: move promote point logic from controller to service layer

- Extract note creation and update logic to NoteConstructionService
- Add getParentNoteId method to PromotionType enum for cleaner code
- Add vitest-test-results to gitignore

Author: EzraHwang

.gitignore

@@ -140,3 +140,4 @@ doughnut_mobile/android/app/local.properties
 # AI assistants
 .claude/
 .serena/
+frontend/vitest-test-results/

backend/src/main/java/com/odde/doughnut/controllers/AiController.java

@@ -6,7 +6,6 @@
 import com.odde.doughnut.controllers.dto.IgnorePointsRequestDTO;
 import com.odde.doughnut.controllers.dto.IgnorePointsResponseDTO;
 import com.odde.doughnut.entities.Note;
-import com.odde.doughnut.entities.User;
 import com.odde.doughnut.exceptions.UnexpectedNoAccessRightException;
 import com.odde.doughnut.factoryServices.EntityPersister;
 import com.odde.doughnut.services.AuthorizationService;
@@ -156,36 +155,15 @@ public PromotePointResponseDTO promotePoint(
 
     PromotePointRequestDTO.PromotionType promotionType = request.getPromotionType();
 
-    // 1. Call AI to generate result
-    PointExtractionResult result =
+    PointExtractionResult aiResult =
         notebookAssistantForNoteServiceFactory
             .createNoteAutomationService(note)
             .promotePoint(request.getPoint(), promotionType);
 
-    if (result == null) {
+    if (aiResult == null) {
       throw new RuntimeException("AI failed to generate extraction result");
     }
 
-    // 2. Determine parent based on promotion type
-    Integer parentNoteId =
-        promotionType == PromotePointRequestDTO.PromotionType.SIBLING
-            ? note.getParent().getId()
-            : note.getId();
-
-    // 3. Create new note under the determined parent
-    User user = authorizationService.getCurrentUser();
-    Note newNote =
-        noteConstructionService.createNoteUnderParentId(parentNoteId, result.newNoteTitle);
-    newNote.setDetails(result.newNoteDetails);
-    newNote.setUpdatedAt(testabilitySettings.getCurrentUTCTimestamp());
-    entityPersister.save(newNote);
-
-    // 4. Update original note's details
-    note.setUpdatedAt(testabilitySettings.getCurrentUTCTimestamp());
-    note.setDetails(result.updatedParentDetails);
-    entityPersister.save(note);
-
-    // 5. Return result
-    return new PromotePointResponseDTO(newNote.toNoteRealm(user), note.toNoteRealm(user));
+    return noteConstructionService.createNoteFromPromotedPoint(note, promotionType, aiResult);
   }
 }

backend/src/main/java/com/odde/doughnut/controllers/dto/PromotePointRequestDTO.java

@@ -1,5 +1,6 @@
 package com.odde.doughnut.controllers.dto;
 
+import com.odde.doughnut.entities.Note;
 import jakarta.validation.constraints.NotNull;
 import lombok.Getter;
 import lombok.Setter;
@@ -9,7 +10,11 @@
 public class PromotePointRequestDTO {
   public enum PromotionType {
     CHILD,
-    SIBLING
+    SIBLING;
+
+    public Integer getParentNoteId(Note note) {
+      return this == SIBLING ? note.getParent().getId() : note.getId();
+    }
   }
 
   private String point;

backend/src/main/java/com/odde/doughnut/services/NoteConstructionService.java

@@ -2,6 +2,9 @@
 
 import com.odde.doughnut.controllers.dto.NoteCreationDTO;
 import com.odde.doughnut.controllers.dto.NoteCreationResult;
+import com.odde.doughnut.controllers.dto.PromotePointRequestDTO;
+import com.odde.doughnut.controllers.dto.PromotePointResponseDTO;
+import com.odde.doughnut.services.ai.PointExtractionResult;
 import com.odde.doughnut.entities.Note;
 import com.odde.doughnut.entities.RelationType;
 import com.odde.doughnut.entities.User;
@@ -138,4 +141,24 @@ public Note createNoteAfter(
     entityPersister.save(note);
     return note;
   }
+
+  public PromotePointResponseDTO createNoteFromPromotedPoint(
+      Note originalNote,
+      PromotePointRequestDTO.PromotionType promotionType,
+      PointExtractionResult aiResult)
+      throws UnexpectedNoAccessRightException {
+    User user = authorizationService.getCurrentUser();
+    Timestamp currentUTCTimestamp = testabilitySettings.getCurrentUTCTimestamp();
+
+    Note newNote = createNoteUnderParentId(promotionType.getParentNoteId(originalNote), aiResult.newNoteTitle);
+    newNote.setDetails(aiResult.newNoteDetails);
+    newNote.setUpdatedAt(currentUTCTimestamp);
+    entityPersister.save(newNote);
+
+    originalNote.setUpdatedAt(currentUTCTimestamp);
+    originalNote.setDetails(aiResult.updatedParentDetails);
+    entityPersister.save(originalNote);
+
+    return new PromotePointResponseDTO(newNote.toNoteRealm(user), originalNote.toNoteRealm(user));
+  }
 }