fix: handle custom_internal_name check in ApplicationDeploymentJob.php

andrasbacsai · andrasbacsai · commit 1c4eb31d5946 · 2024-07-18T12:10:59.000+02:00
diff --git a/app/Jobs/ApplicationDeploymentJob.php b/app/Jobs/ApplicationDeploymentJob.php
@@ -1007,7 +1007,7 @@ private function rolling_update()
                 if ((bool) $this->application->settings->is_consistent_container_name_enabled) {
                     $this->application_deployment_queue->addLogEntry('Consistent container name feature enabled, rolling update is not supported.');
                 }
-                if (isset($this->application->settings->custom_internal_name)) {
+                if (str($this->application->settings->custom_internal_name)->isNotEmpty()) {
                     $this->application_deployment_queue->addLogEntry('Custom internal name is set, rolling update is not supported.');
                 }
                 if ($this->pull_request_id !== 0) {

Original file line number	Diff line number	Diff line change
`@@ -1007,7 +1007,7 @@ private function rolling_update()`
`1007`	`1007`	`if ((bool) $this->application->settings->is_consistent_container_name_enabled) {`
`1008`	`1008`	`$this->application_deployment_queue->addLogEntry('Consistent container name feature enabled, rolling update is not supported.');`
`1009`	`1009`	`}`
`1010`		`- if (isset($this->application->settings->custom_internal_name)) {`
	`1010`	`+ if (str($this->application->settings->custom_internal_name)->isNotEmpty()) {`
`1011`	`1011`	`$this->application_deployment_queue->addLogEntry('Custom internal name is set, rolling update is not supported.');`
`1012`	`1012`	`}`
`1013`	`1013`	`if ($this->pull_request_id !== 0) {`