fix: logical volumes could be overwritten with new path

andrasbacsai · andrasbacsai · commit 5799e6d8b00c · 2024-09-04T14:09:52.000+02:00
diff --git a/bootstrap/helpers/shared.php b/bootstrap/helpers/shared.php
@@ -3092,10 +3092,9 @@ function newParser(Application|Service $resource, int $pull_request_id = 0, ?int
                     $topLevel->get('volumes')->put($name, [
                         'name' => $name,
                     ]);
-
                     LocalPersistentVolume::updateOrCreate(
                         [
-                            'mount_path' => $target,
+                            'name' => $name,
                             'resource_id' => $originalResource->id,
                             'resource_type' => get_class($originalResource),
                         ],
@@ -3206,7 +3205,6 @@ function newParser(Application|Service $resource, int $pull_request_id = 0, ?int
             }
         }
         // convert environment variables to one format
-        ray($environment);
         $environment = convertComposeEnvironmentToArray($environment);
 
         // Add Coolify defined environments

Original file line number	Diff line number	Diff line change
`@@ -3092,10 +3092,9 @@ function newParser(Application\|Service $resource, int $pull_request_id = 0, ?int`
`3092`	`3092`	`$topLevel->get('volumes')->put($name, [`
`3093`	`3093`	`'name' => $name,`
`3094`	`3094`	`]);`
`3095`		`-`
`3096`	`3095`	`LocalPersistentVolume::updateOrCreate(`
`3097`	`3096`	`[`
`3098`		`- 'mount_path' => $target,`
	`3097`	`+ 'name' => $name,`
`3099`	`3098`	`'resource_id' => $originalResource->id,`
`3100`	`3099`	`'resource_type' => get_class($originalResource),`
`3101`	`3100`	`],`
`@@ -3206,7 +3205,6 @@ function newParser(Application\|Service $resource, int $pull_request_id = 0, ?int`
`3206`	`3205`	`}`
`3207`	`3206`	`}`
`3208`	`3207`	`// convert environment variables to one format`
`3209`		`- ray($environment);`
`3210`	`3208`	`$environment = convertComposeEnvironmentToArray($environment);`
`3211`	`3209`
`3212`	`3210`	`// Add Coolify defined environments`