Skip to content

Commit 5c05ea4

Browse files
authored
Merge pull request coollabsio#3347 from coollabsio/next
refactor: Improve handling of server timezones in scheduled backups
2 parents 7fabeec + a2dac93 commit 5c05ea4

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

app/Console/Kernel.php

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,12 @@ private function check_scheduled_backups($schedule)
137137
}
138138

139139
$server = $scheduled_backup->server();
140-
$serverTimezone = $server->settings->server_timezone;
140+
141+
if (! $server) {
142+
$serverTimezone = config('app.timezone');
143+
} else {
144+
$serverTimezone = $server->settings->server_timezone;
145+
}
141146

142147
if (isset(VALID_CRON_STRINGS[$scheduled_backup->frequency])) {
143148
$scheduled_backup->frequency = VALID_CRON_STRINGS[$scheduled_backup->frequency];
@@ -179,7 +184,11 @@ private function check_scheduled_tasks($schedule)
179184
}
180185

181186
$server = $scheduled_task->server();
182-
$serverTimezone = $server->settings->server_timezone ?: config('app.timezone');
187+
if (! $server) {
188+
$serverTimezone = config('app.timezone');
189+
} else {
190+
$serverTimezone = $server->settings->server_timezone ?: config('app.timezone');
191+
}
183192

184193
if (isset(VALID_CRON_STRINGS[$scheduled_task->frequency])) {
185194
$scheduled_task->frequency = VALID_CRON_STRINGS[$scheduled_task->frequency];

0 commit comments

Comments
 (0)