Skip to content

Commit 6639379

Browse files
authored
Merge pull request coollabsio#3522 from InfiniBrains/main
Add hint to "build variable" check in the enviroment variable tab. Remember the user what should be doing in order to make it work.
2 parents d60ff10 + a4d0f1d commit 6639379

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

resources/views/livewire/project/shared/environment-variable/add.blade.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
<x-forms.input x-show="$wire.is_multiline === false" x-cloak placeholder="production" id="value"
55
x-bind:label="$wire.is_multiline === false && 'Value'" required />
66
@if (data_get($parameters, 'application_uuid'))
7-
<x-forms.checkbox id="is_build_time" label="Build Variable?" />
7+
<x-forms.checkbox id="is_build_time"
8+
helper="If you are using Docker, remember to modify the file to be ready to receive the build time args. Ex.: for docker file, add `ARG name_of_the_variable`, or dockercompose add `- 'name_of_the_variable=${name_of_the_variable}'`"
9+
label="Build Variable?" />
810
@endif
911
<x-forms.checkbox id="is_multiline" label="Is Multiline?" />
1012
@if (!$shared)

resources/views/livewire/project/shared/environment-variable/show.blade.php

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,18 +42,24 @@ class="flex flex-col items-center gap-4 p-4 bg-white border lg:items-start dark:
4242
@endif
4343
<div class="flex flex-col w-full gap-2 lg:flex-row">
4444
@if ($type === 'service')
45-
<x-forms.checkbox instantSave id="env.is_build_time" label="Build Variable?" />
45+
<x-forms.checkbox instantSave id="env.is_build_time"
46+
helper="If you are using Docker, remember to modify the file to be ready to receive the build time args. Ex.: for docker file, add `ARG name_of_the_variable`, or dockercompose add `- 'name_of_the_variable=${name_of_the_variable}'`"
47+
label="Build Variable?" />
4648
@else
4749
@if ($env->is_shared)
48-
<x-forms.checkbox instantSave id="env.is_build_time" label="Build Variable?" />
50+
<x-forms.checkbox instantSave id="env.is_build_time"
51+
helper="If you are using Docker, remember to modify the file to be ready to receive the build time args. Ex.: for docker file, add `ARG name_of_the_variable`, or dockercompose add `- 'name_of_the_variable=${name_of_the_variable}'`"
52+
label="Build Variable?" />
4953
<x-forms.checkbox instantSave id="env.is_literal"
5054
helper="This means that when you use $VARIABLES in a value, it should be interpreted as the actual characters '$VARIABLES' and not as the value of a variable named VARIABLE.<br><br>Useful if you have $ sign in your value and there are some characters after it, but you would not like to interpolate it from another value. In this case, you should set this to true."
5155
label="Is Literal?" />
5256
@else
5357
@if ($isSharedVariable)
5458
<x-forms.checkbox instantSave id="env.is_multiline" label="Is Multiline?" />
5559
@else
56-
<x-forms.checkbox instantSave id="env.is_build_time" label="Build Variable?" />
60+
<x-forms.checkbox instantSave id="env.is_build_time"
61+
helper="If you are using Docker, remember to modify the file to be ready to receive the build time args. Ex.: for dockerfile, add `ARG name_of_the_variable`, or dockercompose add `- 'name_of_the_variable=${name_of_the_variable}'`"
62+
label="Build Variable?" />
5763
<x-forms.checkbox instantSave id="env.is_multiline" label="Is Multiline?" />
5864
@if (!data_get($env, 'is_multiline'))
5965
<x-forms.checkbox instantSave id="env.is_literal"

0 commit comments

Comments
 (0)