fix: scheduled backup for services view

Author: andrasbacsai

app/Livewire/Project/Database/ScheduledBackups.php

@@ -26,7 +26,7 @@ class ScheduledBackups extends Component
     public function mount(): void
     {
         if ($this->selectedBackupId) {
-            $this->setSelectedBackup($this->selectedBackupId);
+            $this->setSelectedBackup($this->selectedBackupId, true);
         }
         $this->parameters = get_route_parameters();
         if ($this->database->getMorphClass() === 'App\Models\ServiceDatabase') {
@@ -37,10 +37,13 @@ public function mount(): void
         $this->s3s = currentTeam()->s3s;
     }
 
-    public function setSelectedBackup($backupId)
+    public function setSelectedBackup($backupId, $force = false)
     {
+        if ($this->selectedBackupId === $backupId && ! $force) {
+            return;
+        }
         $this->selectedBackupId = $backupId;
-        $this->selectedBackup = $this->database->scheduledBackups->find($this->selectedBackupId);
+        $this->selectedBackup = $this->database->scheduledBackups->find($backupId);
         if (is_null($this->selectedBackup)) {
             $this->selectedBackupId = null;
         }

resources/views/livewire/project/database/scheduled-backups.blade.php

@@ -1,37 +1,38 @@
 <div>
     <div class="flex flex-col gap-2">
         @forelse($database->scheduledBackups as $backup)
-        @if ($type == 'database')
-        <a class="box"
-            href="{{ route('project.database.backup.execution', [...$parameters, 'backup_uuid' => $backup->uuid]) }}">
-            <div class="flex flex-col">
-                <div>Frequency: {{ $backup->frequency }}</div>
-                <div>Last backup: {{ data_get($backup->latest_log, 'status', 'No backup yet') }}</div>
-                <div>Number of backups to keep (locally): {{ $backup->number_of_backups_locally }}</div>
-            </div>
-        </a>
-        @else
-        <div class="box" wire:click="setSelectedBackup('{{ data_get($backup, 'id') }}')">
-            <div @class([ 'border-coollabs'=>
-                data_get($backup, 'id') === data_get($selectedBackup, 'id'),
-                'flex flex-col border-l-2 border-transparent',
-                ])>
-                <div>Frequency: {{ $backup->frequency }}</div>
-                <div>Last backup: {{ data_get($backup->latest_log, 'status', 'No backup yet') }}</div>
-                <div>Number of backups to keep (locally): {{ $backup->number_of_backups_locally }}</div>
-            </div>
-        </div>
-        @endif
+            @if ($type == 'database')
+                <a class="box"
+                    href="{{ route('project.database.backup.execution', [...$parameters, 'backup_uuid' => $backup->uuid]) }}">
+                    <div class="flex flex-col">
+                        <div>Frequency: {{ $backup->frequency }}</div>
+                        <div>Last backup: {{ data_get($backup->latest_log, 'status', 'No backup yet') }}</div>
+                        <div>Number of backups to keep (locally): {{ $backup->number_of_backups_locally }}</div>
+                    </div>
+                </a>
+            @else
+                <div class="box" wire:click="setSelectedBackup('{{ data_get($backup, 'id') }}')">
+                    <div @class([
+                        'border-coollabs' =>
+                            data_get($backup, 'id') === data_get($selectedBackup, 'id'),
+                        'flex flex-col border-l-2 border-transparent',
+                    ])>
+                        <div>Frequency: {{ $backup->frequency }}</div>
+                        <div>Last backup: {{ data_get($backup->latest_log, 'status', 'No backup yet') }}</div>
+                        <div>Number of backups to keep (locally): {{ $backup->number_of_backups_locally }}</div>
+                    </div>
+                </div>
+            @endif
         @empty
-        <div>No scheduled backups configured.</div>
+            <div>No scheduled backups configured.</div>
         @endforelse
     </div>
     @if ($type === 'service-database' && $selectedBackup)
-    <div class="pt-10">
-        <livewire:project.database.backup-edit wire:key="{{ $selectedBackup->id }}" :backup="$selectedBackup"
-            :s3s="$s3s" :status="data_get($database, 'status')" />
-        <h3 class="py-4">Executions</h3>
-        <livewire:project.database.backup-executions wire:key="{{ $selectedBackup->id }}" :backup="$selectedBackup" :database="$database" />
-    </div>
+        <div class="pt-10">
+            <livewire:project.database.backup-edit wire:key="{{ $selectedBackup->id }}" :backup="$selectedBackup"
+                :s3s="$s3s" :status="data_get($database, 'status')" />
+            <livewire:project.database.backup-executions wire:key="{{ $selectedBackup->uuid }}" :backup="$selectedBackup"
+                :database="$database" />
+        </div>
     @endif
 </div>