code cleanup

Author: peaklabs-dev

app/Jobs/DatabaseBackupJob.php

@@ -497,6 +497,7 @@ private function upload_to_s3(): void
 
             $this->ensureHelperImageAvailable();
 
+            $fullImageName = $this->getFullImageName();
             $commands[] = "docker run -d --network {$network} --name backup-of-{$this->backup->uuid} --rm -v $this->backup_location:$this->backup_location:ro {$fullImageName}";
             $commands[] = "docker exec backup-of-{$this->backup->uuid} mc config host add temporary {$endpoint} $key $secret";
             $commands[] = "docker exec backup-of-{$this->backup->uuid} mc cp $this->backup_location temporary/$bucket{$this->backup_dir}/";
@@ -513,17 +514,12 @@ private function upload_to_s3(): void
 
     private function ensureHelperImageAvailable(): void
     {
-        $settings = InstanceSettings::get();
-        $helperImage = config('coolify.helper_image');
-        $latestVersion = $settings->helper_version;
-        $fullImageName = "{$helperImage}:{$latestVersion}";
+        $fullImageName = $this->getFullImageName();
 
         $imageExists = $this->checkImageExists($fullImageName);
 
         if (!$imageExists) {
             $this->pullHelperImage($fullImageName);
-        } else {
-            return;
         }
     }
 
@@ -543,4 +539,12 @@ private function pullHelperImage(string $fullImageName): void
             throw new \RuntimeException($errorMessage);
         }
     }
+
+    private function getFullImageName(): string
+    {
+        $settings = InstanceSettings::get();
+        $helperImage = config('coolify.helper_image');
+        $latestVersion = $settings->helper_version;
+        return "{$helperImage}:{$latestVersion}";
+    }
 }