refactor: Add authorization check in ExecuteContainerCommand mount method

andrasbacsai · andrasbacsai · commit d373815f989b · 2024-09-17T16:28:28.000+02:00
diff --git a/app/Livewire/Project/Shared/ExecuteContainerCommand.php b/app/Livewire/Project/Shared/ExecuteContainerCommand.php
@@ -33,6 +33,9 @@ class ExecuteContainerCommand extends Component
 
     public function mount()
     {
+        if (! auth()->user()->isAdmin()) {
+            abort(403);
+        }
         $this->parameters = get_route_parameters();
         $this->containers = collect();
         $this->servers = collect();
@@ -130,7 +133,6 @@ public function connectToContainer()
     {
         try {
             $container_name = data_get($this->container, 'container.Names');
-            ray($this->container);
             if (is_null($container_name)) {
                 throw new \RuntimeException('Container not found.');
             }

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,9 @@ class ExecuteContainerCommand extends Component`
`33`	`33`
`34`	`34`	`public function mount()`
`35`	`35`	`{`
	`36`	`+ if (! auth()->user()->isAdmin()) {`
	`37`	`+ abort(403);`
	`38`	`+ }`
`36`	`39`	`$this->parameters = get_route_parameters();`
`37`	`40`	`$this->containers = collect();`
`38`	`41`	`$this->servers = collect();`
`@@ -130,7 +133,6 @@ public function connectToContainer()`
`130`	`133`	`{`
`131`	`134`	`try {`
`132`	`135`	`$container_name = data_get($this->container, 'container.Names');`
`133`		`- ray($this->container);`
`134`	`136`	`if (is_null($container_name)) {`
`135`	`137`	`throw new \RuntimeException('Container not found.');`
`136`	`138`	`}`