Skip to content

Commit df8c5c6

Browse files
authored
Merge branch 'next' into next
2 parents 68c065b + ea1be05 commit df8c5c6

File tree

57 files changed

+629
-797
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+629
-797
lines changed

.github/workflows/docker-image.yml

Lines changed: 0 additions & 44 deletions
This file was deleted.

.github/workflows/fix-php-code-style-issues

Lines changed: 0 additions & 25 deletions
This file was deleted.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
name: Lock closed Issues, Discussions, and PRs
2+
3+
on:
4+
schedule:
5+
- cron: '0 1 * * *'
6+
7+
jobs:
8+
lock-threads:
9+
runs-on: ubuntu-latest
10+
steps:
11+
- name: Lock threads after 30 days of inactivity
12+
uses: dessant/lock-threads@v5
13+
with:
14+
github-token: ${{ secrets.GITHUB_TOKEN }}
15+
issue-inactive-days: '30'
16+
pr-inactive-days: '30'
17+
discussion-inactive-days: '30'
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
name: Manage Stale Issues and PRs
2+
3+
on:
4+
schedule:
5+
- cron: '0 2 * * *'
6+
7+
jobs:
8+
manage-stale:
9+
runs-on: ubuntu-latest
10+
steps:
11+
- name: Manage stale issues and PRs
12+
uses: actions/stale@v9
13+
id: stale
14+
with:
15+
stale-issue-message: 'This issue will be automatically closed in a few days if no response is received. Please provide an update with the requested information.'
16+
stale-pr-message: 'This pull request will be automatically closed in a few days if no response is received. Please update your PR or comment if you would like to continue working on it.'
17+
close-issue-message: 'This issue has been automatically closed due to inactivity.'
18+
close-pr-message: 'This pull request has been automatically closed due to inactivity.'
19+
days-before-stale: 14
20+
days-before-close: 7
21+
stale-issue-label: '⏱︎ Stale'
22+
stale-pr-label: '⏱︎ Stale'
23+
only-labels: '💤 Waiting for feedback'
24+
remove-stale-when-updated: true
25+
operations-per-run: 100
26+
labels-to-remove-when-unstale: '⏱︎ Stale, 💤 Waiting for feedback'
27+
close-issue-reason: 'not_planned'
28+
exempt-all-milestones: false

.github/workflows/pr-build.yml

Lines changed: 0 additions & 93 deletions
This file was deleted.

RELEASE.md

Lines changed: 100 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,35 +2,120 @@
22

33
This guide outlines the release process for Coolify, intended for developers and those interested in understanding how releases are managed and deployed.
44

5+
## Table of Contents
6+
- [Release Process](#release-process)
7+
- [Version Types](#version-types)
8+
- [Stable](#stable)
9+
- [Nightly](#nightly)
10+
- [Beta](#beta)
11+
- [Version Availability](#version-availability)
12+
- [Self-Hosted](#self-hosted)
13+
- [Cloud](#cloud)
14+
- [Manually Update to Specific Versions](#manually-update-to-specific-versions)
15+
516
## Release Process
617

7-
1. **Development on `next` or separate branches**
8-
- Changes, fixes and new features are developed on the `next` or even separate branches.
18+
1. **Development on `next` or Feature Branches**
19+
- Improvements, fixes, and new features are developed on the `next` branch or separate feature branches.
920

1021
2. **Merging to `main`**
11-
- Once changes are ready, they are merged from `next` into the `main` branch.
22+
- Once ready, changes are merged from the `next` branch into the `main` branch.
1223

13-
3. **Building the release**
14-
- After merging to `main`, a new release is built.
15-
- Note: A push to `main` does not automatically mean a new version is released.
24+
3. **Building the Release**
25+
- After merging to `main`, GitHub Actions automatically builds release images for all architectures and pushes them to the GitHub Container Registry with the version tag and the `latest` tag.
1626

17-
4. **Creating a GitHub release**
18-
- A new release is created on GitHub with the new version details.
27+
4. **Creating a GitHub Release**
28+
- A new GitHub release is manually created with details of the changes made in the version.
1929

2030
5. **Updating the CDN**
21-
- The final step is updating the version information on the CDN:
22-
[https://cdn.coollabs.io/coolify/versions.json](https://cdn.coollabs.io/coolify/versions.json)
31+
- To make a new version publicly available, the version information on the CDN needs to be updated: [https://cdn.coollabs.io/coolify/versions.json](https://cdn.coollabs.io/coolify/versions.json)
2332

2433
> [!NOTE]
25-
> The CDN update may not occur immediately after the GitHub release. It can happen hours or even days later due to additional testing, stability checks, or potential hotfixes.
26-
34+
> The CDN update may not occur immediately after the GitHub release. It can take hours or even days due to additional testing, stability checks, or potential hotfixes. **The update becomes available only after the CDN is updated.**
35+
36+
## Version Types
37+
38+
<details>
39+
<summary><strong>Stable (coming soon)</strong></summary>
40+
41+
- **Stable**
42+
- The production version suitable for stable, production environments (generally recommended).
43+
- **Update Frequency:** Every 2 to 4 weeks, with more frequent possible hotfixes.
44+
- **Release Size:** Larger but less frequent releases. Multiple nightly versions are consolidated into a single stable release.
45+
- **Versioning Scheme:** Follows semantic versioning (e.g., `v4.0.0`).
46+
- **Installation Command:**
47+
```bash
48+
curl -fsSL https://cdn.coollabs.io/coolify/install.sh | bash
49+
```
50+
51+
</details>
52+
53+
<details>
54+
<summary><strong>Nightly</strong></summary>
55+
56+
- **Nightly**
57+
- The latest development version, suitable for testing the latest changes and experimenting with new features.
58+
- **Update Frequency:** Daily or bi-weekly updates.
59+
- **Release Size:** Smaller, more frequent releases.
60+
- **Versioning Scheme:** TO BE DETERMINED
61+
- **Installation Command:**
62+
```bash
63+
curl -fsSL https://cdn.coollabs.io/coolify-nightly/install.sh | bash -s next
64+
```
65+
66+
</details>
67+
68+
<details>
69+
<summary><strong>Beta</strong></summary>
70+
71+
- **Beta**
72+
- Test releases for the upcoming stable version.
73+
- **Purpose:** Allows users to test and provide feedback on new features and changes before they become stable.
74+
- **Update Frequency:** Available if we think beta testing is necessary.
75+
- **Release Size:** Same size as stable release as it will become the next stabe release after some time.
76+
- **Versioning Scheme:** Follows semantic versioning (e.g., `4.1.0-beta.1`).
77+
- **Installation Command:**
78+
```bash
79+
curl -fsSL https://cdn.coollabs.io/coolify/install.sh | bash
80+
```
81+
82+
</details>
83+
84+
> [!WARNING]
85+
> Do not use nightly/beta builds in production as there is no guarantee of stability.
2786

2887
## Version Availability
2988

30-
It's important to understand that a new version released on GitHub may not immediately become available for users to update (through manual or auto-update).
89+
When a new version is released and a new GitHub release is created, it doesn't immediately become available for your instance. Here's how version availability works for different instance types.
90+
91+
### Self-Hosted
92+
93+
- **Update Frequency:** More frequent updates, especially on the nightly release channel.
94+
- **Update Availability:** New versions are available once the CDN has been updated.
95+
- **Update Methods:**
96+
1. **Manual Update in Instance Settings:**
97+
- Go to `Settings > Update Check Frequency` and click the `Check Manually` button.
98+
- If an update is available, an upgrade button will appear on the sidebar.
99+
2. **Automatic Update:**
100+
- If enabled, the instance will update automatically at the time set in the settings.
101+
3. **Re-run Installation Script:**
102+
- Run the installation script again to upgrade to the latest version available on the CDN:
103+
```bash
104+
curl -fsSL https://cdn.coollabs.io/coolify/install.sh | bash
105+
```
106+
107+
> [!IMPORTANT]
108+
> If a new release is available on GitHub but your instance hasn't updated yet or no upgrade button is shown in the UI, the CDN might not have been updated yet. This intentional delay ensures stability and allows for hotfixes before official release.
109+
110+
### Cloud
111+
112+
- **Update Frequency:** Less frequent as it's a managed service.
113+
- **Update Availability:** New versions are available once Andras has updated the cloud version manually.
114+
- **Update Method:**
115+
- Updates are managed by Andras, who ensures each cloud version is thoroughly tested and stable before releasing it.
31116

32117
> [!IMPORTANT]
33-
> If you see a new release on GitHub but haven't received the update, it's likely because the CDN hasn't been updated yet. This is intentional and ensures stability and allows for hotfixes before the new version is officially released.
118+
> The cloud version of Coolify may be several versions behind the latest GitHub releases even if the CDN is updated. This is intentional to ensure stability and reliability for cloud users and Andras will manully update the cloud version when the update is ready.
34119

35120
## Manually Update to Specific Versions
36121

@@ -42,4 +127,4 @@ To update your Coolify instance to a specific (unreleased) version, use the foll
42127
```bash
43128
curl -fsSL https://cdn.coollabs.io/coolify/install.sh | bash -s <version>
44129
```
45-
-> Replace `<version>` with the version you want to update to (for example `4.0.0-beta.332`).
130+
Replace `<version>` with the version you want to update to (for example `4.0.0-beta.332`).

app/Actions/Docker/GetContainersStatus.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -651,8 +651,9 @@ private function old_way()
651651
// $this->server->team?->notify(new ContainerStopped($containerName, $this->server, $url));
652652
}
653653

654-
// Check if proxy is running
655-
$this->server->proxyType();
654+
if (! $this->server->proxySet() || $this->server->proxy->force_stop) {
655+
return;
656+
}
656657
$foundProxyContainer = $this->containers->filter(function ($value, $key) {
657658
if ($this->server->isSwarm()) {
658659
return data_get($value, 'Spec.Name') === 'coolify-proxy_traefik';

app/Actions/Proxy/StartProxy.php

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ public function handle(Server $server, bool $async = true, bool $force = false):
3535
"echo 'Creating required Docker Compose file.'",
3636
"echo 'Starting coolify-proxy.'",
3737
'docker stack deploy -c docker-compose.yml coolify-proxy',
38-
"echo 'Proxy started successfully.'",
38+
"echo 'Successfully started coolify-proxy.'",
3939
]);
4040
} else {
4141
$caddfile = 'import /dynamic/*.caddy';
@@ -46,12 +46,14 @@ public function handle(Server $server, bool $async = true, bool $force = false):
4646
"echo 'Creating required Docker Compose file.'",
4747
"echo 'Pulling docker image.'",
4848
'docker compose pull',
49-
"echo 'Stopping existing coolify-proxy.'",
50-
'docker stop -t 10 coolify-proxy || true',
51-
'docker rm coolify-proxy || true',
49+
'if docker ps -a --format "{{.Names}}" | grep -q "^coolify-proxy$"; then',
50+
" echo 'Stopping and removing existing coolify-proxy.'",
51+
' docker rm -f coolify-proxy || true',
52+
" echo 'Successfully stopped and removed existing coolify-proxy.'",
53+
'fi',
5254
"echo 'Starting coolify-proxy.'",
5355
'docker compose up -d --remove-orphans',
54-
"echo 'Proxy started successfully.'",
56+
"echo 'Successfully started coolify-proxy.'",
5557
]);
5658
$commands = $commands->merge(connectProxyToNetworks($server));
5759
}

0 commit comments

Comments
 (0)