release history on deployment group creation

Author: kybishop

lib/nerves_hub/managed_deployments.ex

@@ -195,7 +195,7 @@ defmodule NervesHub.ManagedDeployments do
   Update a deployment
 
   - Records audit logs depending on changes
-  - Creates deployment release record if firmware_id changed (requires user_id in params)
+  - Creates deployment release record if firmware_id or archive_id changed
   """
   @spec update_deployment_group(DeploymentGroup.t(), map, User.t()) ::
           {:ok, DeploymentGroup.t()} | {:error, Changeset.t()}
@@ -207,14 +207,17 @@ defmodule NervesHub.ManagedDeployments do
           |> Repo.preload(:firmware)
           |> DeploymentGroup.update_changeset(params)
 
+        create_deployment_release? =
+          Map.has_key?(changeset.changes, :firmware_id) or
+            Map.has_key?(changeset.changes, :archive_id)
+
         with {:ok, deployment_group} <- Repo.update(changeset),
              deployment_group = Repo.preload(deployment_group, [:firmware], force: true),
              :ok <- create_audit_logs!(deployment_group, changeset),
              {:ok, _deployment_group} <-
-               maybe_create_deployment_release(
-                 deployment_group,
-                 changeset.changes,
-                 user.id
+               if(create_deployment_release?,
+                 do: create_deployment_release(deployment_group, user.id),
+                 else: {:ok, nil}
                ) do
           {:ok, {deployment_group, changeset}}
         end
@@ -240,9 +243,7 @@ defmodule NervesHub.ManagedDeployments do
     end
   end
 
-  # Create deployment release if firmware or archive changed
-  defp maybe_create_deployment_release(deployment_group, changes, user_id)
-       when is_map_key(changes, :firmware_id) or is_map_key(changes, :archive_id) do
+  defp create_deployment_release(deployment_group, user_id) do
     %DeploymentRelease{}
     |> DeploymentRelease.changeset(%{
       deployment_group_id: deployment_group.id,
@@ -253,8 +254,6 @@ defmodule NervesHub.ManagedDeployments do
     |> Repo.insert()
   end
 
-  defp maybe_create_deployment_release(_deployment_group, _changes, _user_id), do: {:ok, nil}
-
   defp create_audit_logs!(deployment_group, changeset) do
     Enum.each(changeset.changes, fn
       {:archive_id, archive_id} ->
@@ -348,11 +347,17 @@ defmodule NervesHub.ManagedDeployments do
     Ecto.Changeset.change(%DeploymentGroup{})
   end
 
-  @spec create_deployment_group(map(), Product.t()) ::
+  @spec create_deployment_group(map(), Product.t(), User.t()) ::
           {:ok, DeploymentGroup.t()} | {:error, Changeset.t()}
-  def create_deployment_group(params, %Product{} = product) do
-    DeploymentGroup.create_changeset(params, product)
-    |> Repo.insert()
+  def create_deployment_group(params, %Product{} = product, user) do
+    Repo.transact(fn ->
+      changeset = DeploymentGroup.create_changeset(params, product)
+
+      with {:ok, deployment_group} <- Repo.insert(changeset),
+           {:ok, _release} <- create_deployment_release(deployment_group, user.id) do
+        {:ok, deployment_group}
+      end
+    end)
     |> case do
       {:ok, deployment_group} ->
         deployment_created_event(deployment_group)

lib/nerves_hub/managed_deployments/deployment_group.ex

@@ -38,7 +38,7 @@ defmodule NervesHub.ManagedDeployments.DeploymentGroup do
 
     has_many(:inflight_updates, InflightUpdate, foreign_key: :deployment_id)
     has_many(:devices, Device, foreign_key: :deployment_id, on_delete: :nilify_all)
-    has_many(:deployment_releases, DeploymentRelease)
+    has_many(:deployment_releases, DeploymentRelease, on_delete: :delete_all)
     has_many(:update_stats, UpdateStat, on_delete: :nilify_all, foreign_key: :deployment_id)
 
     embeds_one :conditions, __MODULE__.Conditions, primary_key: false, on_replace: :update do

lib/nerves_hub_web/controllers/api/deployment_group_controller.ex

@@ -29,7 +29,7 @@ defmodule NervesHubWeb.API.DeploymentGroupController do
       uuid ->
         with {:ok, firmware} <- Firmwares.get_firmware_by_product_and_uuid(product, uuid),
              params = Map.put(params, "firmware_id", firmware.id),
-             {:ok, deployment_group} <- ManagedDeployments.create_deployment_group(params, product) do
+             {:ok, deployment_group} <- ManagedDeployments.create_deployment_group(params, product, user) do
           DeploymentGroupTemplates.audit_deployment_created(user, deployment_group)
 
           conn

lib/nerves_hub_web/live/deployment_groups/new.ex

@@ -143,7 +143,7 @@ defmodule NervesHubWeb.Live.DeploymentGroups.New do
 
     %{user: user, org: org, product: product} = socket.assigns
 
-    ManagedDeployments.create_deployment_group(params, product)
+    ManagedDeployments.create_deployment_group(params, product, user)
     |> case do
       {:ok, deployment_group} ->
         _ = DeploymentGroupTemplates.audit_deployment_created(user, deployment_group)

priv/repo/migrations/20251206184125_add_cascade_delete_to_deployment_releases.exs

@@ -0,0 +1,23 @@
+defmodule NervesHub.Repo.Migrations.AddCascadeDeleteToDeploymentReleases do
+  use Ecto.Migration
+
+  def up do
+    # Drop the existing foreign key constraint
+    drop constraint(:deployment_releases, "deployment_releases_deployment_group_id_fkey")
+
+    # Add it back with cascade delete
+    alter table(:deployment_releases) do
+      modify :deployment_group_id, references(:deployments, on_delete: :delete_all), null: false
+    end
+  end
+
+  def down do
+    # Drop the cascade delete foreign key constraint
+    drop constraint(:deployment_releases, "deployment_releases_deployment_group_id_fkey")
+
+    # Add it back without cascade delete (original state)
+    alter table(:deployment_releases) do
+      modify :deployment_group_id, references(:deployments), null: false
+    end
+  end
+end