resolve missing comments

Author: Taras Tyshko

lib/nerves_hub/devices.ex

@@ -34,7 +34,7 @@ defmodule NervesHub.Devices do
   alias NervesHub.Products.Product
   alias NervesHub.Repo
   alias NervesHub.TaskSupervisor, as: Tasks
-  alias Phoenix.Channel.Server
+  alias Phoenix.Channel.Server, as: ChannelServer
 
   def get_device(device_id) when is_integer(device_id) do
     Repo.get(Device, device_id)
@@ -997,7 +997,7 @@ defmodule NervesHub.Devices do
     }
 
     topic = "orchestrator:deployment:#{device.deployment_id}"
-    _ = Server.broadcast(NervesHub.PubSub, topic, "device-online", payload)
+    _ = ChannelServer.broadcast(NervesHub.PubSub, topic, "device-online", payload)
 
     :ok
   end
@@ -1008,7 +1008,7 @@ defmodule NervesHub.Devices do
 
   def deployment_device_updated(device) do
     topic = "orchestrator:deployment:#{device.deployment_id}"
-    _ = Server.broadcast(NervesHub.PubSub, topic, "device-updated", %{})
+    _ = ChannelServer.broadcast(NervesHub.PubSub, topic, "device-updated", %{})
 
     :ok
   end
@@ -1151,7 +1151,7 @@ defmodule NervesHub.Devices do
         _ =
           if device.deployment_id do
             topic = "orchestrator:deployment:#{device.deployment_id}"
-            Server.broadcast(NervesHub.PubSub, topic, "device-updated", %{})
+            ChannelServer.broadcast(NervesHub.PubSub, topic, "device-updated", %{})
           end
 
         result
@@ -1628,7 +1628,7 @@ defmodule NervesHub.Devices do
     payload = %{inflight_update: inflight_update, update_payload: update_payload}
 
     topic = "device:#{device_id}"
-    _ = Server.broadcast(NervesHub.PubSub, topic, "update-scheduled", payload)
+    _ = ChannelServer.broadcast(NervesHub.PubSub, topic, "update-scheduled", payload)
 
     :ok
   end

lib/nerves_hub_web/components/core_components.ex

@@ -18,7 +18,7 @@ defmodule NervesHubWeb.CoreComponents do
 
   import NervesHubWeb.Components.Icons
 
-  alias Phoenix.HTML.Form, as: HTMLForm
+  alias Phoenix.HTML
 
   alias Phoenix.LiveView.JS
 
@@ -331,7 +331,7 @@ defmodule NervesHubWeb.CoreComponents do
                range radio search select tel text textarea time url week)
   )
 
-  attr(:field, Phoenix.HTML.FormField,
+  attr(:field, HTML.FormField,
     doc: "a form field struct retrieved from the form, for example: @form[:email]"
   )
 
@@ -351,7 +351,7 @@ defmodule NervesHubWeb.CoreComponents do
   slot(:inner_block)
   slot(:rich_hint)
 
-  def input(%{field: %Phoenix.HTML.FormField{} = field} = assigns) do
+  def input(%{field: %HTML.FormField{} = field} = assigns) do
     assigns
     |> assign(field: nil, id: assigns.id || field.id)
     |> assign(:errors, Enum.map(field.errors, &translate_error(&1)))
@@ -363,7 +363,7 @@ defmodule NervesHubWeb.CoreComponents do
   def input(%{type: "checkbox"} = assigns) do
     assigns =
       assign_new(assigns, :checked, fn ->
-        HTMLForm.normalize_value("checkbox", assigns[:value])
+        HTML.Form.normalize_value("checkbox", assigns[:value])
       end)
 
     ~H"""
@@ -393,7 +393,7 @@ defmodule NervesHubWeb.CoreComponents do
         {@rest}
       >
         <option :if={@prompt} value="">{@prompt}</option>
-        {HTMLForm.options_for_select(@options, @value)}
+        {HTML.Form.options_for_select(@options, @value)}
       </select>
       <div :if={assigns[:hint] || assigns[:rich_hint]} class="text-xs text-zinc-400">
         {assigns[:hint] || render_slot(assigns[:rich_hint])}
@@ -417,7 +417,7 @@ defmodule NervesHubWeb.CoreComponents do
           @errors != [] && "border-red-500 focus:border-red-500"
         ]}
         {@rest}
-      ><%= HTMLForm.normalize_value("textarea", @value) %></textarea>
+      ><%= HTML.Form.normalize_value("textarea", @value) %></textarea>
       <div :if={assigns[:hint] || assigns[:rich_hint]} class="flex flex-col gap-1 text-xs text-zinc-400 pt-1">
         {assigns[:hint] || render_slot(assigns[:rich_hint])}
       </div>
@@ -436,7 +436,7 @@ defmodule NervesHubWeb.CoreComponents do
         type={@type}
         name={@name}
         id={@id}
-        value={HTMLForm.normalize_value(@type, @value)}
+        value={HTML.Form.normalize_value(@type, @value)}
         class={[
           "mt-2 py-1.5 px-2 block w-full rounded text-zinc-400 bg-zinc-900 focus:ring-0 sm:text-sm",
           "phx-no-feedback:border-zinc-600 phx-no-feedback:focus:border-zinc-700",
@@ -465,7 +465,7 @@ defmodule NervesHubWeb.CoreComponents do
         type={@type}
         name={@name}
         id={@id}
-        value={HTMLForm.normalize_value(@type, @value)}
+        value={HTML.Form.normalize_value(@type, @value)}
         class={[
           "mt-2 py-1.5 px-2 block w-full rounded text-zinc-400 bg-zinc-900 focus:ring-0 sm:text-sm",
           "phx-no-feedback:border-zinc-600 phx-no-feedback:focus:border-zinc-700",