Fix some dialyzer issues

Author: joshk

lib/nerves_hub_web.ex

@@ -93,6 +93,15 @@ defmodule NervesHubWeb do
 
       alias NervesHubWeb.Components.Navigation
 
+      @type tab ::
+              :archives
+              | :deployments
+              | :devices
+              | :firmware
+              | :insights
+              | :settings
+              | :support_scripts
+
       # Routes generation with the ~p sigil
       unquote(verified_routes())
 
@@ -106,10 +115,7 @@ defmodule NervesHubWeb do
 
       def page_title(socket, page_title), do: assign(socket, :page_title, page_title)
 
-      @spec sidebar_tab(
-              Phoenix.Socket.t(),
-              :archives | :firmware | :deployments | :devices | :settings | :support_scripts
-            ) :: Phoenix.Socket.t()
+      @spec sidebar_tab(Phoenix.LiveView.Socket.t(), tab()) :: Phoenix.LiveView.Socket.t()
       def sidebar_tab(socket, tab) do
         socket
         |> assign(:sidebar_tab, tab)

lib/nerves_hub_web/live/devices/show.ex

@@ -523,8 +523,8 @@ defmodule NervesHubWeb.Live.Devices.Show do
     socket = stream(socket, :presences, [])
 
     if connected?(socket) do
-      Presence.track_user(topic, user.id, %{name: user.name})
-      Presence.subscribe(topic)
+      {:ok, _} = Presence.track_user(topic, user.id, %{name: user.name})
+      _ = Presence.subscribe(topic)
       stream(socket, :presences, Presence.list_online_users(topic))
     else
       socket