Match deployments to devices with nil tags (#2244)

Co-authored-by: Nate Shoemaker <[email protected]>

Author: lawik

lib/nerves_hub/devices/device.ex

@@ -95,7 +95,6 @@ defmodule NervesHub.Devices.Device do
     |> cast_embed(:firmware_metadata)
     |> cast_embed(:extensions)
     |> validate_required(@required_params)
-    |> validate_length(:tags, min: 1)
     |> unique_constraint(:identifier)
     |> then(fn changeset ->
       if device.deleted_at && !Map.has_key?(changeset.changes, :deleted_at) do

lib/nerves_hub/managed_deployments.ex

@@ -506,7 +506,16 @@ defmodule NervesHub.ManagedDeployments do
     |> ignore_same_deployment_group(device)
     |> where([d, firmware: f], f.platform == ^device.firmware_metadata.platform)
     |> where([d, firmware: f], f.architecture == ^device.firmware_metadata.architecture)
-    |> where([d], fragment("?->'tags' <@ to_jsonb(?::text[])", d.conditions, ^device.tags))
+    |> where(
+      [d],
+      fragment(
+        "?->'tags' <@ to_jsonb(?::text[]) OR (jsonb_array_length(?->'tags') = 0 and ?::text[] is null)",
+        d.conditions,
+        ^device.tags,
+        d.conditions,
+        ^device.tags
+      )
+    )
     |> Repo.all()
     |> Enum.filter(&version_match?(device, &1))
     |> Enum.sort_by(

test/nerves_hub/managed_deployments_test.exs

@@ -248,7 +248,7 @@ defmodule NervesHub.ManagedDeploymentsTest do
     end
   end
 
-  describe "device's matching deployments" do
+  describe "devices matching deployments" do
     test "finds all matching deployments", state do
       %{org: org, product: product, firmware: firmware} = state
 
@@ -277,6 +277,58 @@ defmodule NervesHub.ManagedDeploymentsTest do
              ] = ManagedDeployments.matching_deployment_groups(device)
     end
 
+    test "finds matching deployment with no tag condition", state do
+      %{org: org, product: product, firmware: firmware} = state
+
+      %{id: blank_deployment_group_id} =
+        Fixtures.deployment_group_fixture(org, firmware, %{
+          name: "beta",
+          conditions: %{"tags" => [], "version" => ""}
+        })
+
+      Fixtures.deployment_group_fixture(org, firmware, %{
+        name: "rpi",
+        conditions: %{"tags" => ["rpi"], "version" => ""}
+      })
+
+      Fixtures.deployment_group_fixture(org, firmware, %{
+        name: "rpi0",
+        conditions: %{"tags" => ["rpi0"], "version" => ""}
+      })
+
+      %{tags: []} = device = Fixtures.device_fixture(org, product, firmware, %{tags: []})
+
+      assert [
+               %{id: ^blank_deployment_group_id}
+             ] = ManagedDeployments.matching_deployment_groups(device)
+    end
+
+    test "finds matching deployment when device tags is null", state do
+      %{org: org, product: product, firmware: firmware} = state
+
+      %{id: blank_deployment_group_id} =
+        Fixtures.deployment_group_fixture(org, firmware, %{
+          name: "beta",
+          conditions: %{"tags" => [], "version" => ""}
+        })
+
+      Fixtures.deployment_group_fixture(org, firmware, %{
+        name: "rpi",
+        conditions: %{"tags" => ["rpi"], "version" => ""}
+      })
+
+      Fixtures.deployment_group_fixture(org, firmware, %{
+        name: "rpi0",
+        conditions: %{"tags" => ["rpi0"], "version" => ""}
+      })
+
+      %{tags: nil} = device = Fixtures.device_fixture(org, product, firmware, %{tags: nil})
+
+      assert [
+               %{id: ^blank_deployment_group_id}
+             ] = ManagedDeployments.matching_deployment_groups(device)
+    end
+
     test "finds matching deployments including the platform", state do
       %{org: org, org_key: org_key, product: product} = state