Add unitest for Audit Logs pagination at Device page

Author: Taras Tyshko

.gitignore

@@ -21,4 +21,6 @@ test/fixtures/ssl/device-root-ca.srl
 .elixir-tools
 
 .DS_Store
-/cover/
+.idea/
+/cover/
+nerves_hub.iml

lib/nerves_hub_web/components/device_page/activity_tab.ex

@@ -99,7 +99,7 @@ defmodule NervesHubWeb.Components.DevicePage.ActivityTab do
   end
 
   def hooked_event("set-paginate-opts", %{"page-size" => page_size}, socket) do
-    params = %{"page_size" => page_size, "page_number" => 1}
+    params = %{"page_size" => page_size, "page_number" => "1"}
 
     %{org: org, product: product, device: device} = socket.assigns
 

lib/nerves_hub_web/live/devices/show.ex

@@ -491,15 +491,11 @@ defmodule NervesHubWeb.Live.Devices.Show do
   end
 
   def handle_event("set-paginate-opts", %{"page-size" => page_size}, socket) do
-    params = %{"page_size" => page_size, "page_number" => 1}
-
+    params = %{"page_size" => page_size, "page_number" => "1"}
     %{org: org, product: product, device: device} = socket.assigns
+    url = ~p"/org/#{org}/#{product}/devices/#{device}?#{params}"
 
-    url = ~p"/org/#{org}/#{product}/devices/#{device}/activity?#{params}"
-
-    socket
-    |> push_patch(to: url)
-    |> noreply()
+    socket |> push_patch(to: url) |> noreply()
   end
 
   def handle_event("select-firmware-version", _, socket) do

test/nerves_hub_web/live/devices/show_test.exs

@@ -686,6 +686,78 @@ defmodule NervesHubWeb.Live.Devices.ShowTest do
     end
   end
 
+  describe "audit logs pagination" do
+    test "pagination works with URL parameters", %{
+      conn: conn,
+      org: org,
+      product: product,
+      device: device,
+      user: user
+    } do
+      # Create multiple audit log entries for pagination testing
+      Enum.each(1..12, fn i ->
+        NervesHub.AuditLogs.audit!(
+          user,
+          device,
+          "Test audit log entry #{i}"
+        )
+      end)
+
+      # Test page 1 with default page_size=5
+      conn
+      |> visit("/org/#{org.name}/#{product.name}/devices/#{device.identifier}")
+      |> assert_has("div.audit-log-item", count: 5)
+      |> assert_has("button[phx-value-page=\"2\"]")
+
+      # Test page 2 with page_size=5
+      conn
+      |> visit(
+        "/org/#{org.name}/#{product.name}/devices/#{device.identifier}?page_number=2&page_size=5"
+      )
+      # Still showing 5 per page
+      |> assert_has("div.audit-log-item", count: 5)
+      |> assert_has("button[phx-value-page=\"1\"]")
+
+      # Test custom page_size=10
+      conn
+      |> visit(
+        "/org/#{org.name}/#{product.name}/devices/#{device.identifier}?page_number=1&page_size=10"
+      )
+      |> assert_has("div.audit-log-item", count: 10)
+    end
+
+    test "pagination events work correctly", %{
+      conn: conn,
+      org: org,
+      product: product,
+      device: device,
+      user: user
+    } do
+      # Create enough audit logs for pagination
+      Enum.each(1..8, fn i ->
+        NervesHub.AuditLogs.audit!(
+          user,
+          device,
+          "Pagination test entry #{i}"
+        )
+      end)
+
+      {:ok, view, _html} =
+        live(conn, "/org/#{org.name}/#{product.name}/devices/#{device.identifier}")
+
+      # Test paginate event
+      view
+      |> element("button[phx-click=\"paginate\"][phx-value-page=\"2\"]", "2")
+      |> render_click()
+
+      # Should redirect to page 2 on same device page
+      assert_patch(
+        view,
+        "/org/#{org.name}/#{product.name}/devices/#{device.identifier}?page_number=2&page_size=5"
+      )
+    end
+  end
+
   def device_show_path(%{device: device, org: org, product: product}) do
     ~p"/org/#{org}/#{product}/devices/#{device}"
   end

test/nerves_hub_web/live/new_ui/devices/activity_tab_test.exs

@@ -32,4 +32,109 @@ defmodule NervesHubWeb.Live.NewUI.Devices.ActivityTabTest do
     |> visit("/org/#{org.name}/#{product.name}/devices/#{device.identifier}/activity")
     |> assert_has("div", text: "User #{user.name} rebooted device #{device.identifier}")
   end
+
+  describe "pagination" do
+    test "pagination works with URL parameters", %{
+      conn: conn,
+      org: org,
+      product: product,
+      device: device,
+      user: user
+    } do
+      # Create multiple audit log entries for pagination testing (30 entries)
+      Enum.each(1..30, fn i ->
+        NervesHub.AuditLogs.audit!(
+          user,
+          device,
+          "New UI test audit log entry #{i}"
+        )
+      end)
+
+      # Test page 1 with default page_size=25
+      conn
+      |> visit("/org/#{org.name}/#{product.name}/devices/#{device.identifier}/activity")
+      |> assert_has("div.flex.items-center.gap-6", count: 25)
+      |> assert_has("button[phx-value-page=\"2\"]")
+
+      # Test page 2 with page_size=25
+      conn
+      |> visit(
+        "/org/#{org.name}/#{product.name}/devices/#{device.identifier}/activity?page_number=2&page_size=25"
+      )
+      # Remaining 5 entries
+      |> assert_has("div.flex.items-center.gap-6", count: 5)
+      |> assert_has("button[phx-value-page=\"1\"]")
+
+      # Test custom page_size=10
+      conn
+      |> visit(
+        "/org/#{org.name}/#{product.name}/devices/#{device.identifier}/activity?page_number=1&page_size=10"
+      )
+      |> assert_has("div.flex.items-center.gap-6", count: 10)
+      |> assert_has("button[phx-value-page=\"2\"]")
+      |> assert_has("button[phx-value-page=\"3\"]")
+    end
+
+    test "pagination events work correctly", %{
+      conn: conn,
+      org: org,
+      product: product,
+      device: device,
+      user: user
+    } do
+      # Create enough audit logs for pagination
+      Enum.each(1..30, fn i ->
+        NervesHub.AuditLogs.audit!(
+          user,
+          device,
+          "New UI pagination test entry #{i}"
+        )
+      end)
+
+      {:ok, view, _html} =
+        live(conn, "/org/#{org.name}/#{product.name}/devices/#{device.identifier}/activity")
+
+      # Test paginate event
+      view
+      |> element("button[phx-click=\"paginate\"][phx-value-page=\"2\"]", "2")
+      |> render_click()
+
+      # Should redirect to page 2 on activity page
+      assert_patch(
+        view,
+        "/org/#{org.name}/#{product.name}/devices/#{device.identifier}/activity?page_number=2&page_size=25"
+      )
+    end
+
+    test "page size selection works correctly", %{
+      conn: conn,
+      org: org,
+      product: product,
+      device: device,
+      user: user
+    } do
+      # Create 60 audit logs for testing page size changes
+      Enum.each(1..60, fn i ->
+        NervesHub.AuditLogs.audit!(
+          user,
+          device,
+          "Page size test entry #{i}"
+        )
+      end)
+
+      {:ok, view, _html} =
+        live(conn, "/org/#{org.name}/#{product.name}/devices/#{device.identifier}/activity")
+
+      # Test changing page size to 50
+      view
+      |> element("button[phx-click=\"set-paginate-opts\"][phx-value-page-size=\"50\"]")
+      |> render_click()
+
+      # Should redirect to page 1 with page_size=50
+      assert_patch(
+        view,
+        "/org/#{org.name}/#{product.name}/devices/#{device.identifier}/activity?page_number=1&page_size=50"
+      )
+    end
+  end
 end