Device filter inflight (#2261)

This should allow watching updates as they happen. It'll be a lot better
if we land the changes to live updating. But this adds the filter and a
link on the summary page whenever devices are actively updating.

Author: lawik

lib/nerves_hub/devices/device_filtering.ex

@@ -7,6 +7,7 @@ defmodule NervesHub.Devices.DeviceFiltering do
 
   alias NervesHub.Devices.Alarms
   alias NervesHub.Devices.DeviceMetric
+  alias NervesHub.Devices.InflightUpdate
   alias NervesHub.Types.Tag
 
   @spec build_filters(Ecto.Query.t(), %{optional(atom) => String.t()}) :: Ecto.Query.t()
@@ -124,6 +125,16 @@ defmodule NervesHub.Devices.DeviceFiltering do
   def filter(query, _filters, :display_deleted, "only"),
     do: where(query, [d], not is_nil(d.deleted_at))
 
+  def filter(query, _filters, :only_updating, false),
+    do: query
+
+  def filter(query, _filters, :only_updating, true),
+    do:
+      join(query, :inner, [d], iu in InflightUpdate,
+        on: d.id == iu.device_id,
+        as: :inflight_update
+      )
+
   def filter(query, _filters, :search, value) when is_binary(value) and value != "" do
     search_term = "%#{value}%"
 

lib/nerves_hub_web/components/deployment_group_page/summary.ex

@@ -110,10 +110,16 @@ defmodule NervesHubWeb.Components.DeploymentGroupPage.Summary do
             </div>
             <div class="flex flex-col gap-3">
               <div :if={@inflight_updates == []} class="flex gap-4 items-center">
-                <span class="text-sm text-nerves-gray-500">No devices are currently updating</span>
+                <span class="text-sm text-nerves-gray-500">No devices are currently updating.</span>
               </div>
               <div :if={@inflight_updates != []} class="flex gap-4 items-center">
-                <span class="text-sm text-nerves-gray-500"><span class="font-semibold">{Enum.count(@inflight_updates)}</span> device(s) are currently updating</span>
+                <span class="text-sm text-nerves-gray-500">
+                  <span class="font-semibold">{Enum.count(@inflight_updates)}</span>
+                  device(s) are currently updating.
+                  <.link class="text-base-300 underline" navigate={~p"/org/#{@org}/#{@product}/devices?#{[only_updating: true, sort: "connection_established_at", sort_direction: "desc"]}"}>
+                    View details
+                  </.link>
+                </span>
               </div>
               <div :for={inflight_update <- @inflight_updates} :if={@inflight_updates != []} class="flex gap-4 items-center">
                 <span class="flex h-7 py-1 px-2 items-center rounded bg-zinc-800 text-base-300">

lib/nerves_hub_web/live/devices/index-new.html.heex

@@ -408,6 +408,7 @@
       {"Only deleted devices", "only"}
     ]}
   />
+  <:filter attr="only_updating" label="Update status" type={:select} values={[{"All", "false"}, {"Updating", "true"}]} />
 </FilterSidebar.render>
 
 <div class="pointer-events-none fixed inset-y-0 right-0 flex max-w-full pl-10 mb-[119px] sm:pl-16 z-40">

lib/nerves_hub_web/live/devices/index.ex

@@ -47,7 +47,8 @@ defmodule NervesHubWeb.Live.Devices.Index do
     deployment_id: "",
     is_pinned: false,
     search: "",
-    display_deleted: "exclude"
+    display_deleted: "exclude",
+    only_updating: false
   }
 
   @filter_types %{
@@ -69,7 +70,8 @@ defmodule NervesHubWeb.Live.Devices.Index do
     deployment_id: :string,
     is_pinned: :boolean,
     search: :string,
-    display_deleted: :string
+    display_deleted: :string,
+    only_updating: :boolean
   }
 
   @default_page 1

test/nerves_hub_web/live/new_ui/devices/index_test.exs

@@ -256,6 +256,39 @@ defmodule NervesHubWeb.Live.NewUI.Devices.IndexTest do
       |> assert_has("a", text: deleted_device.identifier, timeout: 1000, exact: false)
       |> refute_has("a", text: device.identifier, exact: false)
     end
+
+    test "filter only updating devices", %{
+      conn: conn,
+      fixture: %{
+        device: device,
+        org: org,
+        product: product,
+        deployment_group: deployment_group
+      }
+    } do
+      conn
+      |> visit("/org/#{org.name}/#{product.name}/devices")
+      |> assert_has("a", text: device.identifier, timeout: 1000)
+
+      conn
+      |> visit("/org/#{org.name}/#{product.name}/devices")
+      |> select("Update status", option: "Updating")
+      |> refute_has("a", text: device.identifier, timeout: 1000)
+
+      {:ok, _inflight_update} = Devices.told_to_update(device, deployment_group)
+
+      conn
+      |> visit("/org/#{org.name}/#{product.name}/devices")
+      |> select("Update status", option: "Updating")
+      |> assert_has("a", text: device.identifier, timeout: 1000)
+
+      {:ok, _device} = Devices.firmware_update_successful(device)
+
+      conn
+      |> visit("/org/#{org.name}/#{product.name}/devices")
+      |> select("Update status", option: "Updating")
+      |> refute_has("a", text: device.identifier, timeout: 1000)
+    end
   end
 
   describe "pagination" do