release history on deployment group creation

Author: kybishop

lib/nerves_hub/managed_deployments.ex

@@ -195,7 +195,7 @@ defmodule NervesHub.ManagedDeployments do
   Update a deployment
 
   - Records audit logs depending on changes
-  - Creates deployment release record if firmware_id changed (requires user_id in params)
+  - Creates deployment release record if firmware_id or archive_id changed
   """
   @spec update_deployment_group(DeploymentGroup.t(), map, User.t()) ::
           {:ok, DeploymentGroup.t()} | {:error, Changeset.t()}
@@ -348,11 +348,17 @@ defmodule NervesHub.ManagedDeployments do
     Ecto.Changeset.change(%DeploymentGroup{})
   end
 
-  @spec create_deployment_group(map(), Product.t()) ::
+  @spec create_deployment_group(map(), Product.t(), User.t()) ::
           {:ok, DeploymentGroup.t()} | {:error, Changeset.t()}
-  def create_deployment_group(params, %Product{} = product) do
-    DeploymentGroup.create_changeset(params, product)
-    |> Repo.insert()
+  def create_deployment_group(params, %Product{} = product, user) do
+    Repo.transact(fn ->
+      changeset = DeploymentGroup.create_changeset(params, product)
+
+      with {:ok, deployment_group} <- Repo.insert(changeset),
+           {:ok, _release} <- maybe_create_initial_deployment_release(deployment_group, user) do
+        {:ok, deployment_group}
+      end
+    end)
     |> case do
       {:ok, deployment_group} ->
         deployment_created_event(deployment_group)
@@ -364,6 +370,20 @@ defmodule NervesHub.ManagedDeployments do
     end
   end
 
+  # Create initial deployment release if firmware is set during creation
+  defp maybe_create_initial_deployment_release(%{firmware_id: nil}, _user), do: {:ok, nil}
+
+  defp maybe_create_initial_deployment_release(deployment_group, user) do
+    %DeploymentRelease{}
+    |> DeploymentRelease.changeset(%{
+      deployment_group_id: deployment_group.id,
+      firmware_id: deployment_group.firmware_id,
+      archive_id: deployment_group.archive_id,
+      created_by_id: user.id
+    })
+    |> Repo.insert()
+  end
+
   @doc """
   List all deployment releases for a deployment group, ordered by most recent first.
   """

lib/nerves_hub/managed_deployments/deployment_group.ex

@@ -38,7 +38,7 @@ defmodule NervesHub.ManagedDeployments.DeploymentGroup do
 
     has_many(:inflight_updates, InflightUpdate, foreign_key: :deployment_id)
     has_many(:devices, Device, foreign_key: :deployment_id, on_delete: :nilify_all)
-    has_many(:deployment_releases, DeploymentRelease)
+    has_many(:deployment_releases, DeploymentRelease, on_delete: :delete_all)
     has_many(:update_stats, UpdateStat, on_delete: :nilify_all, foreign_key: :deployment_id)
 
     embeds_one :conditions, __MODULE__.Conditions, primary_key: false, on_replace: :update do

lib/nerves_hub_web/controllers/api/deployment_group_controller.ex

@@ -29,7 +29,7 @@ defmodule NervesHubWeb.API.DeploymentGroupController do
       uuid ->
         with {:ok, firmware} <- Firmwares.get_firmware_by_product_and_uuid(product, uuid),
              params = Map.put(params, "firmware_id", firmware.id),
-             {:ok, deployment_group} <- ManagedDeployments.create_deployment_group(params, product) do
+             {:ok, deployment_group} <- ManagedDeployments.create_deployment_group(params, product, user) do
           DeploymentGroupTemplates.audit_deployment_created(user, deployment_group)
 
           conn

lib/nerves_hub_web/live/deployment_groups/new.ex

@@ -143,7 +143,7 @@ defmodule NervesHubWeb.Live.DeploymentGroups.New do
 
     %{user: user, org: org, product: product} = socket.assigns
 
-    ManagedDeployments.create_deployment_group(params, product)
+    ManagedDeployments.create_deployment_group(params, product, user)
     |> case do
       {:ok, deployment_group} ->
         _ = DeploymentGroupTemplates.audit_deployment_created(user, deployment_group)