Standardize loading a device for the device show page (#1861)

Resolves an error raised by Sentry

Author: joshk

lib/nerves_hub_web/channels/device_channel.ex

@@ -170,6 +170,16 @@ defmodule NervesHubWeb.DeviceChannel do
     {:noreply, socket}
   end
 
+  @decorate with_span("Channels.DeviceChannel.handle_info:clear-deployment")
+  def handle_info(
+        %Broadcast{event: "devices/clear-deployment"},
+        %{assigns: %{device: device}} = socket
+      ) do
+    device = %{device | deployment_id: nil, deployment: nil}
+
+    {:noreply, update_device(socket, device)}
+  end
+
   # Update local state and tell the various servers of the new information
   @decorate with_span("Channels.DeviceChannel.handle_info:devices-updated")
   def handle_info(%Broadcast{event: "devices/updated"}, %{assigns: %{device: device}} = socket) do

lib/nerves_hub_web/live/devices/show.ex

@@ -36,7 +36,7 @@ defmodule NervesHubWeb.Live.Devices.Show do
   def mount(%{"device_identifier" => device_identifier}, _session, socket) do
     %{org: org, product: product} = socket.assigns
 
-    device = Devices.get_device_by_identifier!(org, device_identifier, :latest_connection)
+    device = load_device(org, device_identifier)
 
     if connected?(socket) do
       socket.endpoint.subscribe("device:#{device.identifier}:internal")
@@ -69,10 +69,9 @@ defmodule NervesHubWeb.Live.Devices.Show do
   end
 
   def handle_info(:reload_device, socket) do
-    device =
-      socket.assigns.device
-      |> Repo.reload()
-      |> Repo.preload(:deployment)
+    %{org: org, device: device} = socket.assigns
+
+    device = load_device(org, device.identifier)
 
     socket
     |> assign(:device, device)
@@ -457,6 +456,10 @@ defmodule NervesHubWeb.Live.Devices.Show do
     |> noreply()
   end
 
+  defp load_device(org, identifier) do
+    Devices.get_device_by_identifier!(org, identifier, :latest_connection)
+  end
+
   defp scripts_with_output(product) do
     product
     |> Scripts.all_by_product()