Wire up the "view devices" and "view firmware" links

Author: joshk

lib/nerves_hub/devices/filtering.ex

@@ -6,6 +6,7 @@ defmodule NervesHub.Devices.Filtering do
   import Ecto.Query
 
   alias NervesHub.Devices.Alarms
+  alias NervesHub.Devices.Device
   alias NervesHub.Devices.DeviceMetric
   alias NervesHub.Types.Tag
 
@@ -62,6 +63,25 @@ defmodule NervesHub.Devices.Filtering do
     )
   end
 
+  def filter(query, _filters, :filter, "not_recently_seen") do
+    query
+    |> where([latest_connection: lc], lc.status == :disconnected)
+    |> where([latest_connection: lc], lc.disconnected_at < ago(24, "hour"))
+  end
+
+  def filter(query, _filters, :filter, "unstable_connections") do
+    unstable_connections =
+      Device
+      |> select([d], %{id: d.id, count: count()})
+      |> join(:left, [d], dc in assoc(d, :device_connections))
+      |> where([_, dc], dc.established_at > ago(24, "hour"))
+      |> group_by([d], d.id)
+
+    join(query, :inner, [d], uc in subquery(unstable_connections),
+      on: d.id == uc.id and uc.count > 5
+    )
+  end
+
   def filter(query, _filters, :firmware_version, value) do
     where(query, [d], d.firmware_metadata["version"] == ^value)
   end

lib/nerves_hub/firmwares.ex

@@ -116,15 +116,25 @@ defmodule NervesHub.Firmwares do
       |> group_by([d], fragment("? ->> 'uuid'", d.firmware_metadata))
 
     Firmware
-    |> join(:left, [f], d in subquery(subquery), on: d.firmware_uuid == f.uuid)
+    |> join(:left, [f], d in subquery(subquery),
+      as: :install_count,
+      on: d.firmware_uuid == f.uuid
+    )
     |> where([f], f.product_id == ^product.id)
+    |> filter_selection(opts[:filter])
     |> sort_firmware(sort_opts)
-    |> select_merge([_f, d], %{install_count: d.install_count})
+    |> select_merge([_f, install_count: ic], %{install_count: ic.install_count})
     |> Flop.run(flop)
   end
 
+  defp filter_selection(query, "active_firmware") do
+    where(query, [_f, install_count: ic], ic.install_count > 0)
+  end
+
+  defp filter_selection(query, _filter), do: query
+
   defp sort_firmware(query, {direction, :install_count}) do
-    order_by(query, [_f, d], {^direction, d.install_count})
+    order_by(query, [_f, install_count: ic], {^direction, ic.install_count})
   end
 
   defp sort_firmware(query, sort), do: order_by(query, ^sort)

lib/nerves_hub_web/live/devices/index.ex

@@ -30,6 +30,7 @@ defmodule NervesHubWeb.Live.Devices.Index do
   @default_filters %{
     connection: "",
     connection_type: "",
+    filter: "",
     firmware_version: "",
     platform: "",
     healthy: "",
@@ -51,6 +52,7 @@ defmodule NervesHubWeb.Live.Devices.Index do
   @filter_types %{
     connection: :string,
     connection_type: :string,
+    filter: :string,
     firmware_version: :string,
     platform: :string,
     healthy: :string,

lib/nerves_hub_web/live/firmware.ex

@@ -9,7 +9,7 @@ defmodule NervesHubWeb.Live.Firmware do
 
   embed_templates("firmware_templates/*")
 
-  @pagination_opts ["page_number", "page_size", "sort", "sort_direction"]
+  @pagination_opts ["page_number", "page_size", "sort", "sort_direction", "filter"]
 
   @impl Phoenix.LiveView
   def mount(_params, _session, socket) do
@@ -203,7 +203,8 @@ defmodule NervesHubWeb.Live.Firmware do
       page: pagination_opts["page_number"],
       page_size: pagination_opts["page_size"],
       sort: pagination_opts["sort"] || "inserted_at",
-      sort_direction: pagination_opts["sort_direction"]
+      sort_direction: pagination_opts["sort_direction"],
+      filter: pagination_opts["filter"]
     }
 
     {entries, pager_meta} = Firmwares.filter(product, opts)

lib/nerves_hub_web/live/product/insights.html.heex

@@ -82,7 +82,7 @@
       <div class="px-4 py-3 text-xs border-t border-zinc-700">
         <.link
           class="text-xs font-normal text-zinc-400 underline underline-offset-4 decoration-dotted hover:text-neutral-50"
-          href="https://github.com/nerves-hub/nerves_hub_link?tab=readme-ov-file#configure-health"
+          navigate={~p"/org/#{@org.name}/#{@product.name}/devices?filter=not_recently_seen"}
         >
           View Devices
         </.link>
@@ -117,7 +117,7 @@
       <div class="px-4 py-3 text-xs border-t border-zinc-700">
         <.link
           class="text-xs font-normal text-zinc-400 underline underline-offset-4 decoration-dotted hover:text-neutral-50"
-          href="https://github.com/nerves-hub/nerves_hub_link?tab=readme-ov-file#configure-health"
+          navigate={~p"/org/#{@org.name}/#{@product.name}/devices?filter=unstable_connections"}
         >
           View Devices
         </.link>
@@ -161,7 +161,7 @@
       <div class="px-4 py-3 text-xs border-t border-zinc-700">
         <.link
           class="text-xs font-normal text-zinc-400 underline underline-offset-4 decoration-dotted hover:text-neutral-50"
-          href="https://github.com/nerves-hub/nerves_hub_link?tab=readme-ov-file#configure-health"
+          navigate={~p"/org/#{@org.name}/#{@product.name}/firmware?filter=active_firmware"}
         >
           View Firmware
         </.link>