Switch all Product nested UIs to the updated design (#2374)

This PR removes the 'New UI' switch, making the new UI available, and
default, to all users.

This temporarily removes the Pinned devices UI on the Orgs list page, which will be added back in a separate PR as this one is already big enough.

Author: joshk

lib/nerves_hub_web.ex

@@ -85,7 +85,7 @@ defmodule NervesHubWeb do
 
   defp live_view_setup() do
     quote do
-      use NervesHubWeb.LiveView,
+      use Phoenix.LiveView,
         layout: {NervesHubWeb.LayoutView, :live},
         container: {:div, class: "h-screen"}
 
@@ -142,23 +142,15 @@ defmodule NervesHubWeb do
   defp tab_component_functions() do
     quote do
       defp setup_tab_components(socket, tabs \\ []) do
-        if socket.assigns[:new_ui] do
-          tabs
-          |> Enum.reduce(socket, fn component, socket -> component.connect(socket) end)
-          |> put_private(:tabs, tabs)
-        else
-          socket
-        end
+        tabs
+        |> Enum.reduce(socket, fn component, socket -> component.connect(socket) end)
+        |> put_private(:tabs, tabs)
       end
 
       defp update_tab_component_hooks(socket) do
-        if socket.assigns[:new_ui] do
-          socket
-          |> detach_hooks()
-          |> attach_hooks()
-        else
-          socket
-        end
+        socket
+        |> detach_hooks()
+        |> attach_hooks()
       end
 
       defp detach_hooks(socket) do

lib/nerves_hub_web/components/deployment_group_page/settings.ex

@@ -294,7 +294,7 @@ defmodule NervesHubWeb.Components.DeploymentGroupPage.Settings do
         # TODO: if we move away from slugs with deployment names we won't need
         # to use `push_navigate` here.
         socket
-        |> put_flash(:info, "Deployment group updated")
+        |> put_flash(:info, "Deployment Group updated")
         |> push_navigate(to: ~p"/org/#{org}/#{product}/deployment_groups/#{updated}")
         |> noreply()
 

lib/nerves_hub_web/components/device_page/details_tab.ex

@@ -300,7 +300,11 @@ defmodule NervesHubWeb.Components.DevicePage.DetailsTab do
             Deployment Groups
           </div>
 
-          <div class="flex flex-col pt-2 px-4 pb-6 gap-4">
+          <div :if={is_nil(@device.deployment_group) && Enum.empty?(@deployment_groups)} class="flex pt-2 px-4 pb-6 gap-4 items-center">
+            <span class="text-sm text-nerves-gray-500">No deployment groups match the devices platform and architecture.</span>
+          </div>
+
+          <div :if={@device.deployment_group} class="flex flex-col pt-2 px-4 pb-6 gap-4">
             <div class="text-sm font-medium leading-6 text-zinc-300">
               <form id="toggle-priority-updates">
                 <input type="hidden" name="device[priority_updates]" value="false" />
@@ -324,7 +328,7 @@ defmodule NervesHubWeb.Components.DevicePage.DetailsTab do
                 </div>
               </form>
             </div>
-            <div :if={@device.deployment_group} class="flex pt-2 gap-4 items-center">
+            <div class="flex pt-2 gap-4 items-center">
               <span class="text-sm text-nerves-gray-500">Assigned deployment group:</span>
               <.link
                 navigate={~p"/org/#{@org}/#{@product}/deployment_groups/#{@device.deployment_group}"}
@@ -354,6 +358,7 @@ defmodule NervesHubWeb.Components.DevicePage.DetailsTab do
               </button>
             </div>
           </div>
+
           <div :if={@device.status == :registered && @device.deployment_id} class="flex pt-2 px-4 pb-6 gap-4 items-center">
             <span class="text-sm text-nerves-gray-500">Please note: The device will be removed from the deployment group upon connection if the arch and platform don't match.</span>
           </div>
@@ -772,12 +777,8 @@ defmodule NervesHubWeb.Components.DevicePage.DetailsTab do
 
   def hooked_event(_event, _params, socket), do: {:cont, socket}
 
-  def hooked_info(%Broadcast{event: "health_check_report"}, %{assigns: %{device: device}} = socket) do
-    latest_metrics = Metrics.get_latest_metric_set(device.id)
-
-    socket
-    |> assign(:latest_metrics, latest_metrics)
-    |> assign_metadata()
+  def hooked_info(:platform_or_architecture_updated, %{assigns: %{device: device}} = socket) do
+    assign(socket, :firmwares, Firmwares.get_firmware_for_device(device))
     |> halt()
   end
 
@@ -790,6 +791,15 @@ defmodule NervesHubWeb.Components.DevicePage.DetailsTab do
     |> halt()
   end
 
+  def hooked_info(%Broadcast{event: "health_check_report"}, %{assigns: %{device: device}} = socket) do
+    latest_metrics = Metrics.get_latest_metric_set(device.id)
+
+    socket
+    |> assign(:latest_metrics, latest_metrics)
+    |> assign_metadata()
+    |> halt()
+  end
+
   def hooked_info(_event, socket), do: {:cont, socket}
 
   def hooked_async({:run_script, id}, result, socket) do

lib/nerves_hub_web/components/device_page/health_tab.ex

@@ -251,7 +251,7 @@ defmodule NervesHubWeb.Components.DevicePage.HealthTab do
 
       types(charts) != types(data) ->
         push_patch(socket,
-          to: ~p"/org/#{org}/#{product}/devices/#{device}/healthz"
+          to: ~p"/org/#{org}/#{product}/devices/#{device}/health"
         )
 
       true ->