Address a few small credo and dialyzer warnings (#1879)

Author: joshk

lib/nerves_hub/archives.ex

@@ -7,8 +7,8 @@ defmodule NervesHub.Archives do
 
   require Logger
 
-  alias NervesHub.Deployments.Deployment
   alias NervesHub.Archives.Archive
+  alias NervesHub.Deployments.Deployment
   alias NervesHub.Fwup
   alias NervesHub.Products.Product
   alias NervesHub.Repo

lib/nerves_hub/extensions/health.ex

@@ -1,8 +1,8 @@
 defmodule NervesHub.Extensions.Health do
   @behaviour NervesHub.Extensions
 
-  alias NervesHub.Devices.HealthStatus
   alias NervesHub.Devices
+  alias NervesHub.Devices.HealthStatus
   alias NervesHub.Devices.Metrics
   alias NervesHub.Helpers.Logging
 

lib/nerves_hub_web/components/device_health/health_status.ex

@@ -34,7 +34,7 @@ defmodule NervesHubWeb.Components.HealthStatus do
   defp format_health_status_reason(status, reasons) do
     key_strings =
       reasons
-      |> Enum.map(fn {key, reasons} ->
+      |> Enum.map_join(", ", fn {key, reasons} ->
         key_parts =
           key
           |> String.split("_")
@@ -50,7 +50,6 @@ defmodule NervesHubWeb.Components.HealthStatus do
 
         "#{Enum.join(key_parts, " ")}: #{reasons["value"]}#{delimiter} (threshold is #{reasons["threshold"]}#{delimiter})"
       end)
-      |> Enum.join(", ")
 
     if(!Enum.empty?(reasons)) do
       "#{String.capitalize(status)}:  #{key_strings}"

test/nerves_hub_web/channels/device_channel_test.exs

@@ -5,8 +5,8 @@ defmodule NervesHubWeb.DeviceChannelTest do
   import Ecto.Query
   import TrackerHelper
 
-  alias NervesHub.Devices
   alias NervesHub.AuditLogs.AuditLog
+  alias NervesHub.Devices
   alias NervesHub.Fixtures
   alias NervesHub.Repo
   alias NervesHubWeb.DeviceChannel