More OTel decorators for Device related tracing

Author: joshk

lib/nerves_hub/deployments/calculator.ex

@@ -1,5 +1,6 @@
 defmodule NervesHub.Deployments.Calculator do
   use GenServer
+  use OpenTelemetryDecorator
 
   import Ecto.Query
 
@@ -12,6 +13,7 @@ defmodule NervesHub.Deployments.Calculator do
   alias Phoenix.PubSub
   alias Phoenix.Socket.Broadcast
 
+  @decorate with_span("Deployments.Calculator.process_next_device")
   def process_next_device(deployment) do
     result =
       Repo.transaction(fn ->
@@ -83,6 +85,7 @@ defmodule NervesHub.Deployments.Calculator do
     {:ok, deployment, {:continue, :boot}}
   end
 
+  @decorate with_span("Deployments.Calculator.boot")
   def handle_continue(:boot, deployment) do
     send(self(), :process_next_device)
 
@@ -98,6 +101,7 @@ defmodule NervesHub.Deployments.Calculator do
     {:noreply, state}
   end
 
+  @decorate with_span("Deployments.Calculator.handle_info:process_next_device")
   def handle_info(:process_next_device, state) do
     Logger.debug("[InflightDeploymentCheck] checking next device")
 
@@ -114,6 +118,7 @@ defmodule NervesHub.Deployments.Calculator do
     end
   end
 
+  @decorate with_span("Deployments.Calculator.handle_info:deployments/update")
   def handle_info(%Broadcast{event: "deployments/update"}, state) do
     deployment =
       state.deployment

lib/nerves_hub/deployments/orchestrator.ex

@@ -108,6 +108,7 @@ defmodule NervesHub.Deployments.Orchestrator do
     {:ok, deployment, {:continue, :boot}}
   end
 
+  @decorate with_span("Deployments.Orchestrator.boot")
   def handle_continue(:boot, deployment) do
     _ = PubSub.subscribe(NervesHub.PubSub, "deployment:#{deployment.id}")
 
@@ -127,6 +128,7 @@ defmodule NervesHub.Deployments.Orchestrator do
     {:noreply, deployment}
   end
 
+  @decorate with_span("Deployments.Orchestrator.handle_info:deployments/update")
   def handle_info(%Broadcast{event: "deployments/update"}, deployment) do
     deployment =
       deployment

lib/nerves_hub_web/channels/device_channel.ex

@@ -107,6 +107,7 @@ defmodule NervesHubWeb.DeviceChannel do
 
   # We can save a fairly expensive query by checking the incoming deployment's payload
   # If it matches, we can set the deployment directly and only do 3 queries (update, two preloads)
+  @decorate with_span("Channels.DeviceChannel.handle_info:deployments/changed,deployment:none")
   def handle_info(
         %Broadcast{event: "deployments/changed", topic: "deployment:none", payload: payload},
         %{assigns: %{device: device}} = socket
@@ -130,6 +131,7 @@ defmodule NervesHubWeb.DeviceChannel do
     {:noreply, assign_deployment(socket, payload)}
   end
 
+  @decorate with_span("Channels.DeviceChannel.handle_info:deployments/changed")
   def handle_info(
         %Broadcast{event: "deployments/changed", payload: payload},
         %{assigns: %{device: device}} = socket
@@ -147,6 +149,7 @@ defmodule NervesHubWeb.DeviceChannel do
     end
   end
 
+  @decorate with_span("Channels.DeviceChannel.handle_info:resolve_changed_deployment")
   def handle_info(:resolve_changed_deployment, %{assigns: %{device: device}} = socket) do
     :telemetry.execute([:nerves_hub, :devices, :deployment, :changed], %{count: 1})
 
@@ -180,6 +183,7 @@ defmodule NervesHubWeb.DeviceChannel do
     {:noreply, socket}
   end
 
+  @decorate with_span("Channels.DeviceChannel.handle_info:deployments/update")
   def handle_info({"deployments/update", inflight_update}, %{assigns: %{device: device}} = socket) do
     device = deployment_preload(device)
 
@@ -365,6 +369,7 @@ defmodule NervesHubWeb.DeviceChannel do
     end
   end
 
+  @decorate with_span("Channels.DeviceChannel.handle_in:location:update")
   def handle_in("location:update", location, %{assigns: %{device: device}} = socket) do
     metadata = Map.put(device.connection_metadata, "location", location)
 
@@ -413,6 +418,7 @@ defmodule NervesHubWeb.DeviceChannel do
     {:noreply, socket}
   end
 
+  @decorate with_span("Channels.DeviceChannel.handle_in:health_check_report")
   def handle_in("health_check_report", %{"value" => device_status}, socket) do
     device_meta =
       for {key, val} <- Map.from_struct(socket.assigns.device.firmware_metadata),