Skip to content

Commit ef82a9a

Browse files
authored
Update opentelemetry_bandit to address instrumentation errors (#2286)
I noticed in some recent deployment logs we were getting this new error: > Handler {OpentelemetryBandit, :otel_bandit} has failed and has been detached. Class=:error\nReason={:badkey, :transport_info,\n %Bandit.HTTP2.Stream{\n connection_pid: #PID<0.8864.0>,\n stream_id: 1,\n state: :remote_closed,\n recv_window_size: 65535,\n send_window_size: 33554432,\n bytes_remaining: nil,\n read_timeout: 15000\n }}\nStacktrace=[\n {OpentelemetryBandit, :extract_client_info_from_transport, 1,\n [file: ~c\"lib/opentelemetry_bandit.ex\", line: 430]},\n {OpentelemetryBandit, :handle_request_start, 2,\n [file: ~c\"lib/opentelemetry_bandit.ex\", line: 211]},\n {:telemetry, :\"-execute/3-fun-0-\", 4,\n [file: ~c\"/build/deps/telemetry/src/telemetry.erl\", line: 167]},\n {:lists, :foreach_1, 2, [file: ~c\"lists.erl\", line: 2310]},\n {Bandit.Telemetry, :start_span, 3,\n [file: ~c\"lib/bandit/telemetry.ex\", line: 174]},\n {Bandit.Pipeline, :run, 5, [file: ~c\"lib/bandit/pipeline.ex\", line: 38]},\n {Bandit.HTTP2.StreamProcess, :handle_continue, 2,\n [file: ~c\"lib/bandit/http2/stream_process.ex\", line: 28]},\n {:gen_server, :try_handle_continue, 3, [file: ~c\"gen_server.erl\", line: 2335]}\n]\n This is because of a Bandit change, that has been addressed in `opentelemetry_bandit`, but a new version hasn't been released yet. This PR switches us to git so we can use the fix.
1 parent 649a0e4 commit ef82a9a

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

mix.exs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,9 @@ defmodule NervesHub.MixProject do
122122
git: "https://github.com/joshk/opentelemetry-erlang-contrib",
123123
branch: "update-obans-semantic-conventions",
124124
subdir: "instrumentation/opentelemetry_oban"},
125-
{:opentelemetry_bandit, "~> 0.2.0-rc.1"},
125+
{:opentelemetry_bandit, "~> 0.2.0",
126+
git: "https://github.com/open-telemetry/opentelemetry-erlang-contrib",
127+
subdir: "instrumentation/opentelemetry_bandit"},
126128
{:open_telemetry_decorator, "~> 1.5"},
127129
{:phoenix, "~> 1.7.0"},
128130
{:phoenix_ecto, "~> 4.0"},

mix.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
"open_telemetry_decorator": {:hex, :open_telemetry_decorator, "1.5.10", "dc762507bb597835d58154d4f78c19acf75d1a38c807be11874c37ad868c2065", [:mix], [{:decorator, "~> 1.4", [hex: :decorator, repo: "hexpm", optional: false]}, {:o11y, "~> 0.2", [hex: :o11y, repo: "hexpm", optional: false]}, {:opentelemetry_api, "~> 1.4", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}], "hexpm", "50743b251fbe718dcc66125ade6e601f7c418e2fffc6c3996e32395ade696fe1"},
8585
"opentelemetry": {:hex, :opentelemetry, "1.5.1", "f2a6b1ecd7cf252aa968beceb2c51cad03965c0984764af263f73b49203269ea", [:rebar3], [{:opentelemetry_api, "~> 1.4.0", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}], "hexpm", "27c6775b2b609bb28bd9c1c0cb2dee907bfed2e31fcf0afd9b8e3fad27ef1382"},
8686
"opentelemetry_api": {:hex, :opentelemetry_api, "1.4.1", "e071429a37441a0fe9097eeea0ff921ebadce8eba8e1ce297b05a43c7a0d121f", [:mix, :rebar3], [], "hexpm", "39bdb6ad740bc13b16215cb9f233d66796bbae897f3bf6eb77abb712e87c3c26"},
87-
"opentelemetry_bandit": {:hex, :opentelemetry_bandit, "0.2.0", "60ee4789994d4532ec1b4c05cb8fad333c60ba2c248eb908918369fde045bbda", [:mix], [{:nimble_options, "~> 1.1", [hex: :nimble_options, repo: "hexpm", optional: false]}, {:opentelemetry_api, "~> 1.3", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}, {:opentelemetry_semantic_conventions, "~> 1.27", [hex: :opentelemetry_semantic_conventions, repo: "hexpm", optional: false]}, {:otel_http, "~> 0.2", [hex: :otel_http, repo: "hexpm", optional: false]}, {:plug, ">= 1.15.0", [hex: :plug, repo: "hexpm", optional: false]}, {:telemetry, "~> 1.2", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "57e31355a860250c9203ae34f0bf0290a14b72ab02b154535e1b2512a0767bca"},
87+
"opentelemetry_bandit": {:git, "https://github.com/open-telemetry/opentelemetry-erlang-contrib", "72f71c59660fc614bd083e739d2aabe1485fc48b", [subdir: "instrumentation/opentelemetry_bandit"]},
8888
"opentelemetry_ecto": {:hex, :opentelemetry_ecto, "1.2.0", "2382cb47ddc231f953d3b8263ed029d87fbf217915a1da82f49159d122b64865", [:mix], [{:opentelemetry_api, "~> 1.0", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}, {:opentelemetry_process_propagator, "~> 0.2", [hex: :opentelemetry_process_propagator, repo: "hexpm", optional: false]}, {:telemetry, "~> 0.4 or ~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "70dfa2e79932e86f209df00e36c980b17a32f82d175f0068bf7ef9a96cf080cf"},
8989
"opentelemetry_exporter": {:hex, :opentelemetry_exporter, "1.8.1", "b88188fe1390ce30fd45d6a9d77018262875759aac3b387d82ea12a59078f006", [:rebar3], [{:grpcbox, ">= 0.0.0", [hex: :grpcbox, repo: "hexpm", optional: false]}, {:opentelemetry, "~> 1.5.0", [hex: :opentelemetry, repo: "hexpm", optional: false]}, {:opentelemetry_api, "~> 1.4.0", [hex: :opentelemetry_api, repo: "hexpm", optional: false]}, {:tls_certificate_check, "~> 1.18", [hex: :tls_certificate_check, repo: "hexpm", optional: false]}], "hexpm", "0a64b2889aa87f38f0b3afcebe1f0a50c52b7e956fe6e535668741561c753e97"},
9090
"opentelemetry_oban": {:git, "https://github.com/joshk/opentelemetry-erlang-contrib", "2ada0a1a7043706683701dfa1bda7560699be25b", [branch: "update-obans-semantic-conventions", subdir: "instrumentation/opentelemetry_oban"]},

0 commit comments

Comments
 (0)