optimize pagination logic and use ~p sigil in tests

Author: Taras Tyshko

.gitignore

@@ -20,7 +20,4 @@ test/fixtures/ssl/device-root-ca.srl
 .lexical
 .elixir-tools
 
-.DS_Store
-.idea/
-/cover/
-nerves_hub.iml
+.DS_Store

lib/nerves_hub_web/live/devices/show.ex

@@ -53,8 +53,6 @@ defmodule NervesHubWeb.Live.Devices.Show do
       socket.endpoint.subscribe("firmware")
     end
 
-    default_page_size = if socket.assigns[:new_ui], do: 25, else: 5
-
     socket
     |> page_title("Device #{device.identifier} - #{product.name}")
     |> sidebar_tab(:devices)
@@ -65,10 +63,7 @@ defmodule NervesHubWeb.Live.Devices.Show do
     |> assign_metadata()
     |> schedule_health_check_timer()
     |> assign(:fwup_progress, nil)
-    |> assign(:page_number, 1)
-    |> assign(:page_size, default_page_size)
     |> assign(:pinned?, Devices.device_pinned?(user.id, device.id))
-    |> audit_log_assigns()
     |> assign_deployment_groups()
     |> setup_presence_tracking()
     |> setup_tab_components(@tab_components)
@@ -83,7 +78,6 @@ defmodule NervesHubWeb.Live.Devices.Show do
     socket
     |> assign(:page_number, page_number)
     |> assign(:page_size, page_size)
-    # Reload audit logs with new pagination
     |> audit_log_assigns()
     |> update_tab_component_hooks()
     |> noreply()
@@ -495,7 +489,9 @@ defmodule NervesHubWeb.Live.Devices.Show do
     %{org: org, product: product, device: device} = socket.assigns
     url = ~p"/org/#{org}/#{product}/devices/#{device}?#{params}"
 
-    socket |> push_patch(to: url) |> noreply()
+    socket
+    |> push_patch(to: url)
+    |> noreply()
   end
 
   def handle_event("select-firmware-version", _, socket) do

test/nerves_hub_web/live/devices/show_test.exs

@@ -701,24 +701,20 @@ defmodule NervesHubWeb.Live.Devices.ShowTest do
 
       # Test page 1 with default page_size=5
       conn
-      |> visit("/org/#{org.name}/#{product.name}/devices/#{device.identifier}")
+      |> visit(~p"/org/#{org}/#{product}/devices/#{device}")
       |> assert_has("div.audit-log-item", count: 5)
       |> assert_has("button[phx-value-page=\"2\"]")
 
       # Test page 2 with page_size=5
       conn
-      |> visit(
-        "/org/#{org.name}/#{product.name}/devices/#{device.identifier}?page_number=2&page_size=5"
-      )
+      |> visit(~p"/org/#{org}/#{product}/devices/#{device}?page_number=2&page_size=5")
       # Still showing 5 per page
       |> assert_has("div.audit-log-item", count: 5)
       |> assert_has("button[phx-value-page=\"1\"]")
 
       # Test custom page_size=10
       conn
-      |> visit(
-        "/org/#{org.name}/#{product.name}/devices/#{device.identifier}?page_number=1&page_size=10"
-      )
+      |> visit(~p"/org/#{org}/#{product}/devices/#{device}?page_number=1&page_size=10")
       |> assert_has("div.audit-log-item", count: 10)
     end
 
@@ -734,19 +730,15 @@ defmodule NervesHubWeb.Live.Devices.ShowTest do
         NervesHub.AuditLogs.audit!(user, device, "Pagination test entry #{i}")
       end)
 
-      {:ok, view, _html} =
-        live(conn, "/org/#{org.name}/#{product.name}/devices/#{device.identifier}")
+      {:ok, view, _html} = live(conn, ~p"/org/#{org}/#{product}/devices/#{device}")
 
       # Test paginate event
       view
       |> element("button[phx-click=\"paginate\"][phx-value-page=\"2\"]", "2")
       |> render_click()
 
       # Should redirect to page 2 on same device page
-      assert_patch(
-        view,
-        "/org/#{org.name}/#{product.name}/devices/#{device.identifier}?page_number=2&page_size=5"
-      )
+      assert_patch(view, ~p"/org/#{org}/#{product}/devices/#{device}?page_number=2&page_size=5")
     end
   end