Avoids overwritting connection details on shutdown

Author: paulanthonywilson

lib/vintage_net_wizard/backend_server.ex

@@ -278,6 +278,17 @@ defmodule VintageNetWizard.BackendServer do
     {:reply, state, state}
   end
 
+  def handle_call(
+        :complete,
+        _from,
+        %State{backend_state: %{data: %{configuration_status: :good}}} = state
+      ) do
+    # As the configuration status is good, we are already completed setup and the configurations
+    # have been blanked in `handle_info/3` - calling complete on the backend will disconnect us and
+    # write over the saved configuration. Do nothing.
+    {:reply, :ok, state}
+  end
+
   def handle_call(
         :complete,
         _from,

test/vintage_net_wizard/backend_server_test.exs

@@ -2,6 +2,7 @@ defmodule VintageNetWizard.BackendServer.Test do
   use ExUnit.Case, async: true
 
   alias VintageNetWizard.BackendServer
+  alias VintageNetWizard.BackendServer.State
 
   test "Can save a WiFi configuration" do
     :ok = BackendServer.reset()
@@ -59,4 +60,31 @@ defmodule VintageNetWizard.BackendServer.Test do
     :ok = BackendServer.reset()
     assert :ok = BackendServer.complete()
   end
+
+  describe "on completion" do
+    defmodule FakeBackend do
+      def complete(wifi_configurations, backend_state) do
+        send(self(), {:complete_called, wifi_configurations, backend_state})
+        {:ok, backend_state}
+      end
+    end
+
+    test "if the configuration status is not `:good`, calls complete on the backend" do
+      BackendServer.handle_call(:complete, :ignored, %State{
+        backend: FakeBackend,
+        backend_state: %{data: %{configuration_status: :not_configured}}
+      })
+
+      assert_received {:complete_called, [], _backend_state}
+    end
+
+    test "if the configuration status is `:good` then does not call complete on the backend" do
+      BackendServer.handle_call(:complete, :ignored, %State{
+        backend: FakeBackend,
+        backend_state: %{data: %{configuration_status: :good}}
+      })
+
+      refute_received {:complete_called, _, _}
+    end
+  end
 end