Add Frozen String Literal Magic Comment to tests

tagliala · tagliala · commit a69246a2d9b0 · 2025-12-28T19:13:20.000+01:00
Changes have been applied exclusively to non-production code. The CI workflow now runs tests with Ruby’s frozen string literal and debug options enabled. The updates were performed automatically using: ``` rubocop --only Style/FrozenStringLiteralComment,Layout/EmptyLineAfterMagicComment,Style/RedundantFreeze -Am test/**/*.rb ``` An additional modification was made to `RiotTestHelpers.char_split`, where the string is now duplicated before calling `String#force_encoding` to prevent errors related to modifying frozen strings. Ref: #780
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -40,4 +40,4 @@ jobs:
         ruby-version: ${{ matrix.ruby-version }}
         bundler-cache: true
     - name: Run tests
-      run: bundle exec rake
+      run: RUBYOPT='--enable=frozen-string-literal --debug=frozen-string-literal' bundle exec rake
diff --git a/test/bson_engine_test.rb b/test/bson_engine_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path('../teststrap', __FILE__)
 require 'rabl/template'
 
diff --git a/test/builder_test.rb b/test/builder_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path('../teststrap',   __FILE__)
 
 context "Rabl::Builder" do
diff --git a/test/configuration_test.rb b/test/configuration_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path('../teststrap', __FILE__)
 
 context 'Rabl::Configuration' do
diff --git a/test/engine_test.rb b/test/engine_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require File.expand_path('../teststrap', __FILE__)
 require 'rabl/template'
diff --git a/test/helpers_test.rb b/test/helpers_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tmpdir'
 require 'pathname'
 require File.expand_path('../teststrap', __FILE__)
diff --git a/test/integration/posts_controller_test.rb b/test/integration/posts_controller_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Lives in <rabl>/test/integration/posts_controller_test.rb
 # Symlinked to fixture applications
 
diff --git a/test/integration/rails3_2/posts_controller_test.rb b/test/integration/rails3_2/posts_controller_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Lives in <rabl>/test/integration/posts_controller_test.rb
 # Symlinked to fixture applications
 
diff --git a/test/integration/rails3_2/users_controller_test.rb b/test/integration/rails3_2/users_controller_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Lives in <rabl>/test/integration/users_controller_test.rb
 # Symlinked to fixture applications
 
diff --git a/test/integration/rails4/posts_controller_test.rb b/test/integration/rails4/posts_controller_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Lives in <rabl>/test/integration/posts_controller_test.rb
 # Symlinked to fixture applications
 
diff --git a/test/integration/rails4/users_controller_test.rb b/test/integration/rails4/users_controller_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Lives in <rabl>/test/integration/users_controller_test.rb
 # Symlinked to fixture applications
 
diff --git a/test/integration/rails5/posts_controller_test.rb b/test/integration/rails5/posts_controller_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Lives in <rabl>/test/integration/posts_controller_test.rb
 # Symlinked to fixture applications
 
diff --git a/test/integration/rails5/users_controller_test.rb b/test/integration/rails5/users_controller_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Lives in <rabl>/test/integration/users_controller_test.rb
 # Symlinked to fixture applications
 
diff --git a/test/integration/rails6/posts_controller_test.rb b/test/integration/rails6/posts_controller_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Lives in <rabl>/test/integration/posts_controller_test.rb
 # Symlinked to fixture applications
 
diff --git a/test/integration/rails6/users_controller_test.rb b/test/integration/rails6/users_controller_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Lives in <rabl>/test/integration/users_controller_test.rb
 # Symlinked to fixture applications
 
diff --git a/test/integration/test_init.rb b/test/integration/test_init.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rack/test'
 require 'riot'
 require 'riot/rr'
diff --git a/test/integration/users_controller_test.rb b/test/integration/users_controller_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Lives in <rabl>/test/integration/users_controller_test.rb
 # Symlinked to fixture applications
 
diff --git a/test/models/ormless.rb b/test/models/ormless.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Ormless
   # Nothing here
 end
diff --git a/test/models/user.rb b/test/models/user.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 unless defined?(User)
   class User
     attr_accessor :age, :city, :name, :first, :float, :hobbies, :twitter, :first_pets_name
diff --git a/test/msgpack_engine_test.rb b/test/msgpack_engine_test.rb
@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # encoding: iso-8859-1
 
 require File.expand_path('../teststrap', __FILE__)
diff --git a/test/multi_builder_test.rb b/test/multi_builder_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require File.expand_path('../teststrap', __FILE__)
 require 'rabl/template'
diff --git a/test/partials_test.rb b/test/partials_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tmpdir'
 require 'pathname'
 require File.expand_path('../teststrap', __FILE__)
diff --git a/test/plist_engine_test.rb b/test/plist_engine_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path('../teststrap', __FILE__)
 require 'rabl/template'
 
diff --git a/test/renderer_test.rb b/test/renderer_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'tmpdir'
 require 'pathname'
 require 'json'
diff --git a/test/silence.rb b/test/silence.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Kernel
   def silence_warnings
     with_warnings(nil) { yield }
diff --git a/test/template_test.rb b/test/template_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path('../teststrap',__FILE__)
 require 'rabl/template'
 
diff --git a/test/teststrap.rb b/test/teststrap.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 $LOAD_PATH.unshift(File.expand_path("../../lib", __FILE__))
 
 module Kernel
@@ -31,7 +33,7 @@ def with_warnings(flag)
 
 module RiotTestHelpers
   def char_split(str)
-    str.force_encoding("iso-8859-1").split("").sort
+    str.dup.force_encoding("iso-8859-1").split("").sort
   end
 
   def clean_plist(text)
diff --git a/test/xml_test.rb b/test/xml_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/core_ext/hash/conversions'
 require 'active_support/time'
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require File.expand_path('../teststrap', __FILE__)`
`2`	`4`	`require 'rabl/template'`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'json'`
`2`	`4`	`require File.expand_path('../teststrap', __FILE__)`
`3`	`5`	`require 'rabl/template'`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`require 'tmpdir'`
`2`	`4`	`require 'pathname'`
`3`	`5`	`require File.expand_path('../teststrap', __FILE__)`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`# Lives in <rabl>/test/integration/posts_controller_test.rb`
`2`	`4`	`# Symlinked to fixture applications`
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+# frozen_string_literal: true`
	`2`	`+`
`1`	`3`	`# Lives in <rabl>/test/integration/users_controller_test.rb`
`2`	`4`	`# Symlinked to fixture applications`
`3`	`5`