Merge pull request #2213 from bilby91/circular-dependency-scope-clarification

kamilmysliwiec · web-flow · commit 8a1d75ecd7e6 · 2022-02-14T10:54:23.000+01:00
Clarify circular dependency usage with Scope.REQUEST
diff --git a/content/fundamentals/circular-dependency.md b/content/fundamentals/circular-dependency.md
@@ -54,7 +54,7 @@ export class CommonService {
 }
 ```
 
-> warning **Warning** The order of instantiation is indeterminate. Make sure your code does not depend on which constructor is called first.
+> warning **Warning** The order of instantiation is indeterminate. Make sure your code does not depend on which constructor is called first. Having circular dependencies depend on providers with `Scope.REQUEST` can lead to undefined dependencies. More information available [here](https://github.com/nestjs/nest/issues/5778)
 
 #### ModuleRef class alternative
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ export class CommonService {`
`54`	`54`	`}`
`55`	`55`	```
`56`	`56`
`57`		`-> warning Warning The order of instantiation is indeterminate. Make sure your code does not depend on which constructor is called first.`
	`57`	+> warning Warning The order of instantiation is indeterminate. Make sure your code does not depend on which constructor is called first. Having circular dependencies depend on providers with `Scope.REQUEST` can lead to undefined dependencies. More information available [here](https://github.com/nestjs/nest/issues/5778)
`58`	`58`
`59`	`59`	`#### ModuleRef class alternative`
`60`	`60`