Skip to content

Commit 6408c1f

Browse files
committed
refactor: rename mergeWithSchema to generateSchema
This better matches the method signature.
1 parent e30f085 commit 6408c1f

File tree

5 files changed

+11
-8
lines changed

5 files changed

+11
-8
lines changed

packages/apollo/lib/drivers/apollo-federation.driver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class ApolloFederationDriver extends ApolloBaseDriver {
2020
}
2121

2222
async generateSchema(options: ApolloDriverConfig): Promise<GraphQLSchema> {
23-
return await this.graphqlFederationFactory.mergeWithSchema(options);
23+
return await this.graphqlFederationFactory.generateSchema(options);
2424
}
2525

2626
public async start(options: ApolloDriverConfig): Promise<void> {

packages/graphql/lib/drivers/abstract-graphql.driver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ export abstract class AbstractGraphQLDriver<
3838
}
3939

4040
public async generateSchema(options: TOptions): Promise<GraphQLSchema> {
41-
return await this.graphQlFactory.mergeWithSchema(options);
41+
return await this.graphQlFactory.generateSchema(options);
4242
}
4343

4444
public subscriptionWithFilter(

packages/graphql/lib/federation/graphql-federation.factory.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export class GraphQLFederationFactory {
4848
private readonly typeDefsDecoratorFactory: TypeDefsDecoratorFactory,
4949
) {}
5050

51-
async mergeWithSchema<T extends GqlModuleOptions>(
51+
async generateSchema<T extends GqlModuleOptions>(
5252
options: T = {} as T,
5353
buildFederatedSchema?: (
5454
options: BuildFederatedSchemaOptions,
@@ -59,7 +59,10 @@ export class GraphQLFederationFactory {
5959

6060
let schema: GraphQLSchema;
6161
if (options.autoSchemaFile) {
62-
schema = await this.generateSchema(options, buildFederatedSchema);
62+
schema = await this.generateSchemaFromCodeFirst(
63+
options,
64+
buildFederatedSchema,
65+
);
6366
} else if (isEmpty(options.typeDefs)) {
6467
schema = options.schema;
6568
} else {
@@ -85,7 +88,7 @@ export class GraphQLFederationFactory {
8588
]);
8689
}
8790

88-
private async generateSchema<T extends GqlModuleOptions>(
91+
private async generateSchemaFromCodeFirst<T extends GqlModuleOptions>(
8992
options: T,
9093
buildFederatedSchema?: (
9194
options: BuildFederatedSchemaOptions,

packages/graphql/lib/graphql.factory.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export class GraphQLFactory {
2929
private readonly gqlSchemaBuilder: GraphQLSchemaBuilder,
3030
) {}
3131

32-
async mergeWithSchema<T extends GqlModuleOptions>(
32+
async generateSchema<T extends GqlModuleOptions>(
3333
options: T = { typeDefs: [] } as T,
3434
): Promise<GraphQLSchema> {
3535
const resolvers = this.resolversExplorerService.explore();
@@ -100,7 +100,7 @@ export class GraphQLFactory {
100100
return schema;
101101
}
102102

103-
overrideOrExtendResolvers(
103+
private overrideOrExtendResolvers(
104104
executableSchemaConfig: GraphQLSchemaConfig,
105105
autoGeneratedSchemaConfig: GraphQLSchemaConfig,
106106
): GraphQLSchemaConfig {

packages/mercurius/lib/drivers/mercurius-federation.driver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export class MercuriusFederationDriver extends AbstractGraphQLDriver<MercuriusDr
3131
public override async generateSchema(
3232
options: MercuriusDriverConfig,
3333
): Promise<GraphQLSchema> {
34-
return await this.graphqlFederationFactory.mergeWithSchema(
34+
return await this.graphqlFederationFactory.generateSchema(
3535
options,
3636
buildMercuriusFederatedSchema,
3737
);

0 commit comments

Comments
 (0)