fix: various preformace imporvements

1) getObjectOrInterfaceTypeNameIfExists - This function was not fixed on the move to map based metadata storage. Now instead of looking inside an entire metadata array, it fetches the item from the map

2) MetadataCollectionModel - I noticed that the interfaces list recieves duplicate instances of the same interface, so I switched the implementation to a map to remvoe duplicates.

3) LazyMetadataStorageHost.load - In very large applications (ie several millions of metadata object) we encountered an invalid arugments size thrown from V8, this is because the spread operator behind the scenes translates the values to multiple arguments. Switching to flat() solves this issue.

4) GraphQLSchemaFactory.create & LazyMetadataStorageHost.updateStorage - We noticed that the entire GQL metadata model was being rebuilt several times during the bootstrap of the application, I assume this was done because of the need to clear and rebuild the arrays every time. Now when we use maps we can't get duplicates in the metadata store, so I verify that the updateStorage callback is called only once, and I removed the clear call from the GraphQLSchemaFactory.create(). This results in a tremendous memory consumption boost! (in our case, from 8GB to 700MB)

Author: roypeled

packages/graphql/lib/decorators/resolver.decorator.ts

@@ -20,10 +20,8 @@ function getObjectOrInterfaceTypeNameIfExists(
   nameOrType: Function,
 ): string | undefined {
   const ctor = getClassOrUndefined(nameOrType);
-  const objectTypesMetadata = TypeMetadataStorage.getObjectTypesMetadata();
-  const objectMetadata = objectTypesMetadata.find(
-    (type) => type.target === ctor,
-  );
+  const objectMetadata =
+    TypeMetadataStorage.getObjectTypeMetadataByTarget(ctor);
   if (!objectMetadata) {
     const interfaceTypesMetadata = TypeMetadataStorage.getInterfacesMetadata();
     const interfaceMetadata = interfaceTypesMetadata.find(

packages/graphql/lib/schema-builder/collections/metada-collection-model.interface.ts

@@ -10,7 +10,7 @@ import { ObjectTypeMetadata } from '../metadata/object-type.metadata';
 
 export interface MetadataCollectionModel {
   argumentType: ClassMetadata[];
-  interface: ClassMetadata[];
+  interface: Map<Function, ClassMetadata>;
   inputType: ClassMetadata[];
   objectType: ObjectTypeMetadata[];
   resolver: ResolverClassMetadata[];

packages/graphql/lib/schema-builder/collections/metadata-by-target.collection.ts

@@ -1,10 +1,11 @@
 import { MetadataCollectionModel } from './metada-collection-model.interface';
 import { TargetMetadataCollection } from './target-metadata.collection';
+import { ClassMetadata } from '../metadata';
 
 export class MetadataByTargetCollection {
   public readonly all: MetadataCollectionModel = {
     argumentType: [],
-    interface: [],
+    interface: new Map<Function, ClassMetadata>(),
     inputType: [],
     objectType: [],
     resolver: [],

packages/graphql/lib/schema-builder/collections/target-metadata.collection.ts

@@ -48,7 +48,7 @@ export class TargetMetadataCollection {
 
   set interface(val: ClassMetadata) {
     this._interface = val;
-    this.all.interface.push(val);
+    this.all.interface.set(val.target, val);
   }
 
   get interface() {

packages/graphql/lib/schema-builder/graphql-schema.factory.ts

@@ -60,7 +60,6 @@ export class GraphQLSchemaFactory {
       options = scalarsOrOptions;
     }
 
-    TypeMetadataStorage.clear();
     LazyMetadataStorage.load(resolvers);
     TypeMetadataStorage.compile(options.orphanedTypes);
 

packages/graphql/lib/schema-builder/storages/lazy-metadata.storage.ts

@@ -48,14 +48,16 @@ export class LazyMetadataStorageHost {
         .filter((metadata) => metadata),
     );
 
-    loadersToExecute = loadersToExecute.concat(
-      ...(this.lazyMetadataByTarget.get(NO_TARGET_METADATA) || []),
-    );
+    loadersToExecute = [
+      loadersToExecute,
+      this.lazyMetadataByTarget.get(NO_TARGET_METADATA) || [],
+    ].flat();
 
     if (!options.skipFieldLazyMetadata) {
-      loadersToExecute = loadersToExecute.concat(
-        ...(this.lazyMetadataByTarget.get(FIELD_LAZY_METADATA) || []),
-      );
+      loadersToExecute = [
+        loadersToExecute,
+        this.lazyMetadataByTarget.get(FIELD_LAZY_METADATA) || [],
+      ].flat();
     }
     loadersToExecute.forEach((func) => func());
   }
@@ -83,10 +85,16 @@ export class LazyMetadataStorageHost {
 
   private updateStorage(key: symbol | Type<unknown>, func: Function) {
     const existingArray = this.lazyMetadataByTarget.get(key);
+    let called = false;
+    const singleCallFunctionWrapper = () => {
+      if (called) return;
+      func();
+      called = true;
+    };
     if (existingArray) {
-      existingArray.push(func);
+      existingArray.push(singleCallFunctionWrapper);
     } else {
-      this.lazyMetadataByTarget.set(key, [func]);
+      this.lazyMetadataByTarget.set(key, [singleCallFunctionWrapper]);
     }
   }
 }

packages/graphql/lib/schema-builder/storages/type-metadata.storage.ts

@@ -82,7 +82,7 @@ export class TypeMetadataStorageHost {
   }
 
   getInterfacesMetadata(): InterfaceMetadata[] {
-    return this.metadataByTargetCollection.all.interface;
+    return [...this.metadataByTargetCollection.all.interface.values()];
   }
 
   getInterfaceMetadataByTarget(
@@ -195,7 +195,7 @@ export class TypeMetadataStorageHost {
       ...this.metadataByTargetCollection.all.objectType,
       ...this.metadataByTargetCollection.all.inputType,
       ...this.metadataByTargetCollection.all.argumentType,
-      ...this.metadataByTargetCollection.all.interface,
+      ...this.metadataByTargetCollection.all.interface.values(),
     ];
     this.loadClassPluginMetadata(classMetadata);
     this.compileClassMetadata(classMetadata);

packages/graphql/lib/utils/transform-schema.util.ts

@@ -132,6 +132,7 @@ export function transformSchema(
 
       return new GraphQLInterfaceType({
         ...config,
+        interfaces: () => config.interfaces.map(replaceNamedType),
         fields: () => replaceFields(config.fields),
       });
     } else if (isUnionType(type)) {