Merge pull request #3109 from nestjs/chore/disable-shell-by-default

chore: disable shell by default

Author: kamilmysliwiec

commands/start.command.ts

@@ -44,8 +44,8 @@ export class StartCommand extends AbstractCommand {
       )
       .option(
         '--shell',
-        "Spawn child processes within a shell (see node's child_process.spawn() method docs). Default: true.",
-        true,
+        "Spawn child processes within a shell (see node's child_process.spawn() method docs). Default: false.",
+        false,
       )
       .option('--no-shell', 'Do not spawn child processes within a shell.')
       .option(

lib/runners/abstract.runner.ts

@@ -17,7 +17,6 @@ export class AbstractRunner {
     const options: SpawnOptions = {
       cwd,
       stdio: collect ? 'pipe' : 'inherit',
-      shell: true,
     };
     return new Promise<null | string>((resolve, reject) => {
       const child: ChildProcess = spawn(
@@ -35,9 +34,7 @@ export class AbstractRunner {
           resolve(null);
         } else {
           console.error(
-            red(
-              MESSAGES.RUNNER_EXECUTION_ERROR(`${this.binary} ${command}`),
-            ),
+            red(MESSAGES.RUNNER_EXECUTION_ERROR(`${this.binary} ${command}`)),
           );
           reject();
         }