Skip to content

Commit d43b91c

Browse files
Revert "chore: disable shell by default"
1 parent fe3aca7 commit d43b91c

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

commands/start.command.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ export class StartCommand extends AbstractCommand {
4444
)
4545
.option(
4646
'--shell',
47-
"Spawn child processes within a shell (see node's child_process.spawn() method docs). Default: false.",
48-
false,
47+
"Spawn child processes within a shell (see node's child_process.spawn() method docs). Default: true.",
48+
true,
4949
)
5050
.option('--no-shell', 'Do not spawn child processes within a shell.')
5151
.option(

lib/runners/abstract.runner.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ export class AbstractRunner {
1717
const options: SpawnOptions = {
1818
cwd,
1919
stdio: collect ? 'pipe' : 'inherit',
20+
shell: true,
2021
};
2122
return new Promise<null | string>((resolve, reject) => {
2223
const child: ChildProcess = spawn(
@@ -34,7 +35,9 @@ export class AbstractRunner {
3435
resolve(null);
3536
} else {
3637
console.error(
37-
red(MESSAGES.RUNNER_EXECUTION_ERROR(`${this.binary} ${command}`)),
38+
red(
39+
MESSAGES.RUNNER_EXECUTION_ERROR(`${this.binary} ${command}`),
40+
),
3841
);
3942
reject();
4043
}

0 commit comments

Comments
 (0)