Merge pull request #15020 from yatin166/fix/close-redis-connection-properly

fix(microservices): ensure all redis connections are closed

Author: kamilmysliwiec

packages/microservices/server/server-redis.ts

@@ -104,10 +104,10 @@ export class ServerRedis extends Server<RedisEvents, RedisStatus> {
     });
   }
 
-  public close() {
+  public async close() {
     this.isManuallyClosed = true;
-    this.pubClient && this.pubClient.quit();
-    this.subClient && this.subClient.quit();
+    this.pubClient && (await this.pubClient.quit());
+    this.subClient && (await this.subClient.quit());
     this.pendingEventListeners = [];
   }
 

packages/microservices/test/server/server-redis.spec.ts

@@ -59,11 +59,11 @@ describe('ServerRedis', () => {
       untypedServer.pubClient = pub;
       untypedServer.subClient = sub;
     });
-    it('should close pub & sub server', () => {
-      server.close();
+    it('should close pub & sub server', async () => {
+      await server.close();
 
-      expect(pub.quit.called).to.be.true;
-      expect(sub.quit.called).to.be.true;
+      expect(pub.quit.calledOnce).to.be.true;
+      expect(sub.quit.calledOnce).to.be.true;
     });
   });
   describe('handleConnection', () => {