Skip to content

Commit 4418a21

Browse files
Merge pull request #15061 from micalevisk/fix-issue-15060
fix(core): bring back `getHeader` and `appendHeader` methods from `AbstractHttpAdapter`
2 parents 25dcaa9 + cb6080e commit 4418a21

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

packages/core/adapters/http-adapter.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,9 @@ export abstract class AbstractHttpAdapter<
158158
abstract setErrorHandler(handler: Function, prefix?: string);
159159
abstract setNotFoundHandler(handler: Function, prefix?: string);
160160
abstract isHeadersSent(response: any);
161+
abstract getHeader(response: any, name: string);
161162
abstract setHeader(response: any, name: string, value: string);
163+
abstract appendHeader(response: any, name: string, value: string);
162164
abstract registerParserMiddleware(prefix?: string, rawBody?: boolean);
163165
abstract enableCors(options?: any, prefix?: string);
164166
abstract createMiddlewareFactory(

packages/core/test/utils/noop-adapter.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ export class NoopHttpAdapter extends AbstractHttpAdapter {
2121
setErrorHandler(handler: Function, prefix = '/'): any {}
2222
setNotFoundHandler(handler: Function, prefix = '/'): any {}
2323
isHeadersSent(response: any): any {}
24-
getHeader?(response: any, name: string) {}
24+
getHeader(response: any, name: string) {}
2525
setHeader(response: any, name: string, value: string): any {}
26-
appendHeader?(response: any, name: string, value: string) {}
26+
appendHeader(response: any, name: string, value: string) {}
2727
registerParserMiddleware(): any {}
2828
enableCors(options: any): any {}
2929
createMiddlewareFactory(requestMethod: RequestMethod): any {}

packages/platform-fastify/adapters/fastify-adapter.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -525,15 +525,15 @@ export class FastifyAdapter<
525525
return response.sent;
526526
}
527527

528-
public getHeader?(response: any, name: string) {
528+
public getHeader(response: any, name: string) {
529529
return response.getHeader(name);
530530
}
531531

532532
public setHeader(response: TReply, name: string, value: string) {
533533
return response.header(name, value);
534534
}
535535

536-
public appendHeader?(response: any, name: string, value: string) {
536+
public appendHeader(response: any, name: string, value: string) {
537537
response.header(name, value);
538538
}
539539

0 commit comments

Comments
 (0)