fix(core): attach root inquirer for nested transient providers

Author: kamilmysliwiec

packages/core/injector/injector.ts

@@ -32,6 +32,7 @@ import { CircularDependencyException } from '../errors/exceptions';
 import { RuntimeException } from '../errors/exceptions/runtime.exception';
 import { UndefinedDependencyException } from '../errors/exceptions/undefined-dependency.exception';
 import { UnknownDependenciesException } from '../errors/exceptions/unknown-dependencies.exception';
+import { Barrier } from '../helpers/barrier';
 import { STATIC_CONTEXT } from './constants';
 import { INQUIRER } from './inquirer';
 import {
@@ -42,7 +43,6 @@ import {
 } from './instance-wrapper';
 import { Module } from './module';
 import { SettlementSignal } from './settlement-signal';
-import { Barrier } from '../helpers/barrier';
 
 /**
  * The type of an injectable dependency
@@ -327,8 +327,10 @@ export class Injector {
           return parentInquirer && parentInquirer.instance;
         }
         if (inquirer?.isTransient && parentInquirer) {
-          inquirer = parentInquirer;
-          inquirerId = this.getInquirerId(parentInquirer);
+          // When `inquirer` is transient too, inherit the parent inquirer
+          // This is required to ensure that transient providers are only resolved
+          // when requested
+          inquirer.attachRootInquirer(parentInquirer);
         }
         const paramWrapper = await this.resolveSingleParam<T>(
           wrapper,

packages/core/injector/instance-wrapper.ts

@@ -82,6 +82,11 @@ export class InstanceWrapper<T = any> {
     | undefined;
   private isTreeStatic: boolean | undefined;
   private isTreeDurable: boolean | undefined;
+  /**
+   * The root inquirer reference. Present only if child instance wrapper
+   * is transient and has a parent inquirer.
+   */
+  private rootInquirer: InstanceWrapper | undefined;
 
   constructor(
     metadata: Partial<InstanceWrapper<T>> & Partial<InstancePerContext<T>> = {},
@@ -405,15 +410,28 @@ export class InstanceWrapper<T = any> {
     const isInquirerRequestScoped =
       inquirer && !inquirer.isDependencyTreeStatic();
     const isStaticTransient = this.isTransient && !isInquirerRequestScoped;
-
+    const rootInquirer = inquirer?.getRootInquirer();
     return (
       this.isDependencyTreeStatic() &&
       contextId === STATIC_CONTEXT &&
       (!this.isTransient ||
-        (isStaticTransient && !!inquirer && !inquirer.isTransient))
+        (isStaticTransient && !!inquirer && !inquirer.isTransient) ||
+        (isStaticTransient && !!rootInquirer && !rootInquirer.isTransient))
     );
   }
 
+  public attachRootInquirer(inquirer: InstanceWrapper) {
+    if (!this.isTransient) {
+      // Only attach root inquirer if the instance wrapper is transient
+      return;
+    }
+    this.rootInquirer = inquirer.getRootInquirer() ?? inquirer;
+  }
+
+  getRootInquirer(): InstanceWrapper | undefined {
+    return this.rootInquirer;
+  }
+
   public getStaticTransientInstances() {
     if (!this.transientMap) {
       return [];