test(common): Fix isEmptyArray behavior and update tests

Author: BrahimAbdelli

packages/common/test/utils/shared.utils.spec.ts

@@ -200,8 +200,10 @@ describe('Shared utils', () => {
   });
 
   describe('isEmptyArray', () => {
-    it('should return true when array is empty', () => {
+    it('should return true when array is empty or not exists', () => {
       expect(isEmptyArray([])).to.be.true;
+      expect(isEmptyArray(null)).to.be.true;
+      expect(isEmptyArray(undefined)).to.be.true;
     });
 
     it('should return false when array is not empty', () => {
@@ -211,8 +213,6 @@ describe('Shared utils', () => {
     });
 
     it('should return false for non-array values', () => {
-      expect(isEmptyArray(null)).to.be.false;
-      expect(isEmptyArray(undefined)).to.be.false;
       expect(isEmptyArray({})).to.be.false;
       expect(isEmptyArray('')).to.be.false;
       expect(isEmptyArray(0)).to.be.false;

packages/common/utils/shared.utils.ts

@@ -55,10 +55,10 @@ export const isNil = (val: unknown): val is null | undefined =>
   isUndefined(val) || val === null;
 
 export const isEmptyArray = (array: unknown): boolean => {
-  if (!Array.isArray(array)) {
-    return false;
+  if (isNil(array)) {
+    return true;
   }
-  return array.length === 0;
+  return Array.isArray(array) && array.length === 0;
 };
 
 export const isSymbol = (val: unknown): val is symbol =>