fix(websockets): detect native ws clients before calling emit

The emitMessage() method checked for client.emit first, but native
WebSocket clients from the ws package inherit from EventEmitter and
also have an emit method that only dispatches events locally. This
caused WsException errors to be emitted as local events instead of
being sent over the wire, resulting in the e2e test timing out.

Added an isNativeWebSocket() check that looks for a numeric readyState
property (per the WebSocket spec) to reliably distinguish native WS
clients from Socket.IO sockets. Also fixed prettier formatting on the
emitMessage generic signature, and updated test mocks to include
readyState on the native WS client stub.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: veeceey

packages/websockets/exceptions/base-ws-exception-filter.ts

@@ -4,7 +4,11 @@ import {
   Logger,
   WsExceptionFilter,
 } from '@nestjs/common';
-import { isFunction, isObject } from '@nestjs/common/utils/shared.utils';
+import {
+  isFunction,
+  isNumber,
+  isObject,
+} from '@nestjs/common/utils/shared.utils';
 import { MESSAGES } from '@nestjs/core/constants';
 import { WsException } from '../errors/ws-exception';
 
@@ -120,19 +124,38 @@ export class BaseWsExceptionFilter<
   /**
    * Sends an error message to the client. Supports both Socket.IO clients
    * (which use `emit`) and native WebSocket clients (which use `send`).
+   *
+   * Native WebSocket clients (e.g. from the `ws` package) inherit from
+   * EventEmitter and therefore also have an `emit` method, but that method
+   * only dispatches events locally. To distinguish native WebSocket clients
+   * from Socket.IO clients, we check for a numeric `readyState` property
+   * (part of the WebSocket specification) before falling back to `emit`.
    */
-  protected emitMessage<
-    TClient extends { emit?: Function; send?: Function },
-  >(client: TClient, event: string, payload: unknown): void {
-    if (isFunction(client.emit)) {
-      client.emit(event, payload);
-    } else if (isFunction(client.send)) {
+  protected emitMessage<TClient extends { emit?: Function; send?: Function }>(
+    client: TClient,
+    event: string,
+    payload: unknown,
+  ): void {
+    if (this.isNativeWebSocket(client)) {
       client.send(
         JSON.stringify({
           event,
           data: payload,
         }),
       );
+    } else if (isFunction(client.emit)) {
+      client.emit(event, payload);
     }
   }
+
+  /**
+   * Determines whether the given client is a native WebSocket (e.g. from the
+   * `ws` package) as opposed to a Socket.IO socket. Native WebSocket objects
+   * expose a numeric `readyState` property per the WebSocket specification.
+   */
+  private isNativeWebSocket(
+    client: Record<string, any>,
+  ): client is { send: Function; readyState: number } {
+    return isNumber(client.readyState) && isFunction(client.send);
+  }
 }

packages/websockets/test/exceptions/ws-exceptions-handler.spec.ts

@@ -106,13 +106,13 @@ describe('WsExceptionsHandler', () => {
 
     describe('when client uses "send" instead of "emit" (native WebSocket)', () => {
       let sendStub: sinon.SinonStub;
-      let wsClient: { send: sinon.SinonStub };
+      let wsClient: { send: sinon.SinonStub; readyState: number };
       let wsExecutionContextHost: ExecutionContextHost;
 
       beforeEach(() => {
         handler = new WsExceptionsHandler();
         sendStub = sinon.stub();
-        wsClient = { send: sendStub };
+        wsClient = { send: sendStub, readyState: 1 };
         wsExecutionContextHost = new ExecutionContextHost([
           wsClient,
           data,