Skip to content

Commit 488d6e8

Browse files
committed
Merge branch 'juliandunn-minitest' into 1.2
2 parents 36b55e6 + 7e60465 commit 488d6e8

File tree

7 files changed

+24
-20
lines changed

7 files changed

+24
-20
lines changed

net-ssh-multi.gemspec

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,18 +57,15 @@ Gem::Specification.new do |s|
5757
if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
5858
s.add_runtime_dependency(%q<net-ssh>, [">= 2.6.5"])
5959
s.add_runtime_dependency(%q<net-ssh-gateway>, [">= 1.2.0"])
60-
s.add_development_dependency(%q<test-unit>, [">= 0"])
6160
s.add_development_dependency(%q<mocha>, [">= 0"])
6261
else
6362
s.add_dependency(%q<net-ssh>, [">= 2.6.5"])
6463
s.add_dependency(%q<net-ssh-gateway>, [">= 1.2.0"])
65-
s.add_dependency(%q<test-unit>, [">= 0"])
6664
s.add_dependency(%q<mocha>, [">= 0"])
6765
end
6866
else
6967
s.add_dependency(%q<net-ssh>, [">= 2.6.5"])
7068
s.add_dependency(%q<net-ssh-gateway>, [">= 1.2.0"])
71-
s.add_dependency(%q<test-unit>, [">= 0"])
7269
s.add_dependency(%q<mocha>, [">= 0"])
7370
end
7471
end

test/channel_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require 'common'
22
require 'net/ssh/multi/channel'
33

4-
class ChannelTest < Test::Unit::TestCase
4+
class ChannelTest < Minitest::Test
55
def test_each_should_iterate_over_each_component_channel
66
channels = [c1 = mock('channel'), c2 = mock('channel'), c3 = mock('channel')]
77
channel = Net::SSH::Multi::Channel.new(mock('session'), channels)
@@ -149,4 +149,4 @@ def loop
149149
end
150150
end
151151
end
152-
end
152+
end

test/common.rb

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,9 @@
1-
require 'test/unit'
2-
require 'mocha'
1+
require 'minitest/autorun'
2+
require 'mocha/setup'
3+
4+
if Minitest.const_defined?('Test')
5+
# We're on Minitest 5+. Nothing to do here.
6+
else
7+
# Minitest 4 doesn't have Minitest::Test yet.
8+
Minitest::Test = MiniTest::Unit::TestCase
9+
end

test/multi_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require 'common'
22
require 'net/ssh/multi'
33

4-
class MultiTest < Test::Unit::TestCase
4+
class MultiTest < Minitest::Test
55
def test_start_with_block_should_yield_session_and_then_close
66
Net::SSH::Multi::Session.any_instance.expects(:loop)
77
Net::SSH::Multi::Session.any_instance.expects(:close)
@@ -17,4 +17,4 @@ def test_start_without_block_should_return_open_session
1717
Net::SSH::Multi::Session.any_instance.expects(:close).never
1818
assert_instance_of Net::SSH::Multi::Session, Net::SSH::Multi.start
1919
end
20-
end
20+
end

test/server_test.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require 'common'
22
require 'net/ssh/multi/server'
33

4-
class ServerTest < Test::Unit::TestCase
4+
class ServerTest < Minitest::Test
55
def setup
66
@master = stub('multi-session', :default_user => "bob")
77
end
@@ -50,23 +50,23 @@ def test_equivalence_when_host_mismatch
5050
s1 = server('user@host1:1234')
5151
s2 = server('user@host2:1234')
5252
assert !s1.eql?(s2)
53-
assert_not_equal s1.hash, s2.hash
53+
refute_equal s1.hash, s2.hash
5454
assert s1 != s2
5555
end
5656

5757
def test_equivalence_when_port_mismatch
5858
s1 = server('user@host:1234')
5959
s2 = server('user@host:1235')
6060
assert !s1.eql?(s2)
61-
assert_not_equal s1.hash, s2.hash
61+
refute_equal s1.hash, s2.hash
6262
assert s1 != s2
6363
end
6464

6565
def test_equivalence_when_user_mismatch
6666
s1 = server('user1@host:1234')
6767
s2 = server('user2@host:1234')
6868
assert !s1.eql?(s2)
69-
assert_not_equal s1.hash, s2.hash
69+
refute_equal s1.hash, s2.hash
7070
assert s1 != s2
7171
end
7272

@@ -112,7 +112,7 @@ def test_session_that_cannot_authenticate_adds_host_to_exception_message
112112
end
113113

114114
def test_close_channels_when_session_is_not_open_should_not_do_anything
115-
assert_nothing_raised { server('host').close_channels }
115+
server('host').close_channels
116116
end
117117

118118
def test_close_channels_when_session_is_open_should_iterate_over_open_channels_and_close_them
@@ -127,7 +127,7 @@ def test_close_channels_when_session_is_open_should_iterate_over_open_channels_a
127127
end
128128

129129
def test_close_when_session_is_not_open_should_not_do_anything
130-
assert_nothing_raised { server('host').close }
130+
server('host').close
131131
end
132132

133133
def test_close_when_session_is_open_should_close_session
@@ -253,4 +253,4 @@ def expect_connection_to(server)
253253
@master.expects(:next_session).with(server).returns(session)
254254
return session
255255
end
256-
end
256+
end

test/session_actions_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
require 'net/ssh/multi/server'
33
require 'net/ssh/multi/session_actions'
44

5-
class SessionActionsTest < Test::Unit::TestCase
5+
class SessionActionsTest < Minitest::Test
66
class SessionActionsContainer
77
include Net::SSH::Multi::SessionActions
88

@@ -125,4 +125,4 @@ def test_exec_should_capture_exit_status_of_process
125125
assert_equal 127, c[:exit_status]
126126
end
127127

128-
end
128+
end

test/session_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
require 'common'
22
require 'net/ssh/multi/session'
33

4-
class SessionTest < Test::Unit::TestCase
4+
class SessionTest < Minitest::Test
55
def setup
66
@session = Net::SSH::Multi::Session.new
77
end
@@ -198,4 +198,4 @@ def test_process_should_call_select_on_combined_readers_and_writers_from_all_ser
198198
IO.expects(:select).with([:a, :b, :c], [:a, :c], nil, 5).returns([[:b, :c], [:a, :c]])
199199
@session.process(5)
200200
end
201-
end
201+
end

0 commit comments

Comments
 (0)