You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Galaxy Fixes
* Initial VRF-Lite for NDFC (#181)
* initial policy work
* change to pipe
* more work on templating into module structure
* more work on policies and policy_group buildout under a switch
* refactor template
* refactor template complete
* refactor template again & start of cross-ref rule
* update template & task using policy module
* small updates for policy create
* prototype use case policy
* rebase for only initial policy
* more updates for pr
* resolve lint errors
* resolve lint errors
* resolve lint errors
* resolve lint errors
* resolve lint errors
* remove render roles items
* update initial render tasks
* updated ndfc_vrf_lite_bgp.j2
* adjustment to where switch cmds are generated
* fix lint errors
* udpated j2 file for the vrf lite ebgp
* commit fix for dup names
* Updated MD to MD_Extended for the policy
* adding ndfc_vrf_lite_ospf template
* updates for ndfc_vrf_lite_ospf
* updated ndfc_vrf_lite_bgp.j2
* fixing typo in the vrf lite bgp jinja2
* add initial prepare plugin for vrf lites & remove render role dependency
* update ignore files
* moving vrf lite bgp and ospf jinja2 files to the common role
* expanded vrf-lite-ospf template for interface ospf
* format update
* expanded vrf lite bgp j2
* updated vrf lite bgp jinja2
* updating defaults to match the nac-vxlan repo updates
* fix defaults and update vrf_lite_ospf jinja
* prepare vrf liteupdates:
Updates
- adding logic to update redistribution secion of each switch to use the
global config
- update ospf secion of each interface is ospf is enabled and ospf
section is not defined under the interface or default area is not
given
* remove tailing spaces
* lint
* clean up render role
* remove render.py from ignore txt
* fixed a typo in the code
* updated vrf lite bgp jinja2
* fix for ospf default area
* fix a bug
* updated the vrf lite bgp jinja2 template
* updated the vrf lite bgp jinja2 template
* udpated and renamed vrf lite ebgp jinja2 file
* Removed comment from the vrf_lite ebgp jinja2 file
* update ospf vrf-lite template for bfd
* ospf vrf-lite template updates for bfd
* Expanded ndfc_vrf_lite_ebgp.j2
* Updated ndfc_vrf_lite_ebgp.j2
* partial fix for default_area in prep plugin
* minor fix of prepare vrf_lite plugin
* fixes for area number in vrf lite ospf template
* updated ndfc_vrf_lite_ebgp.j2
* update ospf default cost
* update defaults for ospf cost and ebgp_multihop
* updated defauts for lsa_retransit_interval and lsa_transmit_delay
* Updated vrf lite ebgp jinja2
* removed route reflector client config
* update allow_as parameter
Signed-off-by: ccoueffe <[email protected]>
* update allow_as_in_number to 3
Signed-off-by: ccoueffe <[email protected]>
* rename allowas to allow_as
Signed-off-by: ccoueffe <[email protected]>
* update jinja ospf
Signed-off-by: ccoueffe <[email protected]>
* update jinja for ospf cost
* pass defaults to jinja template
* pass defaults to jinja template
* updated jinja template with default references
* add condition for ospf + direct and static redistribution
Signed-off-by: ccoueffe <[email protected]>
* add helper function for hostname to ip address mapping lookup
* remove 108 reference
* update interface name + router_id
Signed-off-by: ccoueffe <[email protected]>
* updated multihop defalut in the vrf lite ebgp j2
* Fixed the bgp_peers indentation in the defaults
* vrf-lite ospf jinja updates: fixed duplication for bfd enabled; fixed redistribution
* removed route-map from the vrf lite ebgp jinja2
* create global bfd and redistribution values and update condition for bfd and ospf redistribution in bgp
* updated vrf lite ebgp jinja2
* Updates in the vrf lite ebgp jinja2
* defaults update in the vrf lite ebgp jinja2
* update wording for VRF-lite ospf template
* removed when condition on policies.yml
* update send-community to false
Signed-off-by: ccoueffe <[email protected]>
* commented distance since its wip
* removed redistribute direct route-map since it's configured by default and we see out of sync
* updated ospf jinja template for area parameters and distance
* Removed direct redistribution
* Prep plugin update for the vrf lite address family and ebgp jinja2 updates
* addressed whitespaces
* addressed whitespaces
* addressed whitespaces
* added check for the bgp in the 107 prep plugin
* updated vrf-lite ospf jinja, fix for area check and remove auth
* updates to use ipaddr filter to get area id in IP format
* updates for ospf interface authentication
* update defaults for interface authentication
* fix for interface auth
* update area id if area is equal to 0. ipaddress(0) equal to False not 0.0.0.0
* Add condition if default-cost if default of 1 (default value) don't push cli (out-of-sync issue)
* fix trailing-whitespace
* fix trailing-whitespace
* Add rule 502 and update typo ospf jinja
Signed-off-by: ccoueffe <[email protected]>
* Add conditions to rule 502
Signed-off-by: ccoueffe <[email protected]>
* clean PEP8 and rewrite with function
* fixed closing braket
* update error message with path
* Update data model path in the comments
* update comment with key data model
* rewrite and fix static function
* move result variable
* Strip outer defaults key (#206) (#207)
Co-authored-by: Mike Wiebe <[email protected]>
* updating the defaults in ndfc_vrf_lite_ebgp.j2
* update for defaults bfd
* fix for bfd and all other fixes for custom defaults
* fix for loopback lowercase in rules
* add rule for loopback and passive-interface
* updates to exclude passive-interface for loopback interfaces
* added bfd in the vrf lite ebgp jinja2
* updates for custom default
* fix for ospf.distance and auth_type
* update for area_type for custom defaults
* add check ospf process
* update script 502
* fix typo
* adding feature ospf to template for vrf-lite ospf
* update prep 107 to allow configuration without vrf-lite and reformat rule 502 to fit PEP8 (long lines, quotes)
* update defaults and ospf template for nssa and default-information originate
* add verification in rule 502 for nssa
* add missing keywork translate type7 for supress-fa, never and and always
* Temp update prep_107_vrf_lites.py
* Temp update prep_107_vrf_lites.py
* Fix typo and order
* Update ndfc_vrf_lite_ospf.j2
remove list for nssa and default_originate
* Update 502_policy_vrf_lite_cross_reference.py
update class check_global_ospf_nssa: remove list
* Update prep_107_vrf_lites.py
Adding to bypass pylint sanity check error
* Update prep_107_vrf_lites.py
Update pylint location to bypass sanity checks
* Update prep_107_vrf_lites.py
removing whitespace
* Update requirements.txt
To use the ipaddr filter in Ansible, you need to install the netaddr Python library. Required for prep_plugin 107. https://docs.ansible.com/ansible/latest/collections/ansible/utils/docsite/filters_ipaddr.html
* Update ndfc_vrf_lite_ospf.j2
reorder option nssa
no-summary should be before no-redistribution in the show run.
Ex:
router ospf OVERLAY
vrf nac-vrf01
router-id 1.1.1.1
area 0.0.0.10 nssa no-summary no-redistribution default-information-originate
area 0.0.0.20 nssa translate type7 always supress-fa
default-information originate
* Update prep_107_vrf_lites.py
update remove lines 40-42 to 41-43
* Update ndfc_vrf_lite_ospf.j2
remote list line 78
{% set _= nssa_options_flags.append(area.nssa.route_map) %}
* Update prep_107_vrf_lites.py
remove nac_ from unique_name, because it was adding in policy.j2 now.
* Update sub_main.yml
Removing comment for end_play
---------
Signed-off-by: ccoueffe <[email protected]>
Co-authored-by: devegupt <[email protected]>
Co-authored-by: Justin Burnette (juburnet) <[email protected]>
Co-authored-by: mwiebe <[email protected]>
Co-authored-by: Shangxin Du <[email protected]>
Co-authored-by: ccoueffe <[email protected]>
Co-authored-by: Devendra Gupta <[email protected]>
Co-authored-by: Charly Coueffe <[email protected]>
Co-authored-by: juburnet <[email protected]>
* updated prepare plugins to create new ip address field instead of replacing hostname (#233)
* updated prepare plugins to create new ip address field instead of replacing hostname
* Update prep_103_topology_switches.py
* Update prep_103_topology_switches.py
* updated the name to be more meaningful
* Update dc_vxlan_fabric_bootstrap.j2 (#228)
* Update unmanaged_policy after updating prepare plugins to add additional mgmt ip rather than replacing hostname (#238)
* Update unmanaged_policy.py
* Split onto multiple lines
* Update unmanaged_policy.py
* Update prep_104_fabric_overlay_services.py (#247)
rename switch['hostname'] to switch['mgmt_ip_address']
* Style, grammar, and typo edits to the README.md (#240)
* writting to writing in README.md
* Modify grammar and styling in Step 2
In step 2 about Python virtual environments:
* Modify grammar for better flow
* Add inline code fences around a couple of commands
* Add Services as Code alert in README.md
Move the quoted note to a Note Alert section.
Add Services as Code hyperlink.
* Change collection description in README.md
Attempt to change the NetAsCode VXLAN EVPN collection description by restructuring the sentence.
* Change verb create to creates README.md
Change 'create' to 'creates' to match the previous third person verb of 'reads' preceding the 'and' word.
* Fix discovers typo in README.md
* Move notes to Alert and fix typo in README.md
* Move safety-related notes to Warning Alerts
* Fix "earlier" typo
* Code fence role names in Advantages section
* Place role names in code fences to emphasize them in the "Advantages of the Roles in the Workflow" section.
* Break up long lines to Markdown lint
* it's to its in README.md
Correct "it's" (it is) usage to possessive "its" (for the collection requirements)
* Fix cloning in README.md
* Fix cloning typo
* Split up long lines (Markdown lint)
* Change Step 5 Callbacks wording in README.md
Change Step 5 Callbacks wording slightly to improve flow
* Change grammar in Inventory section in README.md
* Change: is organizing >> organizes
* Add "as" word to explained in another document
* Specify root dir for Update the Inventory
Specify which root dir (project) in the Update the Inventory section.
* Move env var for security note to an Alert in README.md
Move the important reasoning for environment variables to an Important Alert block.
* Add more content to env var Alert block
* Punctuation in Set Env Vars
Add punctuation in Step 3 - Set Environment Variables
* Modify selectively run example in README.md
* Make Run lowercase (not the first word)
* Add a period for punctuation at end of sentence
* Place the example in a Tip Alert block
* Proposed fix for Issue 235 (#241)
* Update ndfc_vrf_lite_ebgp.j2
Proposed fix for Issue #235
* addressing comments in the review for issue #235
addressing comments in the review for issue #235
* Fix connectivity check role for v6 managemnt ip (#250)
* Proposed fix for Issue #243 (#244)
Proposed fix for Issue #243
* Readme formatting for role level tags (#254)
* Move role level tags into table in README.md
* Place automatic validate note in an Alert
* Closing pipe symbols on role level tags table
* Proposed fix for Issue #234 (#242)
* Proposed fix for Issue #234
Proposed fix for Issue #234
* addressing comments in the review for issue #234
addressing comments in the review for issue #234
* addressing comments in the review for issue #234
addressing comments in the review for issue #234
* adding spaces as suggested in the review
adding spaces as suggested in the review
* separating vrf life protocol in a dedicated folder
* sync vrf_lite_ebgp
* removing vrf lite file from main folder
* fixed the issue with the prep_107_vrf_lites.py (#257)
* fixed the issue with the prep_107_vrf_lites.py
* Fixed the if condition as per the review comment
* Update dc_vxlan_fabric_base.j2 (#260)
* inital changes to support pre provisioned switches and links (#194)
* inital changes to support pre provisioned switches and links
* Added support for the VRF loopback ID and IP assignments
Requires update to the DCNM module for vrf as instance values
required ipv4 and ipv6, but only one or both are the options
* removed whitespace
* Refactored links addition
* fixed typo
* Fixed a further typo
* Added additional clauses to catch apparent NDFC bug
* Changed IP address for VRF loopback names to show ipv4 and ipv6
* Added fabric links create required to main.yaml in create
* updates to turn on virtual peer link for vpc pairs
* many changes made for federated fabric overlay management
* update to only add POAP section inventory if POAP exists in new Schema
* updates to structure so main is where fed and none fed fabrics branch
* Created action plugin for existing fabric links checking
* Freeform int pre prov (#217)
* Added support for interface freeform as well as allowing framework to
proceed when no overlay services are supplied
* Added support for external fabric onboarding. Does not include creation
of the fabric as this is TODO. So fabric needs to exist in NDFC first
* remove fix for tags issue
* Re-inserting space at the top of the file
* Revert "Merge branch 'federated_fabric' into Pete&Matt"
This reverts commit 9eea368, reversing
changes made to a6bbf05.
* Update ndfc_attach_vrfs_loopbacks.j2
* Adding changed needed after merge with develop
* Updated to test and utilise virtualPeerlink flag in dcnm collection
* removed trailing whitespace
* fixed indentation
* more indentation fixes
* adding line in sanity tests for new action plugin
* added rescue block for save task
* update host to mgmt_ip_address for vrf attach groups
* Adding templates needed to build external fabrics
* Adding top level logic to pick external vs evpn
* Update existing_links_check.py
* Update existing_links_check.py
* updates to resolve comments
* updates to handle empty response from get existing links call
* fixed pep8 issues
* updates to remove loops around vrf loopback attachment
* remove un needed playbook and removed whitespace
* removal process added for fabric links
* reseting defaults for removal back to false
* refactored removal of fabric links
* fixed indentation
* more style fixes
* more pep8 fixes
* added docstring
* removed trailing whitespace
* updated to add new action plugin
* fixed tags issue
* fixed formatting
* import vs include
* added external fabric create step
---------
Co-authored-by: mikewiebe <[email protected]>
Co-authored-by: POD-09 <[email protected]>
* New Flags Documentation
* add fix for bgp redistribution and support with different route_map for IPv4 and IPv6 (#261)
* Update to support route_control (#248)
* new prep plugin for route_control
* adding jinja templates
* adding jinja template for prefix list
* update names to match data model
* updated item names
* updated order of jinja templates
* updated for ipv4_prefix_lists
* add fixes for prep_108 + initial part for IPv4 ACL with Debug
* update IPv4 ACL template
* update route-control
* cleaning debug
* add time-range and update ipv4 ACL
* add code for time range
* add object-group
* adding ndfc_mac_list.j2
* add first part for IPv6 ACL
* update ACL and add fragment and ignore_routage
* create initial template for community, ACL: rename range_start/range_end to from/to and replace netmask by hostmask
* add code for IP Pfx
* add extension_header for IPv6 ACL
* started route_map jinja
* rename entrie to entry
* add code for community list
* update prep_108 to support hwaddr filter and used in ip ext community_list
* adding route control rule. temp id 505
* cleaning 505_policy_route_control_route_map.py code
* cleaning 505_policy_route_control_route_map.py code
* update route_maps based on change in schema
* verity that route_control exists in data source
* verity that route_control exists in data source
* clean templates
* add as_path_access_lists and update route_map
* add set precedence + prefix-list
* add set as-path
* add latest option for set as-path
* add set comm-list + set ipv4 and ipv6 nh
* add route-map set for extcommunity and remove all debug
* fix set comm-list
* updating the checks based on the new scehma version
* add validate_unique_names
* adding checks on all route control objects
* reorder some option to avoid out-of-sync
* check if policy defined in groups exist under route control
* remove nac_ from prep plugin
* minor: adding single quote
* update list of checks
* fix order for set community
* adding check for rule 15
* removing check 16
* update prep_108 plugin to rewrite port_number, precedence, and interfaces in the data source
* refactor prep_108
* fixing typo
* update mac_list with hwaddr() to format mac address
* add missing code for set extcommunity evpn rmac and rt
* update route-map and prep_108 based on schema update
* replace extended_community with extended_community_number_list
replace "_" by "-" for option set comm-list
* fix issue for ip prefix length
* rename unique policy: remove switch_name from the name.
* update for prepend_last_as_count
* fix pep8 in rule 505
* remove return from prep_107
* fix typo prep 107
* add empty line
* change permission on route_control.j2
* remove doc_strings
* add ignore sanity for prep 108
* move jinja templates for route_control to one folder ndfc_route_control
* merge import in prep_108,
move main jinja route_control out of the folder.
remove ansible.builtin.meta for sub_main
* update prep_108 with helper function
* split ACLs and route_map templates
* rename function with "update_" and merge code for IPv4 and IPv6 ACLs.
* add | sort(attribute='seq_number') to reorder sequence number to all route_control templates
in ndfc_prefix_list.j2, update entry["prefix"] with filter {{ entry["prefix"] | ipaddr('network/prefix') }} in case or prefix is not the supernet.
Ex: 172.17.1.0/19 is part of 172.17.0.0/19. CLI should have 172.17.0.0/19 else there is an out-of-sync.
* update to support and rewrite icmp type code for IPv4 and IPv6
* Fix missing whitspace
---------
Co-authored-by: Justin Burnette (juburnet) <[email protected]>
Co-authored-by: Gaetano Carlucci <[email protected]>
* Update prep_108_route_control.py (#267)
update script to avoid duplicate policy in the extended model:
vxlan.policy.groups and vxlan.policy.policies.
Duplicate appears because we removed switch name in the policy description.
* Initial MSD Support (#249)
* MSD sub-main changes
* MSD sub-main changes
* Added sub-main-common and service model validation
* Split validate and load functions
* Refactoring sub main common
* MSD create role
* Additional refactoring for MSD and VXLAN workflows
* updates for msd fabric templating
* remove dup file
* update create task for msd
* update create task for msd
* Add child fabrics logic
* updated defaults
* Update prepare plugins
* more work on msd & shift to overlay key from overlay_services but with backward compat.
* updates for build and deployment of both single fabrics and msd fabrics
* chagnes from review with mike
* update fabric name reference to use extended
* updats to msite templates
* update to msd tempaltes and add conditional to only run child fabrics if defined
* first commit from hospital
* updates for remove child fabrics and isn
* updates to current msd workflow
* update github templates
* fix pipeline errors
* fix pipeline errors
* fix deprecation error in pipeline
* fix deprecation error in pipeline
* fix deprecation error in pipeline
* Fix prep_001 plugin for multisite
* Workflow fixes
* Fix list defaults bug
* Prepare plugin refactor
* More refactoring
* Initialize shared dict vars
* refactored external network into new format
* more refactoring for external fabrics
* bug fix in sub_main_external in common
* External plus refactoring
* ISN remove devices and bug fixes
* Enable child fabric delete mode flag
* Github actions fixes
* GitHub Actions Issues
* More GitHub Actions Fixes
* Deploy False for Fabrics
* Refactor for sharing code and simplification
* Refactoring and Multisite VRF and Network Removal Flag
* Fix route control no data
* Fix github actions issue
* Fix rule 401
* update defaults for msite
* fix typo
* fix defaults
* refactor template groupings for vpc and vrf loopback
* fix to isn fabric template
* get fabric attributes, fix msd templates, & start work on mapping switch to fabric
* fix errors
* refactor msite build for preprocessing for vrfs/networks attachments
* fix lint errors
* add msd child fabric vrfs template & fix lint errors
* fixes
* set msite prepare defaults
* updated existing rules to allow empty vrfs & add first msite rule
* fix lint errors
* add msite cross-ref rule
* fix typo
* refactor prep of msite child fabric and msite data and vrf and network processing
* update ignores
* remove lint errors
* work in progress on templating child fabric vrfs
* update error handling
* remove end_play
* update msd vrfs work
* cleanup lint errors
* test ignore line length
* refactor line lengths
* update tests and add 2.17 in actions
* resolve lint issues
* update child fabric vrf check for netflow & trm
* update child fabric vrf check for netflow & trm
* update child fabric vrf check for netflow & trm
* refactor to import tasks in create & msite data task in create
* update from msd_copy. Fix BGP AsDOT, Bootstrap limitation, Add resource manager for manual underlay allocation. Include fix#269
* Revert "update from msd_copy. Fix BGP AsDOT, Bootstrap limitation, Add resource manager for manual underlay allocation. Include fix#269"
This reverts commit fd43c49.
* updates to vrf and child fabric deploy
* fix lint errors
* update test exclusions
* add msd child fabric networks
* fix lint error
* add msd vrf and network remove
* update deploy & remove for isn, msd, and external fabric
* Multisite workflow fixes
* Fix links and links filter bugs
* Cleanup old comments
---------
Co-authored-by: Aneesh Ramgopal (anramgop) <[email protected]>
Co-authored-by: mwiebe <[email protected]>
Co-authored-by: Matt Thurston <[email protected]>
Co-authored-by: ccoueffe <[email protected]>
* Fix For Loading Yaml File Content and Inline Hashes (#271)
* fix for loading yaml file content and inline hashses
* Update ndfc_policy.j2
* update special variable (#273)
* Update ndfc_policy.j2 (#281)
* Add support for IPv4 and IPv6 static route with additional options (#269)
* Add IPv4 static route in OSPF and BGP with new parameters: name, track, tag, route preference
* update script to check static route compliance for IPv4 and IPv6. if routes are defined in two different policies for the same VRF and Switch, routes must be equal.
* add ipv6 static route in BGP template
* fix pycodestyle
* move static route outside of OSPF and BGP.
---------
Co-authored-by: mwiebe <[email protected]>
* Enforce BGP AS to a string (#282)
* Update dc_vxlan_fabric_general.j2
quote BGP_AS to fix issue with AS.DOT.
* Update dc_external_fabric_general.j2
quote BGP_AS to fix issue with AS.DOT.
* Update isn_fabric_general.j2
quote BGP_AS to fix issue with AS.DOT.
* Update README.md with MSD info (#286)
* Update README.md with MSD info
Added MSD info and workflow at the bottom of the document
* Update README.md
* Update README.md
* Update README.md for MSD. Also rename MCF to MFD
* Handle When vPC is Not Solely Leaf Role (#285)
* vpc fixes when not leaf role
* add vpc rule check
* Fix github actions failure
* fix lint
---------
Co-authored-by: mwiebe <[email protected]>
* Policy Fix for Multiline & BGP AS-Dot & Remove Fix & Register Config-Save Var (#287)
* vpc fixes when not leaf role
* mask string when it has period or colon
* mask string when it has period or colon
* test string typecast
* add vpc rule check
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* Fix github actions failure
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* test another fix
* fix lint
* fix for missing template in removal action plugin for fabric links
* register config_save var
---------
Co-authored-by: mwiebe <[email protected]>
Co-authored-by: Matt Thurston <[email protected]>
* Release 0.4.0 Updates (#283)
* Release Prep Updates
* More changelog updates
* Review comments
* Update README.md fix control variable table (#289)
* Fix problem with removing fabric links created during discovery
---------
Signed-off-by: ccoueffe <[email protected]>
Co-authored-by: Matt Tarkington <[email protected]>
Co-authored-by: devegupt <[email protected]>
Co-authored-by: Justin Burnette (juburnet) <[email protected]>
Co-authored-by: Shangxin Du <[email protected]>
Co-authored-by: ccoueffe <[email protected]>
Co-authored-by: Devendra Gupta <[email protected]>
Co-authored-by: Charly Coueffe <[email protected]>
Co-authored-by: juburnet <[email protected]>
Co-authored-by: Matt Thurston <[email protected]>
Co-authored-by: Michael Bear <[email protected]>
Co-authored-by: Gaetano Carlucci <[email protected]>
Co-authored-by: Gaetano Carlucci <[email protected]>
Co-authored-by: POD-09 <[email protected]>
Co-authored-by: Aneesh Ramgopal (anramgop) <[email protected]>
Co-authored-by: Matt Thurston <[email protected]>
0 commit comments