Fix linting

Author: danischm

.github/workflows/lint.yml

@@ -19,9 +19,9 @@ jobs:
         go-version: '1.24'
 
     - name: Run golangci-lint
-      uses: golangci/golangci-lint-action@v6
+      uses: golangci/golangci-lint-action@v8
       with:
-        version: latest
+        version: v2.5
         args: --timeout=5m
 
   format:

.github/workflows/security.yml

@@ -8,29 +8,6 @@ on:
     - cron: '0 0 * * 1'
 
 jobs:
-  gosec:
-    name: gosec security scan
-    runs-on: ubuntu-latest
-
-    steps:
-    - name: Checkout code
-      uses: actions/checkout@v4
-
-    - name: Set up Go
-      uses: actions/setup-go@v5
-      with:
-        go-version: '1.24'
-
-    - name: Run gosec
-      uses: securego/gosec@master
-      with:
-        args: '-fmt sarif -out results.sarif ./...'
-
-    - name: Upload SARIF file
-      uses: github/codeql-action/upload-sarif@v3
-      with:
-        sarif_file: results.sarif
-
   govulncheck:
     name: Go vulnerability check
     runs-on: ubuntu-latest

.golangci.yml

@@ -63,6 +63,10 @@ linters-settings:
   revive:
     confidence: 0.8
 
+  gosec:
+    excludes:
+      - G104  # Covered by errcheck linter
+
 issues:
   exclude-dirs:
     - examples

.gosec.yaml

@@ -4,8 +4,8 @@
 help:
 	@echo "Available targets:"
 	@echo "  test       - Run all tests"
-	@echo "  lint       - Run linters (golangci-lint)"
-	@echo "  security   - Run security scanner (gosec)"
+	@echo "  lint       - Run linters (golangci-lint with gosec)"
+	@echo "  security   - Run vulnerability check (govulncheck)"
 	@echo "  coverage   - Run tests with coverage report"
 	@echo "  benchmark  - Run benchmarks"
 	@echo "  clean      - Clean build artifacts"
@@ -24,14 +24,14 @@ lint:
 	@echo "Running linters..."
 	golangci-lint run
 
-# Run security scanner
+# Run security scanner (vulnerability check)
 security:
-	@echo "Running security scanner..."
-	@if which gosec > /dev/null 2>&1; then \
-		gosec -quiet ./...; \
+	@echo "Running vulnerability check..."
+	@if which govulncheck > /dev/null 2>&1; then \
+		govulncheck ./...; \
 	else \
-		echo "WARNING: gosec not installed. Run 'make tools' to install it."; \
-		echo "Skipping security scan..."; \
+		echo "WARNING: govulncheck not installed. Run 'make tools' to install it."; \
+		echo "Skipping vulnerability check..."; \
 	fi
 
 # Run tests with coverage
@@ -66,7 +66,7 @@ verify: fmt test lint security
 tools:
 	@echo "Installing development tools..."
 	go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
-	go install github.com/securego/gosec/v2/cmd/gosec@latest
+	go install golang.org/x/vuln/cmd/govulncheck@latest
 
 # CI pipeline checks (used in GitHub Actions)
 ci: test lint security

Makefile

@@ -1,4 +1,3 @@
-//nolint:errcheck,gosec // Example code prioritizes readability over error handling
 // Package main demonstrates basic go-netconf API usage.
 //
 // This example shows:
@@ -13,6 +12,8 @@
 //	export NETCONF_USERNAME=admin
 //	export NETCONF_PASSWORD=secret
 //	go run main.go
+//
+//nolint:errcheck,gosec // Example code prioritizes readability over error handling
 package main
 
 import (

examples/basic/main.go

@@ -1,4 +1,3 @@
-//nolint:errcheck,gosec // Example code prioritizes readability over error handling
 // Package main demonstrates candidate datastore workflow with go-netconf.
 //
 // This example shows:
@@ -14,6 +13,8 @@
 //	export NETCONF_USERNAME=admin
 //	export NETCONF_PASSWORD=secret
 //	go run main.go
+//
+//nolint:errcheck,gosec // Example code prioritizes readability over error handling
 package main
 
 import (

examples/candidate/main.go

@@ -1,4 +1,3 @@
-//nolint:errcheck,gosec // Example code prioritizes readability over error handling
 // Package main demonstrates concurrent operations with go-netconf.
 //
 // This example shows:
@@ -13,6 +12,8 @@
 //	export NETCONF_USERNAME=admin
 //	export NETCONF_PASSWORD=secret
 //	go run main.go
+//
+//nolint:errcheck,gosec // Example code prioritizes readability over error handling
 package main
 
 import (

examples/concurrent/main.go

@@ -1,4 +1,3 @@
-//nolint:errcheck,gosec // Example code prioritizes readability over error handling
 // Package main demonstrates custom RPC operations with go-netconf.
 //
 // This example shows:
@@ -12,6 +11,8 @@
 //	export NETCONF_USERNAME=admin
 //	export NETCONF_PASSWORD=secret
 //	go run main.go
+//
+//nolint:errcheck,gosec // Example code prioritizes readability over error handling
 package main
 
 import (

examples/custom-rpc/main.go

@@ -1,4 +1,3 @@
-//nolint:errcheck,gosec // Example code prioritizes readability over error handling
 // Package main demonstrates filter usage with go-netconf.
 //
 // This example shows:
@@ -12,6 +11,8 @@
 //	export NETCONF_USERNAME=admin
 //	export NETCONF_PASSWORD=secret
 //	go run main.go
+//
+//nolint:errcheck,gosec // Example code prioritizes readability over error handling
 package main
 
 import (