Fix SSO login on ChromeOS by using Device Code Flow (#134)

* Fix SSO login on ChromeOS by using Device Code Flow

  ChromeOS runs Android apps in a container with separate network namespace,
  preventing the browser from reaching the localhost callback server used by
  PKCE flow. This causes "service not available" errors after authentication.

  Use Device Code Flow on ChromeOS (like Android TV) which uses polling
  instead of localhost callback. On ChromeOS, also auto-open the browser
  for a similar UX to PKCE while showing QR dialog as fallback.

* update submodule

Author: mlsmaycon

app/src/main/java/io/netbird/client/MainActivity.java

@@ -73,6 +73,7 @@ private enum ConnectionState {
 
     private boolean isSSOFinishedWell = false;
     private boolean isRunningOnTV = false;
+    private boolean useDeviceCodeFlow = false;
 
     // Last known state for UI updates
     private ConnectionState lastKnownState = ConnectionState.UNKNOWN;
@@ -105,9 +106,13 @@ protected void onCreate(Bundle savedInstanceState) {
         setSupportActionBar(binding.appBarMain.toolbar);
 
         isRunningOnTV = PlatformUtils.isAndroidTV(this);
+        useDeviceCodeFlow = PlatformUtils.requiresDeviceCodeFlow(this);
         if (isRunningOnTV) {
             Log.i(LOGTAG, "Running on Android TV - optimizing for D-pad navigation");
         }
+        if (useDeviceCodeFlow && !isRunningOnTV) {
+            Log.i(LOGTAG, "Running on ChromeOS - using device code flow for authentication");
+        }
 
         setVersionText();
 
@@ -177,7 +182,7 @@ public void onDrawerClosed(View drawerView) {
             }
         });
 
-        if (!isRunningOnTV) {
+        if (!useDeviceCodeFlow) {
             urlOpener = new CustomTabURLOpener(this, () -> {
                 if (isSSOFinishedWell) {
                     return;
@@ -202,11 +207,20 @@ public void open(String url, String userCode) {
                         mBinder.stopEngine();
                     });
                     qrCodeDialog.show(getSupportFragmentManager(), "QrCodeDialog");
+
+                    if (!isRunningOnTV) {
+                        try {
+                            Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(url));
+                            startActivity(browserIntent);
+                        } catch (Exception e) {
+                            Log.e(LOGTAG, "Failed to open browser for device code flow: " + e.getMessage());
+                        }
+                    }
                 }
 
                 @Override
                 public void onLoginSuccess() {
-                    Log.d(LOGTAG, "onLoginSuccess fired for TV.");
+                    Log.d(LOGTAG, "onLoginSuccess fired for device code flow.");
                     if (qrCodeDialog != null && qrCodeDialog.isVisible()) {
                         qrCodeDialog.dismiss();
                         qrCodeDialog = null;
@@ -233,12 +247,12 @@ public void onLoginSuccess() {
                     if (VPNService.isUsingAlwaysOnVPN(this)) {
                         showAlwaysOnDialog(() -> {
                             if (mBinder != null) {
-                                mBinder.runEngine(urlOpener, isRunningOnTV);
+                                mBinder.runEngine(urlOpener, useDeviceCodeFlow);
                             }
                         });
                     } else {
                         if (mBinder != null) {
-                            mBinder.runEngine(urlOpener, isRunningOnTV);
+                            mBinder.runEngine(urlOpener, useDeviceCodeFlow);
                         }
                     }
                 });
@@ -347,7 +361,7 @@ public void switchConnection(boolean status) {
         if (prepareIntent != null) {
             vpnActivityResultLauncher.launch(prepareIntent);
         } else {
-            mBinder.runEngine(urlOpener, isRunningOnTV);
+            mBinder.runEngine(urlOpener, useDeviceCodeFlow);
         }
     }
 

app/src/main/java/io/netbird/client/PlatformUtils.java

@@ -2,6 +2,7 @@
 
 import android.app.UiModeManager;
 import android.content.Context;
+import android.content.pm.PackageManager;
 import android.content.res.Configuration;
 
 public final class PlatformUtils {
@@ -16,5 +17,15 @@ public static boolean isAndroidTV(Context context) {
         }
         return false;
     }
+
+    public static boolean isChromeOS(Context context) {
+        PackageManager pm = context.getPackageManager();
+        return pm.hasSystemFeature("org.chromium.arc")
+                || pm.hasSystemFeature("org.chromium.arc.device_management");
+    }
+
+    public static boolean requiresDeviceCodeFlow(Context context) {
+        return isAndroidTV(context) || isChromeOS(context);
+    }
 }