Skip to content

Commit 7ce5507

Browse files
authored
[client] fix darwin dns always throwing err (#4403)
* fix: dns/host_darwin.go was missing if err != nil before throwing error
1 parent 0320bb7 commit 7ce5507

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

client/internal/dns/host_darwin.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,10 @@ func (s *systemConfigurator) removeKeyFromSystemConfig(key string) error {
166166

167167
func (s *systemConfigurator) addLocalDNS() error {
168168
if !s.systemDNSSettings.ServerIP.IsValid() || len(s.systemDNSSettings.Domains) == 0 {
169-
err := s.recordSystemDNSSettings(true)
170-
log.Errorf("Unable to get system DNS configuration")
171-
return err
169+
if err := s.recordSystemDNSSettings(true); err != nil {
170+
log.Errorf("Unable to get system DNS configuration")
171+
return fmt.Errorf("recordSystemDNSSettings(): %w", err)
172+
}
172173
}
173174
localKey := getKeyWithInput(netbirdDNSStateKeyFormat, localSuffix)
174175
if s.systemDNSSettings.ServerIP.IsValid() && len(s.systemDNSSettings.Domains) != 0 {

0 commit comments

Comments
 (0)