Merge pull request #1514 from dylan-stella/devel

sc68cal · web-flow · commit fcf6ff5a35c0 · 2026-01-25T18:17:30.000-05:00
Fix faulty IP address DNS check
diff --git a/changelogs/fragments/fix-ip-address-dns-check.yml b/changelogs/fragments/fix-ip-address-dns-check.yml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - nb_inventory - Fix AttributeError when `ip_address` is None during DNS name lookup
diff --git a/plugins/inventory/nb_inventory.py b/plugins/inventory/nb_inventory.py
@@ -1037,7 +1037,7 @@ def extract_dns_name(self, host):
                 )
 
         # Don"t assign a host_var for empty dns_name
-        if ip_address.get("dns_name") == "":
+        if ip_address is None or ip_address.get("dns_name") == "":
             return None
 
         return ip_address.get("dns_name")

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+---`
	`2`	`+bugfixes:`
	`3`	+ - nb_inventory - Fix AttributeError when `ip_address` is None during DNS name lookup
Original file line number	Diff line number	Diff line change
`@@ -1037,7 +1037,7 @@ def extract_dns_name(self, host):`
`1037`	`1037`	`)`
`1038`	`1038`
`1039`	`1039`	`# Don"t assign a host_var for empty dns_name`
`1040`		`- if ip_address.get("dns_name") == "":`
	`1040`	`+ if ip_address is None or ip_address.get("dns_name") == "":`
`1041`	`1041`	`return None`
`1042`	`1042`
`1043`	`1043`	`return ip_address.get("dns_name")`