Skip to content

Commit 82d9d8a

Browse files
authored
Merge pull request #1438 from tobiasge/prepare-netbox-43
Prepare for NetBox 4.3
2 parents f1864f8 + 8431b77 commit 82d9d8a

File tree

7 files changed

+20
-11
lines changed

7 files changed

+20
-11
lines changed

.editorconfig

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,6 @@ indent_size = 2
99

1010
[*.py]
1111
indent_size = 4
12+
13+
[VERSION]
14+
insert_final_newline = false

.github/workflows/release.yml

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@ jobs:
1313
build:
1414
strategy:
1515
matrix:
16-
build_cmd:
17-
- ./build-latest.sh
18-
- PRERELEASE=true ./build-latest.sh
19-
- ./build.sh feature
20-
- ./build.sh main
16+
build:
17+
- { "cmd": "./build-latest.sh", "branch": "release" }
18+
- { "cmd": "./build.sh main", "branch": "release" }
19+
# Build pre release images from our develop branch
20+
# This is used to test the latest changes before they are merged into the main branch
21+
- { "cmd": "PRERELEASE=true ./build-latest.sh", "branch": "develop" }
22+
- { "cmd": "./build.sh feature", "branch": "develop" }
2123
platform:
2224
- linux/amd64,linux/arm64
2325
fail-fast: false
@@ -31,15 +33,17 @@ jobs:
3133
- id: source-checkout
3234
name: Checkout
3335
uses: actions/checkout@v4
36+
with:
37+
ref: ${{ matrix.build.branch }}
3438
- id: set-netbox-docker-version
3539
name: Get Version of NetBox Docker
3640
run: echo "version=$(cat VERSION)" >>"$GITHUB_OUTPUT"
3741
shell: bash
3842
- id: check-build-needed
39-
name: Check if the build is needed for '${{ matrix.build_cmd }}'
43+
name: Check if the build is needed for '${{ matrix.build.cmd }}'
4044
env:
4145
CHECK_ONLY: "true"
42-
run: ${{ matrix.build_cmd }}
46+
run: ${{ matrix.build.cmd }}
4347
# docker.io
4448
- id: docker-io-login
4549
name: Login to docker.io
@@ -77,7 +81,7 @@ jobs:
7781
if: steps.check-build-needed.outputs.skipped != 'true'
7882
- id: build-and-push
7983
name: Push the image
80-
run: ${{ matrix.build_cmd }} --push
84+
run: ${{ matrix.build.cmd }} --push
8185
if: steps.check-build-needed.outputs.skipped != 'true'
8286
env:
8387
BUILDX_PLATFORM: ${{ matrix.platform }}

Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ RUN \
3333
# we have potential version conflicts and the build will fail.
3434
# That's why we just replace it in the original requirements.txt.
3535
sed -i -e 's/social-auth-core/social-auth-core\[all\]/g' /requirements.txt && \
36+
# The same is true for 'django-storages'
37+
sed -i -e 's/django-storages/django-storages\[azure,boto3,dropbox,google,libcloud,sftp\]/g' /requirements.txt && \
3638
/usr/local/bin/uv pip install \
3739
-r /requirements.txt \
3840
-r /requirements-container.txt

VERSION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.2.0
1+
3.3.0

docker-compose.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
services:
22
netbox: &netbox
3-
image: docker.io/netboxcommunity/netbox:${VERSION-v4.2-3.2.0}
3+
image: docker.io/netboxcommunity/netbox:${VERSION-v4.3-3.3.0}
44
depends_on:
55
- postgres
66
- redis

requirements-container.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
django-auth-ldap==5.1.0
2-
django-storages[azure,boto3,dropbox,google,libcloud,sftp]==1.14.6
32
dulwich==0.22.8
43
python3-saml==1.16.0
54
--no-binary lxml

test-configuration/test_config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,6 @@
77
'netbox.tests.dummy_plugin',
88
]
99

10+
ALLOW_TOKEN_RETRIEVAL = True
1011

1112
DEFAULT_PERMISSIONS = {}

0 commit comments

Comments
 (0)