Skip to content

Commit 0ce2b1b

Browse files
authored
13845 fix device type image save (#13851)
* 13845 check original image is null in save * 13845 update delete image code
1 parent 04796a6 commit 0ce2b1b

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

netbox/dcim/models/devices.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
from functools import cached_property
55

66
from django.core.exceptions import ValidationError
7+
from django.core.files.storage import default_storage
78
from django.core.validators import MaxValueValidator, MinValueValidator
89
from django.db import models
910
from django.db.models import F, ProtectedError
@@ -332,10 +333,10 @@ def save(self, *args, **kwargs):
332333
ret = super().save(*args, **kwargs)
333334

334335
# Delete any previously uploaded image files that are no longer in use
335-
if self.front_image != self._original_front_image:
336-
self._original_front_image.delete(save=False)
337-
if self.rear_image != self._original_rear_image:
338-
self._original_rear_image.delete(save=False)
336+
if self._original_front_image and self.front_image != self._original_front_image:
337+
default_storage.delete(self._original_front_image)
338+
if self._original_rear_image and self.rear_image != self._original_rear_image:
339+
default_storage.delete(self._original_rear_image)
339340

340341
return ret
341342

0 commit comments

Comments
 (0)