Skip to content

Commit 19da92b

Browse files
committed
#11488: Additional cleanup
1 parent beb1f4e commit 19da92b

File tree

3 files changed

+22
-20
lines changed

3 files changed

+22
-20
lines changed

netbox/circuits/api/serializers.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,8 @@ class CircuitCircuitTerminationSerializer(WritableNestedSerializer):
7676
class Meta:
7777
model = CircuitTermination
7878
fields = [
79-
'id', 'url', 'display', 'site', 'provider_network', 'port_speed', 'upstream_speed', 'xconnect_id', 'description',
79+
'id', 'url', 'display', 'site', 'provider_network', 'port_speed', 'upstream_speed', 'xconnect_id',
80+
'description',
8081
]
8182

8283

netbox/dcim/api/serializers.py

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -672,6 +672,22 @@ def get_parent_device(self, obj):
672672
return data
673673

674674

675+
class DeviceWithConfigContextSerializer(DeviceSerializer):
676+
config_context = serializers.SerializerMethodField()
677+
678+
class Meta(DeviceSerializer.Meta):
679+
fields = [
680+
'id', 'url', 'display', 'name', 'device_type', 'device_role', 'tenant', 'platform', 'serial', 'asset_tag',
681+
'site', 'location', 'rack', 'position', 'face', 'parent_device', 'status', 'airflow', 'primary_ip',
682+
'primary_ip4', 'primary_ip6', 'cluster', 'virtual_chassis', 'vc_position', 'vc_priority', 'description',
683+
'comments', 'local_context_data', 'tags', 'custom_fields', 'config_context', 'created', 'last_updated',
684+
]
685+
686+
@swagger_serializer_method(serializer_or_field=serializers.JSONField)
687+
def get_config_context(self, obj):
688+
return obj.get_config_context()
689+
690+
675691
class VirtualDeviceContextSerializer(NetBoxModelSerializer):
676692
url = serializers.HyperlinkedIdentityField(view_name='dcim-api:device-detail')
677693
device = NestedDeviceSerializer()
@@ -687,7 +703,8 @@ class Meta:
687703
model = VirtualDeviceContext
688704
fields = [
689705
'id', 'url', 'display', 'name', 'device', 'identifier', 'tenant', 'primary_ip', 'primary_ip4',
690-
'primary_ip6', 'status', 'comments', 'tags', 'custom_fields', 'created', 'last_updated', 'interface_count', 'description',
706+
'primary_ip6', 'status', 'description', 'comments', 'tags', 'custom_fields', 'created', 'last_updated',
707+
'interface_count',
691708
]
692709

693710

@@ -706,22 +723,6 @@ class Meta:
706723
]
707724

708725

709-
class DeviceWithConfigContextSerializer(DeviceSerializer):
710-
config_context = serializers.SerializerMethodField()
711-
712-
class Meta(DeviceSerializer.Meta):
713-
fields = [
714-
'id', 'url', 'display', 'name', 'device_type', 'device_role', 'tenant', 'platform', 'serial', 'asset_tag',
715-
'site', 'location', 'rack', 'position', 'face', 'parent_device', 'status', 'airflow', 'primary_ip',
716-
'primary_ip4', 'primary_ip6', 'cluster', 'virtual_chassis', 'vc_position', 'vc_priority', 'comments',
717-
'local_context_data', 'tags', 'custom_fields', 'config_context', 'created', 'last_updated', 'description',
718-
]
719-
720-
@swagger_serializer_method(serializer_or_field=serializers.JSONField)
721-
def get_config_context(self, obj):
722-
return obj.get_config_context()
723-
724-
725726
class DeviceNAPALMSerializer(serializers.Serializer):
726727
method = serializers.JSONField()
727728

netbox/virtualization/api/serializers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,8 @@ class VirtualMachineWithConfigContextSerializer(VirtualMachineSerializer):
9696
class Meta(VirtualMachineSerializer.Meta):
9797
fields = [
9898
'id', 'url', 'display', 'name', 'status', 'site', 'cluster', 'device', 'role', 'tenant', 'platform',
99-
'primary_ip', 'primary_ip4', 'primary_ip6', 'vcpus', 'memory', 'disk', 'comments', 'local_context_data',
100-
'tags', 'custom_fields', 'config_context', 'created', 'last_updated', 'description',
99+
'primary_ip', 'primary_ip4', 'primary_ip6', 'vcpus', 'memory', 'disk', 'description', 'comments',
100+
'local_context_data', 'tags', 'custom_fields', 'config_context', 'created', 'last_updated',
101101
]
102102

103103
@swagger_serializer_method(serializer_or_field=serializers.JSONField)

0 commit comments

Comments
 (0)